aboutsummaryrefslogtreecommitdiff
path: root/src/main/java/gregtech/common/covers
diff options
context:
space:
mode:
Diffstat (limited to 'src/main/java/gregtech/common/covers')
-rw-r--r--src/main/java/gregtech/common/covers/GT_Cover_FluidRegulator.java10
-rw-r--r--src/main/java/gregtech/common/covers/GT_Cover_Pump.java28
2 files changed, 8 insertions, 30 deletions
diff --git a/src/main/java/gregtech/common/covers/GT_Cover_FluidRegulator.java b/src/main/java/gregtech/common/covers/GT_Cover_FluidRegulator.java
index ce11a397f4..7d2afb838d 100644
--- a/src/main/java/gregtech/common/covers/GT_Cover_FluidRegulator.java
+++ b/src/main/java/gregtech/common/covers/GT_Cover_FluidRegulator.java
@@ -108,14 +108,8 @@ public class GT_Cover_FluidRegulator extends GT_CoverBehaviorBase<GT_Cover_Fluid
}
if (tTank1 != null && tTank2 != null) {
allowFluid = true;
- FluidStack tLiquid = tTank1.drain(directionFrom, Math.abs(aCoverVariable.speed), false);
- if (tLiquid != null && this.canTransferFluid(tLiquid)) {
- tLiquid = tLiquid.copy();
- tLiquid.amount = tTank2.fill(directionTo, tLiquid, false);
- if (tLiquid.amount > 0) {
- tTank2.fill(directionTo, tTank1.drain(directionFrom, tLiquid.amount, true), true);
- }
- }
+ GT_Utility
+ .moveFluid(tTank1, tTank2, directionFrom, Math.abs(aCoverVariable.speed), this::canTransferFluid);
allowFluid = false;
}
}
diff --git a/src/main/java/gregtech/common/covers/GT_Cover_Pump.java b/src/main/java/gregtech/common/covers/GT_Cover_Pump.java
index f36f6ce215..e1bbf950ce 100644
--- a/src/main/java/gregtech/common/covers/GT_Cover_Pump.java
+++ b/src/main/java/gregtech/common/covers/GT_Cover_Pump.java
@@ -50,32 +50,16 @@ public class GT_Cover_Pump extends GT_CoverBehavior {
final IFluidHandler toAccess = aTileEntity.getITankContainerAtSide(side);
if (toAccess == null) return aCoverVariable;
- transferFluid(current, toAccess, side, aCoverVariable % 2);
+ transferFluid(current, toAccess, side, aCoverVariable % 2 == 0);
}
return aCoverVariable;
}
- protected void transferFluid(IFluidHandler current, IFluidHandler toAccess, ForgeDirection side,
- int exportOrImport) {
- if (exportOrImport == 0) {
- FluidStack liquid = current.drain(side, this.mTransferRate, false);
- if (liquid != null) {
- liquid = liquid.copy();
- liquid.amount = toAccess.fill(side.getOpposite(), liquid, false);
- if (liquid.amount > 0 && canTransferFluid(liquid)) {
- toAccess.fill(side.getOpposite(), current.drain(side, liquid.amount, true), true);
- }
- }
- return;
- }
- FluidStack liquid = toAccess.drain(side.getOpposite(), this.mTransferRate, false);
- if (liquid != null) {
- liquid = liquid.copy();
- liquid.amount = current.fill(side, liquid, false);
- if (liquid.amount > 0 && canTransferFluid(liquid)) {
- current.fill(side, toAccess.drain(side.getOpposite(), liquid.amount, true), true);
- }
- }
+ protected void transferFluid(IFluidHandler current, IFluidHandler toAccess, ForgeDirection side, boolean export) {
+ IFluidHandler source = export ? current : toAccess;
+ IFluidHandler dest = export ? toAccess : current;
+ ForgeDirection drainSide = export ? side : side.getOpposite();
+ GT_Utility.moveFluid(source, dest, drainSide, mTransferRate, this::canTransferFluid);
}
protected boolean canTransferFluid(FluidStack fluid) {