From 7fd0e849dfcbd5955d8283a5ec6a9caa18c9e2f8 Mon Sep 17 00:00:00 2001 From: Technus Date: Fri, 20 Oct 2017 21:00:32 +0200 Subject: fix eplosion stack overflow and refactor constant name --- .../elementalMatter/core/interfaces/iElementalDefinition.java | 2 +- .../elementalMatter/definitions/complex/dAtomDefinition.java | 6 +++--- .../elementalMatter/definitions/complex/dHadronDefinition.java | 2 +- src/main/java/com/github/technus/tectech/loader/AtomOverrider.java | 6 +++--- .../thing/metaTileEntity/multi/GT_MetaTileEntity_EM_decay.java | 4 ++-- .../metaTileEntity/multi/GT_MetaTileEntity_MultiblockBase_EM.java | 5 +++-- .../github/technus/tectech/thing/metaTileEntity/multi/other todo | 6 ++++++ 7 files changed, 19 insertions(+), 12 deletions(-) (limited to 'src/main/java/com') diff --git a/src/main/java/com/github/technus/tectech/elementalMatter/core/interfaces/iElementalDefinition.java b/src/main/java/com/github/technus/tectech/elementalMatter/core/interfaces/iElementalDefinition.java index 97c1c8c98f..ea34530057 100644 --- a/src/main/java/com/github/technus/tectech/elementalMatter/core/interfaces/iElementalDefinition.java +++ b/src/main/java/com/github/technus/tectech/elementalMatter/core/interfaces/iElementalDefinition.java @@ -12,7 +12,7 @@ import net.minecraft.nbt.NBTTagCompound; * Created by danie_000 on 11.11.2016. */ public interface iElementalDefinition extends Comparable,Cloneable {//IMMUTABLE - float stableRawLifeTime=1.5e25f; + float STABLE_RAW_LIFE_TIME =1.5e25f; //Nomenclature String getName(); diff --git a/src/main/java/com/github/technus/tectech/elementalMatter/definitions/complex/dAtomDefinition.java b/src/main/java/com/github/technus/tectech/elementalMatter/definitions/complex/dAtomDefinition.java index 0c4278a344..be4e5150df 100644 --- a/src/main/java/com/github/technus/tectech/elementalMatter/definitions/complex/dAtomDefinition.java +++ b/src/main/java/com/github/technus/tectech/elementalMatter/definitions/complex/dAtomDefinition.java @@ -143,13 +143,13 @@ public final class dAtomDefinition extends cElementalDefinition { else rawLifeTimeTemp= calculateLifeTime(izoDiff, izoDiffAbs, element, neutralCount, containsAnti); - this.rawLifeTime=rawLifeTimeTemp>stableRawLifeTime?stableRawLifeTime:rawLifeTimeTemp; + this.rawLifeTime=rawLifeTimeTemp> STABLE_RAW_LIFE_TIME ? STABLE_RAW_LIFE_TIME :rawLifeTimeTemp; if (izoDiff == 0) this.decayMode = 0; else this.decayMode = izoDiff > 0 ? (byte) Math.min(2, 1 + izoDiffAbs / 4) : (byte) -Math.min(2, 1 + izoDiffAbs / 4); - this.stable = this.rawLifeTime>=stableRawLifeTime; + this.stable = this.rawLifeTime>= STABLE_RAW_LIFE_TIME; } private static int stableIzoCurve(int element) { @@ -517,7 +517,7 @@ public final class dAtomDefinition extends cElementalDefinition { final int izoDiff = isotope - StableIsotope; final int izoDiffAbs = Math.abs(izoDiff); final float rawLifeTime = calculateLifeTime(izoDiff, izoDiffAbs, element, isotope, false); - if (rawLifeTime>=stableRawLifeTime) { + if (rawLifeTime>= STABLE_RAW_LIFE_TIME) { TreeSet isotopes = stableIsotopes.get(element); if (isotopes == null) stableIsotopes.put(element, isotopes = new TreeSet<>()); isotopes.add(isotope); diff --git a/src/main/java/com/github/technus/tectech/elementalMatter/definitions/complex/dHadronDefinition.java b/src/main/java/com/github/technus/tectech/elementalMatter/definitions/complex/dHadronDefinition.java index 88c5148c21..d473abcb6d 100644 --- a/src/main/java/com/github/technus/tectech/elementalMatter/definitions/complex/dHadronDefinition.java +++ b/src/main/java/com/github/technus/tectech/elementalMatter/definitions/complex/dHadronDefinition.java @@ -89,7 +89,7 @@ public final class dHadronDefinition extends cElementalDefinition {//TODO Optimi int mult = this.amount * this.amount * (this.amount - 1); this.mass = mass * 5.543F * (float) mult;//yes it becomes heavier - if (this.mass == protonMass && this.amount == 3) this.rawLifeTime = stableRawLifeTime; + if (this.mass == protonMass && this.amount == 3) this.rawLifeTime = STABLE_RAW_LIFE_TIME; else if (this.mass == neutronMass && this.amount == 3) this.rawLifeTime = 882F; else { if (this.amount == 3) { diff --git a/src/main/java/com/github/technus/tectech/loader/AtomOverrider.java b/src/main/java/com/github/technus/tectech/loader/AtomOverrider.java index 112cb793ad..34bbbf4d93 100644 --- a/src/main/java/com/github/technus/tectech/loader/AtomOverrider.java +++ b/src/main/java/com/github/technus/tectech/loader/AtomOverrider.java @@ -6,7 +6,7 @@ import com.github.technus.tectech.elementalMatter.definitions.complex.dAtomDefin import com.github.technus.tectech.elementalMatter.definitions.complex.dHadronDefinition; import com.github.technus.tectech.elementalMatter.definitions.primitive.eLeptonDefinition; -import static com.github.technus.tectech.elementalMatter.core.interfaces.iElementalDefinition.stableRawLifeTime; +import static com.github.technus.tectech.elementalMatter.core.interfaces.iElementalDefinition.STABLE_RAW_LIFE_TIME; import static com.github.technus.tectech.elementalMatter.definitions.complex.dAtomDefinition.addOverride; /** @@ -20,13 +20,13 @@ public class AtomOverrider implements Runnable{ new cElementalDefinitionStack(eLeptonDefinition.lepton_e, 2), dHadronDefinition.hadron_p2, new cElementalDefinitionStack(dHadronDefinition.hadron_n, 3) - ), stableRawLifeTime);//He3 + ), STABLE_RAW_LIFE_TIME);//He3 addOverride(new dAtomDefinition( eLeptonDefinition.lepton_e1, dHadronDefinition.hadron_p1, dHadronDefinition.hadron_n1 - ), stableRawLifeTime);//D + ), STABLE_RAW_LIFE_TIME);//D addOverride(new dAtomDefinition( eLeptonDefinition.lepton_e1, diff --git a/src/main/java/com/github/technus/tectech/thing/metaTileEntity/multi/GT_MetaTileEntity_EM_decay.java b/src/main/java/com/github/technus/tectech/thing/metaTileEntity/multi/GT_MetaTileEntity_EM_decay.java index a5afef3024..9395d5de37 100644 --- a/src/main/java/com/github/technus/tectech/thing/metaTileEntity/multi/GT_MetaTileEntity_EM_decay.java +++ b/src/main/java/com/github/technus/tectech/thing/metaTileEntity/multi/GT_MetaTileEntity_EM_decay.java @@ -20,7 +20,7 @@ import net.minecraft.util.EnumChatFormatting; import static com.github.technus.tectech.Util.StructureBuilder; import static com.github.technus.tectech.Util.VN; -import static com.github.technus.tectech.elementalMatter.core.interfaces.iElementalDefinition.stableRawLifeTime; +import static com.github.technus.tectech.elementalMatter.core.interfaces.iElementalDefinition.STABLE_RAW_LIFE_TIME; import static com.github.technus.tectech.thing.casing.GT_Block_CasingsTT.textureOffset; import static com.github.technus.tectech.thing.casing.GT_Block_CasingsTT.texturePage; import static com.github.technus.tectech.thing.casing.TT_Container_Casings.sBlockCasingsTT; @@ -112,7 +112,7 @@ public class GT_MetaTileEntity_EM_decay extends GT_MetaTileEntity_MultiblockBase @Override public boolean checkRecipe_EM(ItemStack itemStack) { cElementalInstanceStackMap map= getInputsClone_EM(); - if(map!=null && map.hasStacks() && map.getFirst().getLifeTime()