From b088958c9f6935d356b6c087c8e8106b400aa24f Mon Sep 17 00:00:00 2001
From: Raven Szewczyk <git@eigenraven.me>
Date: Sat, 1 Apr 2023 20:06:12 +0100
Subject: Jabel, Generic injection and mostly automatic code cleanup (#1829)

* Enable Jabel&Generic injection, fix type error caused by this

* add missing <>

* Infer generic types automatically

* Parametrize cast types

* Use enhanced for loops

* Unnecessary boxing

* Unnecessary unboxing

* Use Objects.equals

* Explicit type can be replaced with `<>`

* Collapse identical catch blocks

* Add SafeVarargs where applicable

* Anonymous type can be replaced with lambda

* Use List.sort directly

* Lambda can be a method reference

* Statement lambda can be an expression lambda

* Use string switches

* Instanceof pattern matching

* Text block can be used

* Migrate to enhanced switch

* Java style array declarations

* Unnecessary toString()

* More unnecessary String conversions

* Unnecessary modifiers

* Unnecessary semicolons

* Fix duplicate conditions

* Extract common code from if branches

* Replace switches with ifs for 1-2 cases

* Inner class may be static

* Minor performance issues

* Replace string appending in loops with string builders

* Fix IntelliJ using the wrong empty list method

* Use Long.compare

* Generic arguments: getSubItems

* Generic arguments: getSubBlocks

* Raw types warnings

* Fix remaining missing generics

* Too weak variable type leads to unnecessary cast

* Redundant type casts

* Redundant array length check

* Redundant vararg arrays

* Manual min/max implementations

* A couple missed inspections

* Goodbye explosion power ternary ladder

* Apply spotless

* Get rid of the other two big ternary ladders

* Binary search explosion power

* Don't overcomplicate things
---
 src/main/java/gregtech/api/gui/modularui/GT_UIInfos.java | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

(limited to 'src/main/java/gregtech/api/gui/modularui/GT_UIInfos.java')

diff --git a/src/main/java/gregtech/api/gui/modularui/GT_UIInfos.java b/src/main/java/gregtech/api/gui/modularui/GT_UIInfos.java
index e068cd967e..4d004429b0 100644
--- a/src/main/java/gregtech/api/gui/modularui/GT_UIInfos.java
+++ b/src/main/java/gregtech/api/gui/modularui/GT_UIInfos.java
@@ -89,8 +89,7 @@ public class GT_UIInfos {
                     UIBuilder.of()
                              .container((player, world, x, y, z) -> {
                                  final TileEntity te = world.getTileEntity(x, y, z);
-                                 if (!(te instanceof ICoverable)) return null;
-                                 final ICoverable gtTileEntity = (ICoverable) te;
+                                 if (!(te instanceof ICoverable gtTileEntity)) return null;
                                  GT_CoverBehaviorBase<?> cover = gtTileEntity.getCoverBehaviorAtSideNew(side);
                                  return createCoverContainer(
                                          player,
@@ -103,8 +102,7 @@ public class GT_UIInfos {
                              .gui((player, world, x, y, z) -> {
                                  if (!world.isRemote) return null;
                                  final TileEntity te = world.getTileEntity(x, y, z);
-                                 if (!(te instanceof ICoverable)) return null;
-                                 final ICoverable gtTileEntity = (ICoverable) te;
+                                 if (!(te instanceof ICoverable gtTileEntity)) return null;
                                  final GT_CoverBehaviorBase<?> cover = gtTileEntity.getCoverBehaviorAtSideNew(side);
                                  return createCoverGuiContainer(
                                          player,
-- 
cgit