From b088958c9f6935d356b6c087c8e8106b400aa24f Mon Sep 17 00:00:00 2001
From: Raven Szewczyk <git@eigenraven.me>
Date: Sat, 1 Apr 2023 20:06:12 +0100
Subject: Jabel, Generic injection and mostly automatic code cleanup (#1829)

* Enable Jabel&Generic injection, fix type error caused by this

* add missing <>

* Infer generic types automatically

* Parametrize cast types

* Use enhanced for loops

* Unnecessary boxing

* Unnecessary unboxing

* Use Objects.equals

* Explicit type can be replaced with `<>`

* Collapse identical catch blocks

* Add SafeVarargs where applicable

* Anonymous type can be replaced with lambda

* Use List.sort directly

* Lambda can be a method reference

* Statement lambda can be an expression lambda

* Use string switches

* Instanceof pattern matching

* Text block can be used

* Migrate to enhanced switch

* Java style array declarations

* Unnecessary toString()

* More unnecessary String conversions

* Unnecessary modifiers

* Unnecessary semicolons

* Fix duplicate conditions

* Extract common code from if branches

* Replace switches with ifs for 1-2 cases

* Inner class may be static

* Minor performance issues

* Replace string appending in loops with string builders

* Fix IntelliJ using the wrong empty list method

* Use Long.compare

* Generic arguments: getSubItems

* Generic arguments: getSubBlocks

* Raw types warnings

* Fix remaining missing generics

* Too weak variable type leads to unnecessary cast

* Redundant type casts

* Redundant array length check

* Redundant vararg arrays

* Manual min/max implementations

* A couple missed inspections

* Goodbye explosion power ternary ladder

* Apply spotless

* Get rid of the other two big ternary ladders

* Binary search explosion power

* Don't overcomplicate things
---
 src/main/java/gregtech/api/gui/widgets/GT_GuiTooltip.java | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

(limited to 'src/main/java/gregtech/api/gui/widgets/GT_GuiTooltip.java')

diff --git a/src/main/java/gregtech/api/gui/widgets/GT_GuiTooltip.java b/src/main/java/gregtech/api/gui/widgets/GT_GuiTooltip.java
index 1162630d5e..326e744382 100644
--- a/src/main/java/gregtech/api/gui/widgets/GT_GuiTooltip.java
+++ b/src/main/java/gregtech/api/gui/widgets/GT_GuiTooltip.java
@@ -2,7 +2,6 @@ package gregtech.api.gui.widgets;
 
 import java.awt.Rectangle;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 
@@ -44,10 +43,10 @@ public class GT_GuiTooltip {
 
     private TooltipData sanitizeTooltipData(TooltipData data) {
         if (data.text == null) {
-            data.text = Arrays.asList(new String[0]);
+            data.text = Collections.emptyList();
         }
         if (data.shiftText == null) {
-            data.shiftText = Arrays.asList(new String[0]);
+            data.shiftText = Collections.emptyList();
         }
         return data;
     }
@@ -97,10 +96,10 @@ public class GT_GuiTooltip {
         List<String> list;
         if (text != null) {
             list = new ArrayList<>(text.length);
-            for (int i = 0; i < text.length; i++) {
-                if (text[i] == null) continue;
-                if (list.isEmpty()) list.add("\u00a7f" + text[i]);
-                else list.add("\u00a77" + text[i]);
+            for (String s : text) {
+                if (s == null) continue;
+                if (list.isEmpty()) list.add("\u00a7f" + s);
+                else list.add("\u00a77" + s);
             }
         } else {
             list = Collections.emptyList();
-- 
cgit