From fbdbb388c369fae549cfde3eed38b536f7461d90 Mon Sep 17 00:00:00 2001 From: Connor-Colenso <52056774+Connor-Colenso@users.noreply.github.com> Date: Wed, 18 Oct 2023 17:03:23 +0100 Subject: Cleaning up (#767) * Kill playerAPI * Gut more events and compat that is now obsolete * Remove commented out code * Remove final modifier from methods * Make more stuff final * Remove slow building ring * Protected -> private in final classes * More cleaning * More cleaning v2 * Purging * Clean DevHelper * Clean DevHelper 2 * delete DevHelper * remove useless IFMLLoadingPlugin.MCVersion annotation from @Mod files * check for obfuscation only once in the IFMLloadingPlugin.injectData * don't instantiate the static class ASMConfig * delete unused and empty implementation of IFMLCallHook * delete empty class * delete ClassesToTransform class that just holds the class names constants * delete unused methods and unsless logging in dummymod container * delete unused transformer ClassTransformer_TT_ThaumicRestorer * spotless * Clean * Clean utils * Build checkpoint * Purge * Stage 2 * Stage 3 * Stage 4 * Stage 5 * Stage 6 * Spotless * Imports * Stage idk * Stage 1 * Fix issue * Spotless * Format numbers --------- Co-authored-by: GTNH-Colen <54497873+GTNH-Colen@users.noreply.github.com> Co-authored-by: Alexdoru <57050655+Alexdoru@users.noreply.github.com> Co-authored-by: Connor Colenso --- .../java/gtPlusPlus/plugin/manager/Core_Manager.java | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) (limited to 'src/main/java/gtPlusPlus/plugin/manager') diff --git a/src/main/java/gtPlusPlus/plugin/manager/Core_Manager.java b/src/main/java/gtPlusPlus/plugin/manager/Core_Manager.java index 72ec918d37..be1dafd231 100644 --- a/src/main/java/gtPlusPlus/plugin/manager/Core_Manager.java +++ b/src/main/java/gtPlusPlus/plugin/manager/Core_Manager.java @@ -7,7 +7,7 @@ import gtPlusPlus.core.util.reflect.ReflectionUtils; public class Core_Manager { - public static AutoMap mPlugins = new AutoMap(); + public static AutoMap mPlugins = new AutoMap<>(); /** * @param plugin - Dynamically registers the plugin for loading. @@ -36,7 +36,7 @@ public class Core_Manager { } } return true; - } catch (Throwable t) {} + } catch (Throwable ignored) {} return false; } @@ -50,7 +50,7 @@ public class Core_Manager { } } return true; - } catch (Throwable t) {} + } catch (Throwable ignored) {} return false; } @@ -64,11 +64,11 @@ public class Core_Manager { } } return true; - } catch (Throwable t) {} + } catch (Throwable ignored) {} return false; } - public static boolean serverStart() { + public static void serverStart() { try { for (IPlugin h : mPlugins) { if (h.serverStart()) { @@ -77,12 +77,10 @@ public class Core_Manager { Logger.INFO("[Plugin] Failed during Server Start Phase for " + h.getPluginName() + "."); } } - return true; - } catch (Throwable t) {} - return false; + } catch (Throwable ignored) {} } - public static boolean serverStop() { + public static void serverStop() { try { for (IPlugin h : mPlugins) { if (h.serverStop()) { @@ -91,8 +89,6 @@ public class Core_Manager { Logger.INFO("[Plugin] Failed during Server Stop Phase for " + h.getPluginName() + "."); } } - return true; - } catch (Throwable t) {} - return false; + } catch (Throwable ignored) {} } } -- cgit