From fbdbb388c369fae549cfde3eed38b536f7461d90 Mon Sep 17 00:00:00 2001 From: Connor-Colenso <52056774+Connor-Colenso@users.noreply.github.com> Date: Wed, 18 Oct 2023 17:03:23 +0100 Subject: Cleaning up (#767) * Kill playerAPI * Gut more events and compat that is now obsolete * Remove commented out code * Remove final modifier from methods * Make more stuff final * Remove slow building ring * Protected -> private in final classes * More cleaning * More cleaning v2 * Purging * Clean DevHelper * Clean DevHelper 2 * delete DevHelper * remove useless IFMLLoadingPlugin.MCVersion annotation from @Mod files * check for obfuscation only once in the IFMLloadingPlugin.injectData * don't instantiate the static class ASMConfig * delete unused and empty implementation of IFMLCallHook * delete empty class * delete ClassesToTransform class that just holds the class names constants * delete unused methods and unsless logging in dummymod container * delete unused transformer ClassTransformer_TT_ThaumicRestorer * spotless * Clean * Clean utils * Build checkpoint * Purge * Stage 2 * Stage 3 * Stage 4 * Stage 5 * Stage 6 * Spotless * Imports * Stage idk * Stage 1 * Fix issue * Spotless * Format numbers --------- Co-authored-by: GTNH-Colen <54497873+GTNH-Colen@users.noreply.github.com> Co-authored-by: Alexdoru <57050655+Alexdoru@users.noreply.github.com> Co-authored-by: Connor Colenso --- .../gtPlusPlus/xmod/forestry/bees/handler/GTPP_CombType.java | 12 ++++++------ .../gtPlusPlus/xmod/forestry/bees/handler/GTPP_DropType.java | 10 +++++----- .../xmod/forestry/bees/handler/GTPP_PollenType.java | 10 +++++----- .../xmod/forestry/bees/handler/GTPP_PropolisType.java | 10 +++++----- 4 files changed, 21 insertions(+), 21 deletions(-) (limited to 'src/main/java/gtPlusPlus/xmod/forestry/bees/handler') diff --git a/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_CombType.java b/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_CombType.java index 3495869c97..4bc47fa7bd 100644 --- a/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_CombType.java +++ b/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_CombType.java @@ -13,13 +13,13 @@ public enum GTPP_CombType { FORCE(1, "Force", true, 30, Utils.rgbtoHexValue(250, 250, 20), Utils.rgbtoHexValue(200, 200, 5)); public boolean mShowInList; - public Material mMaterial; - public int mChance; - public int mID; + public final Material mMaterial; + public final int mChance; + public final int mID; - private String mName; - private String mNameUnlocal; - private int[] mColour; + private final String mName; + private final String mNameUnlocal; + private final int[] mColour; private static void map(int aId, GTPP_CombType aType) { GTPP_Bees.sCombMappings.put(aId, aType); diff --git a/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_DropType.java b/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_DropType.java index cbf448b7f6..6f43d4a43e 100644 --- a/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_DropType.java +++ b/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_DropType.java @@ -13,13 +13,13 @@ public enum GTPP_DropType { FORCE(1, "Force", true, Utils.rgbtoHexValue(250, 250, 20), Utils.rgbtoHexValue(200, 200, 5)); public boolean mShowInList; - public Material mMaterial; + public final Material mMaterial; public int mChance; - public int mID; + public final int mID; - private String mName; - private String mNameUnlocal; - private int[] mColour; + private final String mName; + private final String mNameUnlocal; + private final int[] mColour; private static void map(int aId, GTPP_DropType aType) { GTPP_Bees.sDropMappings.put(aId, aType); diff --git a/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_PollenType.java b/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_PollenType.java index ec49643001..acca5b810f 100644 --- a/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_PollenType.java +++ b/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_PollenType.java @@ -12,13 +12,13 @@ public enum GTPP_PollenType { DRAGONBLOOD(0, "Dragon Blood", true, Utils.rgbtoHexValue(220, 20, 20), Utils.rgbtoHexValue(20, 20, 20)); public boolean mShowInList; - public Material mMaterial; + public final Material mMaterial; public int mChance; - public int mID; + public final int mID; - private String mName; - private String mNameUnlocal; - private int[] mColour; + private final String mName; + private final String mNameUnlocal; + private final int[] mColour; private static void map(int aId, GTPP_PollenType aType) { GTPP_Bees.sPollenMappings.put(aId, aType); diff --git a/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_PropolisType.java b/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_PropolisType.java index b857827d62..b76d79d387 100644 --- a/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_PropolisType.java +++ b/src/main/java/gtPlusPlus/xmod/forestry/bees/handler/GTPP_PropolisType.java @@ -13,13 +13,13 @@ public enum GTPP_PropolisType { FORCE(1, "Force", true, Utils.rgbtoHexValue(250, 250, 20)); public boolean mShowInList; - public Material mMaterial; + public final Material mMaterial; public int mChance; - public int mID; + public final int mID; - private String mName; - private String mNameUnlocal; - private int mColour; + private final String mName; + private final String mNameUnlocal; + private final int mColour; private static void map(int aId, GTPP_PropolisType aType) { GTPP_Bees.sPropolisMappings.put(aId, aType); -- cgit