From 5f6011f705c75007b48735d02e590581c78ca8db Mon Sep 17 00:00:00 2001 From: NotAPenguin Date: Sun, 15 Sep 2024 23:30:13 +0200 Subject: Small optimizations & MultiBlockBase cleanup (#3197) Co-authored-by: Martin Robertz --- .../implementations/base/GTPPMultiBlockBase.java | 20 +++++++++--------- .../implementations/base/MTESteamMultiBase.java | 24 +++++++++++----------- .../processing/MTEIndustrialMultiMachine.java | 4 ++-- .../processing/MTEIndustrialVacuumFreezer.java | 4 ++-- .../machines/multi/processing/MTEIsaMill.java | 4 ++-- .../multi/processing/advanced/MTEAdvEBF.java | 4 ++-- .../multi/production/MTEElementalDuplicator.java | 6 +++--- .../multi/production/MTELargeRocketEngine.java | 6 +++--- .../machines/multi/production/MTETreeFarm.java | 4 ++-- .../production/chemplant/MTEChemicalPlant.java | 4 ++-- .../production/mega/MTEMegaAlloyBlastSmelter.java | 4 ++-- .../production/turbines/MTELargerTurbineBase.java | 14 ++++++------- ...chMetaTileEntity_PowerSubStationController.java | 10 ++++----- 13 files changed, 54 insertions(+), 54 deletions(-) (limited to 'src/main/java/gtPlusPlus/xmod') diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/GTPPMultiBlockBase.java b/src/main/java/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/GTPPMultiBlockBase.java index b1af2451aa..627443245f 100644 --- a/src/main/java/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/GTPPMultiBlockBase.java +++ b/src/main/java/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/GTPPMultiBlockBase.java @@ -1,6 +1,6 @@ package gtPlusPlus.xmod.gregtech.api.metatileentity.implementations.base; -import static gregtech.api.util.GTUtility.filterValidMTEs; +import static gregtech.api.util.GTUtility.validMTEList; import java.lang.reflect.Method; import java.util.ArrayList; @@ -301,7 +301,7 @@ public abstract class GTPPMultiBlockBase aHatches, int aAmount) { - for (final MTEHatchCustomFluidBase tHatch : filterValidMTEs(aHatches)) { + for (final MTEHatchCustomFluidBase tHatch : validMTEList(aHatches)) { FluidStack tLiquid = tHatch.getFluid(); if (tLiquid == null || tLiquid.amount < aAmount) { continue; @@ -507,10 +507,10 @@ public abstract class GTPPMultiBlockBase> extends @Override public boolean depleteInput(FluidStack aLiquid) { if (aLiquid == null) return false; - for (MTEHatchCustomFluidBase tHatch : filterValidMTEs(mSteamInputFluids)) { + for (MTEHatchCustomFluidBase tHatch : validMTEList(mSteamInputFluids)) { FluidStack tLiquid = tHatch.getFluid(); if (tLiquid != null && tLiquid.isFluidEqual(aLiquid)) { tLiquid = tHatch.drain(aLiquid.amount, false); @@ -215,7 +215,7 @@ public abstract class MTESteamMultiBase> extends if (GTUtility.isStackInvalid(aStack)) return false; FluidStack aLiquid = GTUtility.getFluidForFilledItem(aStack, true); if (aLiquid != null) return depleteInput(aLiquid); - for (MTEHatchCustomFluidBase tHatch : filterValidMTEs(mSteamInputFluids)) { + for (MTEHatchCustomFluidBase tHatch : validMTEList(mSteamInputFluids)) { if (GTUtility.areStacksEqual( aStack, tHatch.getBaseMetaTileEntity() @@ -228,7 +228,7 @@ public abstract class MTESteamMultiBase> extends } } } - for (MteHatchSteamBusInput tHatch : filterValidMTEs(mSteamInputs)) { + for (MteHatchSteamBusInput tHatch : validMTEList(mSteamInputs)) { tHatch.mRecipeMap = getRecipeMap(); for (int i = tHatch.getBaseMetaTileEntity() .getSizeInventory() - 1; i >= 0; i--) { @@ -251,7 +251,7 @@ public abstract class MTESteamMultiBase> extends @Override public ArrayList getStoredFluids() { ArrayList rList = new ArrayList<>(); - for (MTEHatchCustomFluidBase tHatch : filterValidMTEs(mSteamInputFluids)) { + for (MTEHatchCustomFluidBase tHatch : validMTEList(mSteamInputFluids)) { if (tHatch.getFillableStack() != null) { rList.add(tHatch.getFillableStack()); } @@ -265,7 +265,7 @@ public abstract class MTESteamMultiBase> extends @Override public ArrayList getStoredInputs() { ArrayList rList = new ArrayList<>(); - for (MteHatchSteamBusInput tHatch : filterValidMTEs(mSteamInputs)) { + for (MteHatchSteamBusInput tHatch : validMTEList(mSteamInputs)) { tHatch.mRecipeMap = getRecipeMap(); for (int i = tHatch.getBaseMetaTileEntity() .getSizeInventory() - 1; i >= 0; i--) { @@ -288,7 +288,7 @@ public abstract class MTESteamMultiBase> extends while (outputSuccess && aStack.stackSize > 0) { outputSuccess = false; ItemStack single = aStack.splitStack(1); - for (MTEHatchSteamBusOutput tHatch : filterValidMTEs(mSteamOutputs)) { + for (MTEHatchSteamBusOutput tHatch : validMTEList(mSteamOutputs)) { if (!outputSuccess) { for (int i = tHatch.getSizeInventory() - 1; i >= 0 && !outputSuccess; i--) { if (tHatch.getBaseMetaTileEntity() @@ -296,7 +296,7 @@ public abstract class MTESteamMultiBase> extends } } } - for (MTEHatchOutput tHatch : filterValidMTEs(mOutputHatches)) { + for (MTEHatchOutput tHatch : validMTEList(mOutputHatches)) { if (!outputSuccess && tHatch.outputsItems()) { if (tHatch.getBaseMetaTileEntity() .addStackToSlot(1, single)) outputSuccess = true; @@ -309,7 +309,7 @@ public abstract class MTESteamMultiBase> extends @Override public ArrayList getStoredOutputs() { ArrayList rList = new ArrayList<>(); - for (MTEHatchSteamBusOutput tHatch : filterValidMTEs(mSteamOutputs)) { + for (MTEHatchSteamBusOutput tHatch : validMTEList(mSteamOutputs)) { for (int i = tHatch.getBaseMetaTileEntity() .getSizeInventory() - 1; i >= 0; i--) { rList.add( @@ -323,7 +323,7 @@ public abstract class MTESteamMultiBase> extends @Override public List getItemOutputSlots(ItemStack[] toOutput) { List ret = new ArrayList<>(); - for (final MTEHatch tBus : filterValidMTEs(mSteamOutputs)) { + for (final MTEHatch tBus : validMTEList(mSteamOutputs)) { final IInventory tBusInv = tBus.getBaseMetaTileEntity(); for (int i = 0; i < tBusInv.getSizeInventory(); i++) { ret.add(tBus.getStackInSlot(i)); @@ -334,8 +334,8 @@ public abstract class MTESteamMultiBase> extends @Override public void updateSlots() { - for (MTEHatchCustomFluidBase tHatch : filterValidMTEs(mSteamInputFluids)) tHatch.updateSlots(); - for (MteHatchSteamBusInput tHatch : filterValidMTEs(mSteamInputs)) tHatch.updateSlots(); + for (MTEHatchCustomFluidBase tHatch : validMTEList(mSteamInputFluids)) tHatch.updateSlots(); + for (MteHatchSteamBusInput tHatch : validMTEList(mSteamInputs)) tHatch.updateSlots(); } @Override diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/processing/MTEIndustrialMultiMachine.java b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/processing/MTEIndustrialMultiMachine.java index 8b0b5594e3..fae1d920a8 100644 --- a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/processing/MTEIndustrialMultiMachine.java +++ b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/processing/MTEIndustrialMultiMachine.java @@ -11,7 +11,7 @@ import static gregtech.api.enums.HatchElement.Muffler; import static gregtech.api.enums.HatchElement.OutputBus; import static gregtech.api.enums.HatchElement.OutputHatch; import static gregtech.api.util.GTStructureUtility.buildHatchAdder; -import static gregtech.api.util.GTUtility.filterValidMTEs; +import static gregtech.api.util.GTUtility.validMTEList; import java.util.ArrayList; import java.util.Arrays; @@ -471,7 +471,7 @@ public class MTEIndustrialMultiMachine extends GTPPMultiBlockBase getStoredFluids() { ArrayList rList = new ArrayList<>(); - for (MTEHatchInput tHatch : filterValidMTEs(mInputHatches)) { + for (MTEHatchInput tHatch : validMTEList(mInputHatches)) { if (tHatch instanceof MTEHatchSolidifier) { continue; } diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/processing/MTEIndustrialVacuumFreezer.java b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/processing/MTEIndustrialVacuumFreezer.java index 3d18a9eda0..b47ccf583f 100644 --- a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/processing/MTEIndustrialVacuumFreezer.java +++ b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/processing/MTEIndustrialVacuumFreezer.java @@ -12,7 +12,7 @@ import static gregtech.api.enums.HatchElement.Muffler; import static gregtech.api.enums.HatchElement.OutputBus; import static gregtech.api.enums.HatchElement.OutputHatch; import static gregtech.api.util.GTStructureUtility.buildHatchAdder; -import static gregtech.api.util.GTUtility.filterValidMTEs; +import static gregtech.api.util.GTUtility.validMTEList; import java.util.ArrayList; import java.util.Objects; @@ -168,7 +168,7 @@ public class MTEIndustrialVacuumFreezer extends GTPPMultiBlockBase implements ISurvi @Override public ArrayList getStoredInputs() { ArrayList tItems = super.getStoredInputs(); - for (MTEHatchMillingBalls tHatch : filterValidMTEs(mMillingBallBuses)) { + for (MTEHatchMillingBalls tHatch : validMTEList(mMillingBallBuses)) { AutoMap aHatchContent = tHatch.getContentUsageSlots(); if (!aHatchContent.isEmpty()) { tItems.addAll(aHatchContent); diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/processing/advanced/MTEAdvEBF.java b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/processing/advanced/MTEAdvEBF.java index 63aec37990..4cedf91f0f 100644 --- a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/processing/advanced/MTEAdvEBF.java +++ b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/processing/advanced/MTEAdvEBF.java @@ -13,7 +13,7 @@ import static gregtech.api.enums.HatchElement.OutputBus; import static gregtech.api.enums.HatchElement.OutputHatch; import static gregtech.api.util.GTStructureUtility.buildHatchAdder; import static gregtech.api.util.GTStructureUtility.ofCoil; -import static gregtech.api.util.GTUtility.filterValidMTEs; +import static gregtech.api.util.GTUtility.validMTEList; import java.util.ArrayList; import java.util.Objects; @@ -189,7 +189,7 @@ public class MTEAdvEBF extends GTPPMultiBlockBase implements ISurviva @Override public void updateSlots() { - for (MTEHatchCustomFluidBase tHatch : filterValidMTEs(mPyrotheumHatches)) tHatch.updateSlots(); + for (MTEHatchCustomFluidBase tHatch : validMTEList(mPyrotheumHatches)) tHatch.updateSlots(); super.updateSlots(); } diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTEElementalDuplicator.java b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTEElementalDuplicator.java index 676b6e817a..e115fe5af1 100644 --- a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTEElementalDuplicator.java +++ b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTEElementalDuplicator.java @@ -11,7 +11,7 @@ import static gregtech.api.enums.HatchElement.Muffler; import static gregtech.api.enums.HatchElement.OutputBus; import static gregtech.api.enums.HatchElement.OutputHatch; import static gregtech.api.util.GTStructureUtility.buildHatchAdder; -import static gregtech.api.util.GTUtility.filterValidMTEs; +import static gregtech.api.util.GTUtility.validMTEList; import java.util.ArrayList; import java.util.Collections; @@ -293,7 +293,7 @@ public class MTEElementalDuplicator extends GTPPMultiBlockBase getStoredInputs() { ArrayList tItems = super.getStoredInputs(); - for (MTEHatchElementalDataOrbHolder tHatch : filterValidMTEs(mReplicatorDataOrbHatches)) { + for (MTEHatchElementalDataOrbHolder tHatch : validMTEList(mReplicatorDataOrbHatches)) { tItems.add(tHatch.getOrbByCircuit()); } tItems.removeAll(Collections.singleton(null)); diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTELargeRocketEngine.java b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTELargeRocketEngine.java index 3a5bbaa42a..f2ddecb687 100644 --- a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTELargeRocketEngine.java +++ b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTELargeRocketEngine.java @@ -9,7 +9,7 @@ import static gregtech.api.enums.HatchElement.InputHatch; import static gregtech.api.enums.HatchElement.Maintenance; import static gregtech.api.enums.HatchElement.Muffler; import static gregtech.api.util.GTStructureUtility.buildHatchAdder; -import static gregtech.api.util.GTUtility.filterValidMTEs; +import static gregtech.api.util.GTUtility.validMTEList; import static gtPlusPlus.xmod.gregtech.api.metatileentity.implementations.base.GTPPMultiBlockBase.GTPPHatchElement.AirIntake; import static gtPlusPlus.xmod.gregtech.api.metatileentity.implementations.base.GTPPMultiBlockBase.GTPPHatchElement.TTDynamo; @@ -387,7 +387,7 @@ public class MTELargeRocketEngine extends GTPPMultiBlockBase implements ISur ItemStack controllerSlot = getControllerSlot(); if (controllerSlot == null || !(controllerSlot.getItem() instanceof MetaGeneratedTool01)) return false; - for (MTEHatchInputBus inputBus : filterValidMTEs(mInputBusses)) { + for (MTEHatchInputBus inputBus : validMTEList(mInputBusses)) { ItemStack[] inventory = inputBus.getRealInventory(); for (int slot = 0; slot < inventory.length; ++slot) { if (isValidSapling(inventory[slot])) { diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/chemplant/MTEChemicalPlant.java b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/chemplant/MTEChemicalPlant.java index 5de235982f..98a14726eb 100644 --- a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/chemplant/MTEChemicalPlant.java +++ b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/chemplant/MTEChemicalPlant.java @@ -11,7 +11,7 @@ import static gregtech.api.enums.HatchElement.OutputHatch; import static gregtech.api.util.GTStructureUtility.buildHatchAdder; import static gregtech.api.util.GTStructureUtility.filterByMTETier; import static gregtech.api.util.GTStructureUtility.ofCoil; -import static gregtech.api.util.GTUtility.filterValidMTEs; +import static gregtech.api.util.GTUtility.validMTEList; import java.util.ArrayList; import java.util.Arrays; @@ -659,7 +659,7 @@ public class MTEChemicalPlant extends GTPPMultiBlockBase imple */ public ArrayList getCatalystInputs() { ArrayList tItems = new ArrayList<>(); - for (MTEHatchCatalysts tHatch : filterValidMTEs(mCatalystBuses)) { + for (MTEHatchCatalysts tHatch : validMTEList(mCatalystBuses)) { AutoMap aHatchContent = tHatch.getContentUsageSlots(); if (!aHatchContent.isEmpty()) { tItems.addAll(aHatchContent); diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/mega/MTEMegaAlloyBlastSmelter.java b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/mega/MTEMegaAlloyBlastSmelter.java index 41f97910bd..8e97ae11f3 100644 --- a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/mega/MTEMegaAlloyBlastSmelter.java +++ b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/mega/MTEMegaAlloyBlastSmelter.java @@ -14,7 +14,7 @@ import static gregtech.api.enums.HatchElement.OutputBus; import static gregtech.api.enums.HatchElement.OutputHatch; import static gregtech.api.util.GTStructureUtility.buildHatchAdder; import static gregtech.api.util.GTStructureUtility.ofCoil; -import static gregtech.api.util.GTUtility.filterValidMTEs; +import static gregtech.api.util.GTUtility.validMTEList; import java.util.ArrayList; import java.util.List; @@ -335,7 +335,7 @@ public class MTEMegaAlloyBlastSmelter extends MTEExtendedPowerMultiBlockBase= 10000) { if (PollutionUtils.addPollution(this.getBaseMetaTileEntity(), 10000)) { mPollution -= 10000; @@ -770,7 +770,7 @@ public abstract class MTELargerTurbineBase extends GTPPMultiBlockBase