From 3b9bd1188e932e6bb8041f7bb9afbf3ce75e26d3 Mon Sep 17 00:00:00 2001
From: Alexdoru <57050655+Alexdoru@users.noreply.github.com>
Date: Wed, 2 Oct 2024 07:31:08 +0200
Subject: Cleanup the codebase (#3311)

Co-authored-by: boubou19 <miisterunknown@gmail.com>
---
 .../thing/metaTileEntity/multi/base/LedStatus.java      |  5 ++---
 .../metaTileEntity/multi/base/SoundLoopAnyBlock.java    |  6 +++---
 .../metaTileEntity/multi/base/TTMultiblockBase.java     | 17 +----------------
 3 files changed, 6 insertions(+), 22 deletions(-)

(limited to 'src/main/java/tectech/thing/metaTileEntity/multi/base')

diff --git a/src/main/java/tectech/thing/metaTileEntity/multi/base/LedStatus.java b/src/main/java/tectech/thing/metaTileEntity/multi/base/LedStatus.java
index 022408f688..0f7f42ee2e 100644
--- a/src/main/java/tectech/thing/metaTileEntity/multi/base/LedStatus.java
+++ b/src/main/java/tectech/thing/metaTileEntity/multi/base/LedStatus.java
@@ -1,5 +1,6 @@
 package tectech.thing.metaTileEntity.multi.base;
 
+import java.util.Arrays;
 import java.util.function.Supplier;
 
 import net.minecraft.util.EnumChatFormatting;
@@ -41,9 +42,7 @@ public enum LedStatus {
 
     public static LedStatus[] makeArray(int count, LedStatus defaultValue) {
         LedStatus[] statuses = new LedStatus[count];
-        for (int i = 0; i < count; i++) {
-            statuses[i] = defaultValue;
-        }
+        Arrays.fill(statuses, defaultValue);
         return statuses;
     }
 
diff --git a/src/main/java/tectech/thing/metaTileEntity/multi/base/SoundLoopAnyBlock.java b/src/main/java/tectech/thing/metaTileEntity/multi/base/SoundLoopAnyBlock.java
index 15b08afb5c..d5a3642bf0 100644
--- a/src/main/java/tectech/thing/metaTileEntity/multi/base/SoundLoopAnyBlock.java
+++ b/src/main/java/tectech/thing/metaTileEntity/multi/base/SoundLoopAnyBlock.java
@@ -18,9 +18,9 @@ public class SoundLoopAnyBlock extends MovingSound {
     private final boolean stopWhenBlockInactive;
     private final int worldID;
     private boolean fadeOut = false;
-    private int tileX;
-    private int tileY;
-    private int tileZ;
+    private final int tileX;
+    private final int tileY;
+    private final int tileZ;
     private Block blockToTriggerEnd = null;
 
     /**
diff --git a/src/main/java/tectech/thing/metaTileEntity/multi/base/TTMultiblockBase.java b/src/main/java/tectech/thing/metaTileEntity/multi/base/TTMultiblockBase.java
index 8ee6eb3863..6251dcf1e8 100644
--- a/src/main/java/tectech/thing/metaTileEntity/multi/base/TTMultiblockBase.java
+++ b/src/main/java/tectech/thing/metaTileEntity/multi/base/TTMultiblockBase.java
@@ -1700,9 +1700,7 @@ public abstract class TTMultiblockBase extends MTEExtendedPowerMultiBlockBase<TT
 
     @Override
     public List<MTEHatch> getExoticEnergyHatches() {
-        List<MTEHatch> list = new ArrayList<>();
-        list.addAll(eEnergyMulti);
-        return list;
+        return new ArrayList<>(eEnergyMulti);
     }
 
     @Override
@@ -1858,10 +1856,6 @@ public abstract class TTMultiblockBase extends MTEExtendedPowerMultiBlockBase<TT
             return false;
         }
         IMetaTileEntity aMetaTileEntity = aTileEntity.getMetaTileEntity();
-        if (aMetaTileEntity == null) {
-            return false;
-        }
-
         return false;
     }
 
@@ -2006,10 +2000,6 @@ public abstract class TTMultiblockBase extends MTEExtendedPowerMultiBlockBase<TT
             return false;
         }
         IMetaTileEntity aMetaTileEntity = aTileEntity.getMetaTileEntity();
-        if (aMetaTileEntity == null) {
-            return false;
-        }
-
         return false;
     }
 
@@ -2019,10 +2009,6 @@ public abstract class TTMultiblockBase extends MTEExtendedPowerMultiBlockBase<TT
             return false;
         }
         IMetaTileEntity aMetaTileEntity = aTileEntity.getMetaTileEntity();
-        if (aMetaTileEntity == null) {
-            return false;
-        }
-
         return false;
     }
 
@@ -2611,7 +2597,6 @@ public abstract class TTMultiblockBase extends MTEExtendedPowerMultiBlockBase<TT
                         break;
                 }
                 setBackground(texture);
-                super.draw(partialTicks);
                 GL11.glColor4f(1f, 1f, 1f, 1f);
             }
         }.setOnClick((clickData, widget) -> {
-- 
cgit