From 4a12b1eb580217385c46d7665c47d9e143d62bae Mon Sep 17 00:00:00 2001 From: Léa Gris Date: Sat, 13 Jan 2024 00:37:08 +0100 Subject: Late review of #2446 Optional changes (#2449) --- .../java/gregtech/api/metatileentity/CoverableTileEntity.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/main/java/gregtech/api/metatileentity/CoverableTileEntity.java b/src/main/java/gregtech/api/metatileentity/CoverableTileEntity.java index 6adf7d2f1d..277b79c777 100644 --- a/src/main/java/gregtech/api/metatileentity/CoverableTileEntity.java +++ b/src/main/java/gregtech/api/metatileentity/CoverableTileEntity.java @@ -186,10 +186,9 @@ public abstract class CoverableTileEntity extends BaseTileEntity implements ICov byte validCoversMask = this.validCoversMask; if (validCoversMask == 0) return true; - ForgeDirection[] validDirections = ForgeDirection.VALID_DIRECTIONS; for (int i = Integer.numberOfTrailingZeros(validCoversMask); i < 6; i++) { if (((validCoversMask >>> i) & 1) == 0) continue; - if (!tickCoverAtSide(validDirections[i])) return false; + if (!tickCoverAtSide(ForgeDirection.VALID_DIRECTIONS[i])) return false; } return true; @@ -360,9 +359,8 @@ public abstract class CoverableTileEntity extends BaseTileEntity implements ICov if (side != ForgeDirection.UNKNOWN) { coverInfos[side.ordinal()] = coverInfo; - byte sideMask = (byte) (1 << side.ordinal()); - validCoversMask &= (byte) ~sideMask; - if (coverInfo.isValid()) validCoversMask |= sideMask; + validCoversMask &= (byte) ~side.flag; + if (coverInfo.isValid()) validCoversMask |= side.flag; } } -- cgit