diff options
| author | Walker Selby <git@walkerselby.com> | 2023-01-01 10:41:51 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-01 19:41:51 +0100 |
| commit | adc3222fae3dc66c56ccede50c62ff741929be16 (patch) | |
| tree | 8dff352e8b6cc925b8ecf54d834fa70eabab640e /CONTRIBUTING.md | |
| parent | f05b6fdfd1b699d84fb04018b707d1485052f718 (diff) | |
| download | NotEnoughUpdates-adc3222fae3dc66c56ccede50c62ff741929be16.tar.gz NotEnoughUpdates-adc3222fae3dc66c56ccede50c62ff741929be16.tar.bz2 NotEnoughUpdates-adc3222fae3dc66c56ccede50c62ff741929be16.zip | |
Some PV Cleanup (#520)
* Remove Unused Import "org.luaj.vm2.ast.Str"
Add final keyword in various places, creating slight performance increases
* Refactoring, Error Prevention, and Duplicate Code Simplification
Rename "stats" declared in line 1723 to "playerStats" to avoid hiding the "stats" field declared at line 648.
Rename "passiveStats" declared in line 1723 to "passivePlayerStats" to avoid hiding the "passiveStats" field declared at line 649.
Rename "networth" declared in line 939 to "playerNetworth" to avoid hiding the "networth" field declared at line 650.
Rename "networth" declared in line 910 to "soopyNetworthData" to avoid hiding the "networth" field declared at line 650.
soopyNetworthData
Change if check to "isEmpty" rather than size() > 0
Add function getAuctionPriceHelper to increase readability and decrease duplicate code
Replaced null with Empty Collections in some cases, to make caller logic simpler
Remove commented code for Catacombs in skilltoSkillDesiplayMap
Merge if statementes with their enclosing if statements, as they were unnecessarily nested.
* Redefine petRarityToNumMap and skillToSkillDisplayMap as ImmutableMaps rather than HashMap and LinkedHashMap respectively due to their immutable nature.
* Fix typo in SkyCrypt capilization
Add final to some variables for improved performance.
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions