aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
Diffstat (limited to 'tests')
-rw-r--r--tests/DummyResourceAPI.h2
-rw-r--r--tests/FileSystem_test.cpp8
-rw-r--r--tests/GZip_test.cpp2
-rw-r--r--tests/ResourceModel_test.cpp10
-rw-r--r--tests/Task_test.cpp4
5 files changed, 13 insertions, 13 deletions
diff --git a/tests/DummyResourceAPI.h b/tests/DummyResourceAPI.h
index 0cc90958..35de9515 100644
--- a/tests/DummyResourceAPI.h
+++ b/tests/DummyResourceAPI.h
@@ -32,7 +32,7 @@ class DummyResourceAPI : public ResourceAPI {
}
DummyResourceAPI() : ResourceAPI() {}
- [[nodiscard]] auto getSortingMethods() const -> QList<SortingMethod> override { return {}; };
+ [[nodiscard]] auto getSortingMethods() const -> QList<SortingMethod> override { return {}; }
[[nodiscard]] Task::Ptr searchProjects(SearchArgs&&, SearchCallbacks&& callbacks) const override
{
diff --git a/tests/FileSystem_test.cpp b/tests/FileSystem_test.cpp
index ec1f0bcf..49397e07 100644
--- a/tests/FileSystem_test.cpp
+++ b/tests/FileSystem_test.cpp
@@ -91,10 +91,10 @@ class LinkTask : public Task {
emitSucceeded();
}
- };
+ }
FS::create_link *m_lnk;
- bool m_useHard = false;
+ [[maybe_unused]] bool m_useHard = false;
bool m_linkRecursive = true;
};
@@ -346,7 +346,7 @@ slots:
void test_link()
{
QString folder = QFINDTESTDATA("testdata/FileSystem/test_folder");
- auto f = [&folder, this]()
+ auto f = [&folder]()
{
QTemporaryDir tempDir;
tempDir.setAutoRemove(true);
@@ -640,7 +640,7 @@ slots:
void test_link_with_max_depth()
{
QString folder = QFINDTESTDATA("testdata/FileSystem/test_folder");
- auto f = [&folder, this]()
+ auto f = [&folder]()
{
QTemporaryDir tempDir;
tempDir.setAutoRemove(true);
diff --git a/tests/GZip_test.cpp b/tests/GZip_test.cpp
index 82503d81..ccaa3610 100644
--- a/tests/GZip_test.cpp
+++ b/tests/GZip_test.cpp
@@ -29,7 +29,7 @@ slots:
// initialize random buffer
for(int i = 0; i < size; i++)
{
- random.append((char)idis(eng));
+ random.append(static_cast<char>(idis(eng)));
}
// initialize fibonacci
diff --git a/tests/ResourceModel_test.cpp b/tests/ResourceModel_test.cpp
index c0d9cd95..ecaea524 100644
--- a/tests/ResourceModel_test.cpp
+++ b/tests/ResourceModel_test.cpp
@@ -39,17 +39,17 @@ class DummyResourceModel : public ResourceModel {
public:
DummyResourceModel() : ResourceModel(new DummyResourceAPI) {}
- [[nodiscard]] auto metaEntryBase() const -> QString override { return ""; };
+ [[nodiscard]] auto metaEntryBase() const -> QString override { return ""; }
- ResourceAPI::SearchArgs createSearchArguments() override { return {}; };
- ResourceAPI::VersionSearchArgs createVersionsArguments(QModelIndex&) override { return {}; };
- ResourceAPI::ProjectInfoArgs createInfoArguments(QModelIndex&) override { return {}; };
+ ResourceAPI::SearchArgs createSearchArguments() override { return {}; }
+ ResourceAPI::VersionSearchArgs createVersionsArguments(QModelIndex&) override { return {}; }
+ ResourceAPI::ProjectInfoArgs createInfoArguments(QModelIndex&) override { return {}; }
QJsonArray documentToArray(QJsonDocument& doc) const override { return doc.object().value("hits").toArray(); }
void loadIndexedPack(ModPlatform::IndexedPack& pack, QJsonObject& obj) override
{
- pack.authors.append({ Json::requireString(obj, "author") });
+ pack.authors.append({ Json::requireString(obj, "author"), "" });
pack.description = Json::requireString(obj, "description");
pack.addonId = Json::requireString(obj, "project_id");
}
diff --git a/tests/Task_test.cpp b/tests/Task_test.cpp
index dabe5da2..04f2abcc 100644
--- a/tests/Task_test.cpp
+++ b/tests/Task_test.cpp
@@ -22,7 +22,7 @@ class BasicTask : public Task {
void executeTask() override
{
emitSucceeded();
- };
+ }
};
/* Does nothing. Only used for testing. */
@@ -34,7 +34,7 @@ class BasicTask_MultiStep : public Task {
private:
auto isMultiStep() const -> bool override { return true; }
- void executeTask() override {};
+ void executeTask() override {}
};
class BigConcurrentTask : public ConcurrentTask {