aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-01-25refactor: make shared_qobject_ptr ctor explicitflow
This turns issues like creating two shared ptrs from a single raw ptr from popping up at runtime, instead making them a compile error. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-25Merge pull request #784 from flowln/fix_resource_folder_double_smart_ptrsSefa Eyeoglu
2023-01-25Merge pull request #458 from Scrumplex/remove-updaterSefa Eyeoglu
2023-01-24fix(Tasks): don't try to start more tasks than necessaryflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-24fix(ResourceFolder): don't create two smart ptrs for the same raw ptrflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-24Merge pull request #781 from Ryex/patch-1flow
2023-01-24Update launcher/Application.cppRachel Powers
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-01-24Merge pull request #783 from DioEgizio/update-cmark-fix-cveflow
2023-01-24fix: update cmark to fix a CVEDioEgizio
Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
2023-01-24Merge branch 'develop' into remove-updaterSefa Eyeoglu
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
2023-01-24remove NDEBUG check per Scrumplex's ordersRachel Powers
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-01-23fix: let jars be found from inside build dir for debug buildsRachel Powers
debug bug builds run form inside the build dir before they are bundled can't find the jars Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-01-23Merge pull request #675 from flowln/generalize_mod_modelSefa Eyeoglu
2023-01-23Merge pull request #758 from flowln/fix_process_events_backstabSefa Eyeoglu
2023-01-23fix(license): add/fix my copyright/license headersflow
*sobbing in messy legal stuff i know nothing about* Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-23Merge pull request #772 from TheLastRar/zlib-fallback-bundled-fixSefa Eyeoglu
Fix: zlib fallback not working
2023-01-22fix: zlib fallbackTheLastRar
Signed-off-by: TheLastRar <TheLastRar@users.noreply.github.com>
2023-01-20Merge pull request #766 from TayouVR/change-cat-on-settings-changeflow
closes https://github.com/PrismLauncher/PrismLauncher/issues/763
2023-01-20fix(tests): add some comments on the stack overflow Task testflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-20make MainWindow cat update instantlyTayou
Signed-off-by: Tayou <tayou@gmx.net>
2023-01-18fix: call processEvents() before adding new tasks to the task queueflow
This allows the ongoing task to go off the stack before the next one is started. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-18feat(tests): add test for stack overflow in ConcurrentTaskflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-16Merge pull request #696 from Ryex/import-all-the-thingsSefa Eyeoglu
Fixes https://github.com/PrismLauncher/PrismLauncher/issues/581 Fixes https://github.com/PrismLauncher/PrismLauncher/issues/700
2023-01-15Merge pull request #753 from ↵flow
PrismLauncher/renovate/hendrikmuhs-ccache-action-1.x
2023-01-15chore(deps): update hendrikmuhs/ccache-action action to v1.2.8renovate[bot]
2023-01-14Merge pull request #746 from RaptaG/patch-1Sefa Eyeoglu
2023-01-14We're in 2023 :)RaptaG
Signed-off-by: RaptaG <77157639+RaptaG@users.noreply.github.com>
2023-01-14Merge pull request #743 from flowln/fix_mods_with_wrong_modListVersionflow
2023-01-13fix: don't fail mod parsing when encountering invalid modListVersionflow
The spec (admitely a very old one) states that this entry should always have the value "2". However, some mods do not follow this convention, causing issues. One notable example is the 1.6 version of Aether II for 1.7.10, that has this value set at "5" for whatever reason. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13Merge pull request #685 from byteduck/instance-accountsflow
2023-01-13Apply suggestions from code reviewRachel Powers
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-01-13fix(ModUpdater): ensure instead of require icon_urlflow
The spec says that this can be null, and indeed some mods have it set to null, and should still be considered as valid. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(ModUpdater): fail mods individually when there's errors in the JSONflow
Prevents a single problematic mod from invalidating all the API response. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): allow setting custom folder target for downloaded resourcesflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(RD): set resource strings for ReviewMessageBox tooflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13feat(tests): add very basic ResourceModel testflow
______very_____ basic indeed, creating tests is super boring :c Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(RD): don't assert search offset on fetchMore() in ResourceModelflow
This allows the standard QAbstractItemModelTester to work without shenanigans! Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor: change some ResourceAPI from NetJob to Taskflow
This makes it easier to create resource apis that aren't network-based. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): move BaseInstance dep. to subclasses of ResourceModelflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(RD): correctly set the strings for the specific resource namesflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix: CodeQL warnings about the rule of twoflow
shush Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): move success callbacks from ModModel to ResourceModelflow
While implementing the resource pack downloader in another branch, I noticed that most of the code in the success callback was identical in both cases, safe for a few minute differences in strings. So, this tries to make it easier to share this piece of code. However, it still leaves the possibility of extending the methods in ResourceModel to accomodate for cases where this similarity may not hold. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): add helper in ResourceModel to find current sortingflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(RD): separate search and versions/info tasksflow
This allows us to check whether a search request is already on-going, in which case we don't need to make another one (and shouldn't). Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(RD): pass copy of IndexedPack to callbacks instead of ref.flow
This prevents a crash in which the pack list gets updated in a search request meanwhile a versions / extra info request is being processed. Previously, this situation would cause the reference in the latter callbacks to be invalidated by an internal relocation of the pack list. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): clear up sorting methodsflow
This refactors the sorting methods to join every bit of it into a single list, easing maintanance. It also removes the weird index contraint on the list of methods by adding an index field to the DS that holds the method. Lastly, it puts the available methods on their respective API, so other resources on the same API can re-use them later on. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix: build with qt5.12 on Linux and pedantic flagflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13feat(RD): add roleNames and Q_PROPERTY to ResourceModelflow
in preparation for QML interop. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): decouple ResourceModels from ResourcePagesflow
This makes it so that we don't need a reference to the parent page in the model. It will be useful once we change the page from a widget-based one to a QML page. It also makes tasks be created in the dialog instead of the page, so that the dialog can also have the necessary information to mark versions as selected / deselected easily. It also makes the task pointers into smart pointers. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): unify download dialogs into a single fileflow
No need for multiple files since the subclasses are so small now Signed-off-by: flow <flowlnlnln@gmail.com>