aboutsummaryrefslogtreecommitdiff
path: root/launcher/InstanceCreationTask.cpp
AgeCommit message (Collapse)Author
2022-12-01fix(Inst.Import): Show error reason in fail dialogflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2022-09-20refactor: setAbortStatus -> setAbortableflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2022-09-20fix: move file deletion to the end of the instance updateflow
This makes it harder for problems in the updating process to affect the current instance. Network issues, for instance, will no longer put the instance in an invalid state. Still, a possible improvement to this would be passing that logic to InstanceStaging instead, to be handled with the instance commiting directly. However, as it is now, the code would become very spaguetti-y, and given that the override operation in the commiting could also put the instance into an invalid state, it seems to me that, in order to fully error-proof this, we would need to do a copy operation on the whole instance, in order to modify the copy, and only in the end override everything an once with a rename. That also has the possibility of corrupting the instance if done without super care, however, so I think we may need to instead create an automatic backup system, with an undo command of sorts, or something like that. This doesn't seem very trivial though, so it'll probably need to wait until another PR. In the meantime, the user is advised to always backup their instances before doing this kind of action, as always. What a long commit message o.O Signed-off-by: flow <flowlnlnln@gmail.com>
2022-09-20fix: some abort-related issuesflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2022-09-20feat(ui): improve info dialog before updating an instanceflow
Adds a 'Cancel' option, and add a note about doing a backup before updating. Signed-off-by: flow <flowlnlnln@gmail.com>
2022-09-20fix: hook up setAbortStatus in instance import tasksflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2022-09-20refactor: add instance creation abstraction and move vanillaflow
This is so that 1. Code is more cleanly separated, and 2. Allows to more easily add instance updating :) Signed-off-by: flow <flowlnlnln@gmail.com>
2022-04-18fix: don't set mod loader as importantSefa Eyeoglu
2022-04-15Add option to install mod loader during instance creationKenneth Chew
2022-02-21refactor: set default InstanceType to OneSixSefa Eyeoglu
2021-07-25NOISSUE Flatten gui and logic libraries into MultiMCPetr Mrázek