Age | Commit message (Collapse) | Author |
|
Makes it clearer what is being changed when.
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
This makes it so that the later call to parse the old manifest doesn't
change the class data, so that the new data con continue there and be
reflected on the component list later.
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
This prevents the Managed Pack page from showing up even though there's
no way for it to work correctly.
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
Closes https://github.com/PrismLauncher/PrismLauncher/issues/180
Closes https://github.com/PrismLauncher/PrismLauncher/issues/170
|
|
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
Since the exact version string is only available in the manifest,
there's no easy way of getting it before commiting to the update, so
there's not much of a good way of showing the updated name in the UI,
and using the displayName is weird and gives some buggy behavior.
We may want to re-enable it in the future if we find a reliable way of
showing the correct info on the UI before starting the update.
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
Also carry on the original ID to avoid updating the wrong instance.
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
This allows us to pass to the creation instances their actual pack ID
and version ID, that in Flame's case, are only available before starting
to create an instance.
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
... so that we can avoid code duplication.
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
|
|
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
|
|
Fixes temporary memory leak!
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
|
|
Also remove non-used variable (rip).
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
move explanation text into dialog class and it's own label
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
Fixes https://github.com/PrismLauncher/PrismLauncher/issues/222
|
|
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
Fixes https://github.com/PrismLauncher/PrismLauncher/issues/226
|
|
Almost the same issue from toml++ :p
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
|
|
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
Clang-cl fails to select the correct function and instead errors
Signed-off-by: TheLastRar <TheLastRar@users.noreply.github.com>
|
|
MSVC uses a different search mechanism that ends up picking the mete Version.h
Signed-off-by: TheLastRar <TheLastRar@users.noreply.github.com>
|
|
This would cause ODR violations when those headers were included in
other places that also included stuff like "Version.h" (note the
"meta/Version.h"), which can cause problems, especially in LTO.
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
Now that #333 is merged and FS::copy works on non directory copyFile can be removed.
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
|
If a version on Modrinth has more than a single mod loader associated,
it means that it's possible we might get the wrong file for download,
since individual files don't really have this kind of metadata in the
API response.
So, in such cases, it's best to let the user take care of it instead.
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
|
|
This way, we don't get stuck with an aborted job in our way! :o
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
|
|
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
|
|
This matches the behaviour of ATLauncher.
|
|
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
i hate it
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
In particular, this changes the order so that the instance gets created
before downloading the mods (like other install tasks), and the mod download
directly puts the files in the staging folder (like the others), instead
of that weird makeCached and copy stuff.
This fixes some issues with modpack downloads from FTB, like creating an
instance with no mods in it.
Signed-off-by: flow <flowlnlnln@gmail.com>
|
|
|
|
Signed-off-by: timoreo <contact@timoreo.fr>
|
|
Signed-off-by: timoreo <contact@timoreo.fr>
|
|
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
|
|
This prevents custom names from being lost when updating, by only
changing the name if the old instance name constains the old version,
so that we can update it if the user whishes to.
Signed-off-by: flow <flowlnlnln@gmail.com>
|