aboutsummaryrefslogtreecommitdiff
path: root/launcher/ui/pages/instance
AgeCommit message (Collapse)Author
2023-06-20Screenshots: do not retry image thumbnailing on null resultJames Beddek
This causes the thumbnailing thread pool to spend a lot of time attempting to retry an image that failed. A null result is common where the image is too large to be allocated (>128MiB alloc). The repeated retries continue after page delete, causing hangs if a user tries to exit the application. Fixes: #1201 Signed-off-by: James Beddek <telans@posteo.de>
2023-06-20Screenshots: clear the thumbnailing pool on page deleteJames Beddek
Removes pending QThreadPool jobs which linger after page delete. May help with #1201 by allowing the pool to finish earlier. Signed-off-by: James Beddek <telans@posteo.de>
2023-06-20Screenshots: remove path from watcher if it no longer existsJames Beddek
Signed-off-by: James Beddek <telans@posteo.de>
2023-06-14Merge branch 'develop' into feat/dont-hide-settingsTheKodeToad
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
2023-06-06Merge pull request #1073 from leo78913/accounts-menus-fixesTayou
2023-05-28refactor: function scope staticsRachel Powers
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-05-28cleanup: move qstyle getInstance decl inlineRachel Powers
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-05-27fix(memory leak): refactor NoBigComboStyle -> singletonRachel Powers
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-05-25fix: katabasis and QStyle leaksRachel Powers
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-05-21fix: memory leak, set parent so it's in tree to get cleaned up.Rachel Powers
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-05-14make instance settings account selector a comboBoxleo78913
Signed-off-by: leo78913 <leo3758@riseup.net>
2023-05-13fix: `shouldDisplay()` is now redundant.Redson
Signed-off-by: Redson <redson@riseup.net>
2023-05-12Merge branch 'develop' into fix/network_and_signalsRachel Powers
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-05-10feat: Don't hide the settings tab when an instance is runningRedson
Signed-off-by: Redson <redson@riseup.net>
2023-04-17Fix: signal/slot macro -> func pointer & network fixesRachel Powers
- convert qt connect calls to use function pointers instead of the signal/slot macros wherever practical (UI classes were mostly left alone, target was tasks and processes) - give signals an explicit receivers to use the static method over the instance method wherever practical - ensure networks tasks are using the `errorOccured` signal added in Qt5.15 over the deprecated `error` signal - ensure all networks tasks have an sslErrors signal connected - add seemingly missing `MinecraftAccount::authSucceeded` connection for `MSAInteractive` login flow Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-03-20feat: warnings when instance resources are linkedRachel Powers
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-03-05Merge pull request #853 from kumquat-ir/nilSefa Eyeoglu
NilLoader mod metadata support
2023-03-02Merge pull request #788 from flowln/other_resource_downloaders_twoSefa Eyeoglu
Add resource pack, texture pack and shader pack downloaders
2023-03-02fix: change wording of TP/RP download buttonsSefa Eyeoglu
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
2023-03-01Merge pull request #735 from Scrumplex/import-componentSefa Eyeoglu
2023-02-13do not create nilmods folderkumquat-ir
"it cant be that easy" - me, clueless Signed-off-by: kumquat-ir <66188216+kumquat-ir@users.noreply.github.com>
2023-02-11nilmods instance pagekumquat-ir
mostly copied from the coremod page impl Signed-off-by: kumquat-ir <66188216+kumquat-ir@users.noreply.github.com>
2023-02-05chore: add my copyright headersflow
.-. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-02-05feat(RD): add texture pack downloaderflow
This extends the resource pack downloader, with the custom behavior of filtering the versions that shows up, to those <= 1.6. As always, Flame is funky and requires a bit more workarounds than average. This will also get a nice improvement when the Version parsing and comparison PR gets merged! :D Signed-off-by: flow <flowlnlnln@gmail.com>
2023-02-05feat(RD): add shader pack downloaderflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-02-05feat(RD): add resource pack downloaderflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-25refactor: make shared_qobject_ptr ctor explicitflow
This turns issues like creating two shared ptrs from a single raw ptr from popping up at runtime, instead making them a compile error. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-25refactor: add error handling to component importSefa Eyeoglu
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
2023-01-24Merge branch 'develop' into remove-updaterSefa Eyeoglu
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
2023-01-23Merge pull request #675 from flowln/generalize_mod_modelSefa Eyeoglu
2023-01-23fix(license): add/fix my copyright/license headersflow
*sobbing in messy legal stuff i know nothing about* Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-14chore: update license headersSefa Eyeoglu
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
2023-01-13Merge pull request #685 from byteduck/instance-accountsflow
2023-01-13refactor: change some ResourceAPI from NetJob to Taskflow
This makes it easier to create resource apis that aren't network-based. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): unify download dialogs into a single fileflow
No need for multiple files since the subclasses are so small now Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor: put resource downloading classes in common namespaceflow
Puts them all inside the 'ResourceDownload' namespace, so that it's a bit clearer from the outside that those belong to the same 'module'. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor: generalize mod models and APIs to resourcesflow
Firstly, this abstract away behavior in the mod download models that can also be applied to other types of resources into a superclass, allowing other resource types to be implemented without so much code duplication. For that, this also generalizes the APIs used (currently, ModrinthAPI and FlameAPI) to be able to make requests to other types of resources. It also does a general cleanup of both of those. In particular, this makes use of std::optional instead of invalid values for errors and, well, optional values :p This is a squash of some commits that were becoming too interlaced together to be cleanly separated. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-12Fix instance account selector face for offline accountsAaron
2023-01-12refactor: replace hoedown markdown parser with cmarkJoshua Goins
Signed-off-by: Joshua Goins <josh@redstrate.com>
2023-01-11feat: add button to import component JSONsSefa Eyeoglu
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
2023-01-02Reword instance-specific account settings, apply clang-formatAaron
Signed-off-by: Aaron <10217842+byteduck@users.noreply.github.com>
2023-01-02Remove unecessary delete in InstanceSettingsPage destructorAaron Sonin
Co-authored-by: flow <flowlnlnln@gmail.com> Signed-off-by: Aaron Sonin <10217842+byteduck@users.noreply.github.com> Signed-off-by: Aaron <10217842+byteduck@users.noreply.github.com>
2023-01-02Properly connect signal in instance settings for account selectorAaron Sonin
Co-authored-by: flow <flowlnlnln@gmail.com> Signed-off-by: Aaron Sonin <10217842+byteduck@users.noreply.github.com> Signed-off-by: Aaron <10217842+byteduck@users.noreply.github.com>
2023-01-02Add null check for face in instance account settings selectorAaron Sonin
Co-authored-by: flow <flowlnlnln@gmail.com> Signed-off-by: Aaron Sonin <10217842+byteduck@users.noreply.github.com> Signed-off-by: Aaron <10217842+byteduck@users.noreply.github.com>
2023-01-02Replace unecessary type check with assertion in InstanceSettingsPageAaron Sonin
Co-authored-by: flow <flowlnlnln@gmail.com> Signed-off-by: Aaron Sonin <10217842+byteduck@users.noreply.github.com> Signed-off-by: Aaron <10217842+byteduck@users.noreply.github.com>
2023-01-02Fix conflicting layout name in InstanceSettingsPageAaron
Signed-off-by: Aaron <10217842+byteduck@users.noreply.github.com>
2023-01-02Allow selecting a default account to use with an instanceAaron
Signed-off-by: Aaron <10217842+byteduck@users.noreply.github.com>
2022-12-26Merge pull request #618 from TheKodeToad/safer-destructive-actionsSefa Eyeoglu
Fixes https://github.com/PolyMC/PolyMC/issues/948
2022-12-26Use optional instead of hardcoded cancelled stringTheKodeToad
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
2022-12-26About to -> you are about toTheKodeToad
You're is used in some other places but im lazy Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
generated by cgit (git 2.46.0) at 2025-02-03 22:06:47 +0000