aboutsummaryrefslogtreecommitdiff
path: root/launcher
AgeCommit message (Collapse)Author
2023-01-19Version.h: Fix comparison of null version in Version classEdgars Cīrulis
Co-authored-by: Rachel Powers <508861+Ryex@users.noreply.github.com> Signed-off-by: Edgars Cīrulis <edgarsscirulis@gmail.com>
2023-01-19fix: proper null padded version comparisonRachel Powers
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-01-19feat: add debug printing for VersionRachel Powers
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-01-18fix: call processEvents() before adding new tasks to the task queueflow
This allows the ongoing task to go off the stack before the next one is started. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-17Version.cpp: Remove unnecessary QStringList includeEdgars Cīrulis
Signed-off-by: Edgars Cīrulis <edgarsscirulis@gmail.com>
2023-01-17Version.cpp: Decompose version strings according to flexverEdgars Cīrulis
Co-authored-by: Rachel Powers <508861+Ryex@users.noreply.github.com> Signed-off-by: Edgars Cīrulis <edgarsscirulis@gmail.com>
2023-01-17Version.cpp: Format parse function code using clang-formatEdgars Cīrulis
Signed-off-by: Edgars Cīrulis <edgarsscirulis@gmail.com>
2023-01-17Version.cpp: Simplify Version::parse by using const auto& current_charEdgars Cīrulis
Signed-off-by: Edgars Cīrulis <edgarsscirulis@gmail.com>
2023-01-17Version.cpp: Use anonymous function to eliminate code duplicationEdgars Cīrulis
Signed-off-by: Edgars Cīrulis <edgarsscirulis@gmail.com>
2023-01-17Version.cpp: Add version string parser to split on '.' characterEdgars Cīrulis
Signed-off-by: Edgars Cīrulis <edgarsscirulis@gmail.com>
2023-01-17Version.cpp: Improve version parsing to handle mixed numeric and alphabetic ↵Edgars Cīrulis
characters Signed-off-by: Edgars Cīrulis <edgarsscirulis@gmail.com>
2023-01-16Merge pull request #696 from Ryex/import-all-the-thingsSefa Eyeoglu
Fixes https://github.com/PrismLauncher/PrismLauncher/issues/581 Fixes https://github.com/PrismLauncher/PrismLauncher/issues/700
2023-01-14Merge pull request #743 from flowln/fix_mods_with_wrong_modListVersionflow
2023-01-13fix: don't fail mod parsing when encountering invalid modListVersionflow
The spec (admitely a very old one) states that this entry should always have the value "2". However, some mods do not follow this convention, causing issues. One notable example is the 1.6 version of Aether II for 1.7.10, that has this value set at "5" for whatever reason. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13Merge pull request #685 from byteduck/instance-accountsflow
2023-01-13Apply suggestions from code reviewRachel Powers
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-01-13fix(ModUpdater): ensure instead of require icon_urlflow
The spec says that this can be null, and indeed some mods have it set to null, and should still be considered as valid. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(ModUpdater): fail mods individually when there's errors in the JSONflow
Prevents a single problematic mod from invalidating all the API response. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): allow setting custom folder target for downloaded resourcesflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(RD): set resource strings for ReviewMessageBox tooflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(RD): don't assert search offset on fetchMore() in ResourceModelflow
This allows the standard QAbstractItemModelTester to work without shenanigans! Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor: change some ResourceAPI from NetJob to Taskflow
This makes it easier to create resource apis that aren't network-based. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): move BaseInstance dep. to subclasses of ResourceModelflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(RD): correctly set the strings for the specific resource namesflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix: CodeQL warnings about the rule of twoflow
shush Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): move success callbacks from ModModel to ResourceModelflow
While implementing the resource pack downloader in another branch, I noticed that most of the code in the success callback was identical in both cases, safe for a few minute differences in strings. So, this tries to make it easier to share this piece of code. However, it still leaves the possibility of extending the methods in ResourceModel to accomodate for cases where this similarity may not hold. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): add helper in ResourceModel to find current sortingflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(RD): separate search and versions/info tasksflow
This allows us to check whether a search request is already on-going, in which case we don't need to make another one (and shouldn't). Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(RD): pass copy of IndexedPack to callbacks instead of ref.flow
This prevents a crash in which the pack list gets updated in a search request meanwhile a versions / extra info request is being processed. Previously, this situation would cause the reference in the latter callbacks to be invalidated by an internal relocation of the pack list. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): clear up sorting methodsflow
This refactors the sorting methods to join every bit of it into a single list, easing maintanance. It also removes the weird index contraint on the list of methods by adding an index field to the DS that holds the method. Lastly, it puts the available methods on their respective API, so other resources on the same API can re-use them later on. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix: build with qt5.12 on Linux and pedantic flagflow
Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13feat(RD): add roleNames and Q_PROPERTY to ResourceModelflow
in preparation for QML interop. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): decouple ResourceModels from ResourcePagesflow
This makes it so that we don't need a reference to the parent page in the model. It will be useful once we change the page from a widget-based one to a QML page. It also makes tasks be created in the dialog instead of the page, so that the dialog can also have the necessary information to mark versions as selected / deselected easily. It also makes the task pointers into smart pointers. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor(RD): unify download dialogs into a single fileflow
No need for multiple files since the subclasses are so small now Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13fix(RD): prevent weird behavior of progress widgetflow
when i.e. clicking on links or just using the downloader at all, this prevents some flickering and the widget never getting hidden in some cases. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor: put resource downloading classes in common namespaceflow
Puts them all inside the 'ResourceDownload' namespace, so that it's a bit clearer from the outside that those belong to the same 'module'. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13refactor: generalize mod models and APIs to resourcesflow
Firstly, this abstract away behavior in the mod download models that can also be applied to other types of resources into a superclass, allowing other resource types to be implemented without so much code duplication. For that, this also generalizes the APIs used (currently, ModrinthAPI and FlameAPI) to be able to make requests to other types of resources. It also does a general cleanup of both of those. In particular, this makes use of std::optional instead of invalid values for errors and, well, optional values :p This is a squash of some commits that were becoming too interlaced together to be cleanly separated. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-13Merge pull request #714 from redstrate/cmarkflow
2023-01-12Merge branch 'PrismLauncher:develop' into instance-accountsAaron Sonin
2023-01-12Fix instance account selector face for offline accountsAaron
2023-01-12fix: Remove extra line breaks for modrinth descriptionsJoshua Goins
Signed-off-by: Joshua Goins <josh@redstrate.com>
2023-01-12refactor: support system and bundled cmarkSefa Eyeoglu
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
2023-01-12refactor: replace hoedown markdown parser with cmarkJoshua Goins
Signed-off-by: Joshua Goins <josh@redstrate.com>
2023-01-11Merge pull request #731 from flowln/windows_server_trashSefa Eyeoglu
2023-01-10fix(FileSystem): don't attempt to trash items on Windows Serverflow
For some reason this makes some of our CI test runs super slow, and sometimes fail miserably. Signed-off-by: flow <flowlnlnln@gmail.com>
2023-01-10Add hint about CatTayou
Signed-off-by: Tayou <tayou@gmx.net>
2023-01-10fix: set minimum size for setup wizardSefa Eyeoglu
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
2023-01-10CRLF -> LFTayou
damn you visual studio for creating CRLF files everywhere... Signed-off-by: Tayou <tayou@gmx.net>
2023-01-10Update launcher/Application.cpp with suggestion from scrumplexTayou
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by: Tayou <tayou@gmx.net>
2023-01-10Implement Suggestions from flow & ScrumplexTayou
Signed-off-by: Tayou <tayou@gmx.net>
generated by cgit (git 2.46.0) at 2025-02-03 17:11:41 +0000