From 70ed30f9e6b47fbfb3151078ca61a2bb419feccb Mon Sep 17 00:00:00 2001 From: Petr Mrázek Date: Sun, 7 Apr 2019 23:59:04 +0200 Subject: GH-2591 less std::shared_ptr and more shared_qobject_ptr This eliminates some weird crashes. --- api/logic/launch/LaunchTask.cpp | 8 ++++---- api/logic/launch/LaunchTask.h | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'api/logic/launch') diff --git a/api/logic/launch/LaunchTask.cpp b/api/logic/launch/LaunchTask.cpp index d39a9208..841b8363 100644 --- a/api/logic/launch/LaunchTask.cpp +++ b/api/logic/launch/LaunchTask.cpp @@ -33,9 +33,9 @@ void LaunchTask::init() m_instance->setRunning(true); } -std::shared_ptr LaunchTask::create(InstancePtr inst) +shared_qobject_ptr LaunchTask::create(InstancePtr inst) { - std::shared_ptr proc(new LaunchTask(inst)); + shared_qobject_ptr proc(new LaunchTask(inst)); proc->init(); return proc; } @@ -44,12 +44,12 @@ LaunchTask::LaunchTask(InstancePtr instance): m_instance(instance) { } -void LaunchTask::appendStep(std::shared_ptr step) +void LaunchTask::appendStep(shared_qobject_ptr step) { m_steps.append(step); } -void LaunchTask::prependStep(std::shared_ptr step) +void LaunchTask::prependStep(shared_qobject_ptr step) { m_steps.prepend(step); } diff --git a/api/logic/launch/LaunchTask.h b/api/logic/launch/LaunchTask.h index 4f6efe0a..ee04bd9a 100644 --- a/api/logic/launch/LaunchTask.h +++ b/api/logic/launch/LaunchTask.h @@ -45,11 +45,11 @@ public: }; public: /* methods */ - static std::shared_ptr create(InstancePtr inst); + static shared_qobject_ptr create(InstancePtr inst); virtual ~LaunchTask() {}; - void appendStep(std::shared_ptr step); - void prependStep(std::shared_ptr step); + void appendStep(shared_qobject_ptr step); + void prependStep(shared_qobject_ptr step); void setCensorFilter(QMap filter); InstancePtr instance() @@ -117,7 +117,7 @@ private: /*methods */ protected: /* data */ InstancePtr m_instance; shared_qobject_ptr m_logModel; - QList > m_steps; + QList > m_steps; QMap m_censorFilter; int currentStep = -1; State state = NotStarted; -- cgit