From 458c2f38bc8e560832ca09b846edaa9ddc64f58d Mon Sep 17 00:00:00 2001
From: Rachel Powers <508861+Ryex@users.noreply.github.com>
Date: Fri, 3 Mar 2023 06:33:37 -0700
Subject: cleanup: code review sugestions

clean up translation strings

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
---
 launcher/minecraft/WorldList.cpp                   | 6 +++---
 launcher/minecraft/mod/ModFolderModel.cpp          | 7 ++++---
 launcher/minecraft/mod/ResourceFolderModel.cpp     | 7 ++++---
 launcher/minecraft/mod/ResourcePackFolderModel.cpp | 7 ++++---
 4 files changed, 15 insertions(+), 12 deletions(-)

(limited to 'launcher/minecraft')

diff --git a/launcher/minecraft/WorldList.cpp b/launcher/minecraft/WorldList.cpp
index 43733110..3681bcda 100644
--- a/launcher/minecraft/WorldList.cpp
+++ b/launcher/minecraft/WorldList.cpp
@@ -237,11 +237,11 @@ QVariant WorldList::data(const QModelIndex &index, int role) const
     {   
         if (column == InfoColumn) {
             if (world.isSymLinkUnder(instDirPath())) {
-                return tr("Warning: This world is symbolically linked from elsewhere. Editing it will also change the original") +
-                       tr("\nCanonical Path: %1").arg(world.canonicalFilePath());
+                return tr("Warning: This world is symbolically linked from elsewhere. Editing it will also change the original." 
+                          "\nCanonical Path: %1").arg(world.canonicalFilePath());
             }
             if (world.isMoreThanOneHardLink()) {
-                return tr("Warning: This world is hard linked elsewhere. Editing it will also change the original");
+                return tr("Warning: This world is hard linked elsewhere. Editing it will also change the original.");
             }
         }
         return world.folderName();
diff --git a/launcher/minecraft/mod/ModFolderModel.cpp b/launcher/minecraft/mod/ModFolderModel.cpp
index 943f30ad..91d16175 100644
--- a/launcher/minecraft/mod/ModFolderModel.cpp
+++ b/launcher/minecraft/mod/ModFolderModel.cpp
@@ -104,12 +104,13 @@ QVariant ModFolderModel::data(const QModelIndex &index, int role) const
         if (column == NAME_COLUMN) {
             if (at(row)->isSymLinkUnder(instDirPath())) {
                 return m_resources[row]->internal_id() +
-                    tr("\nWarning: This resource is symbolically linked from elsewhere. Editing it will also change the original") +
-                    tr("\nCanonical Path: %1").arg(at(row)->fileinfo().canonicalFilePath());
+                    tr("\nWarning: This resource is symbolically linked from elsewhere. Editing it will also change the original." 
+                       "\nCanonical Path: %1")
+                        .arg(at(row)->fileinfo().canonicalFilePath());
             }
             if (at(row)->isMoreThanOneHardLink()) {
                 return m_resources[row]->internal_id() +
-                    tr("\nWarning: This resource is hard linked elsewhere. Editing it will also change the original");
+                    tr("\nWarning: This resource is hard linked elsewhere. Editing it will also change the original.");
             }
         }
         return m_resources[row]->internal_id();
diff --git a/launcher/minecraft/mod/ResourceFolderModel.cpp b/launcher/minecraft/mod/ResourceFolderModel.cpp
index 95b7651f..29a0c736 100644
--- a/launcher/minecraft/mod/ResourceFolderModel.cpp
+++ b/launcher/minecraft/mod/ResourceFolderModel.cpp
@@ -424,12 +424,13 @@ QVariant ResourceFolderModel::data(const QModelIndex& index, int role) const
             if (column == NAME_COLUMN) {
                 if (at(row).isSymLinkUnder(instDirPath())) {
                     return m_resources[row]->internal_id() +
-                        tr("\nWarning: This resource is symbolically linked from elsewhere. Editing it will also change the original") +
-                        tr("\nCanonical Path: %1").arg(at(row).fileinfo().canonicalFilePath());;
+                        tr("\nWarning: This resource is symbolically linked from elsewhere. Editing it will also change the original."
+                           "\nCanonical Path: %1")
+                            .arg(at(row).fileinfo().canonicalFilePath());;
                 }
                 if (at(row).isMoreThanOneHardLink()) {
                     return m_resources[row]->internal_id() +
-                        tr("\nWarning: This resource is hard linked elsewhere. Editing it will also change the original");
+                        tr("\nWarning: This resource is hard linked elsewhere. Editing it will also change the original.");
                 }
             }
             
diff --git a/launcher/minecraft/mod/ResourcePackFolderModel.cpp b/launcher/minecraft/mod/ResourcePackFolderModel.cpp
index 1fcfa909..0480d8ba 100644
--- a/launcher/minecraft/mod/ResourcePackFolderModel.cpp
+++ b/launcher/minecraft/mod/ResourcePackFolderModel.cpp
@@ -96,12 +96,13 @@ QVariant ResourcePackFolderModel::data(const QModelIndex& index, int role) const
             if (column == NAME_COLUMN) {
                 if (at(row)->isSymLinkUnder(instDirPath())) {
                     return m_resources[row]->internal_id() +
-                        tr("\nWarning: This resource is symbolically linked from elsewhere. Editing it will also change the original") +
-                        tr("\nCanonical Path: %1").arg(at(row)->fileinfo().canonicalFilePath());;
+                        tr("\nWarning: This resource is symbolically linked from elsewhere. Editing it will also change the original."
+                           "\nCanonical Path: %1")
+                            .arg(at(row)->fileinfo().canonicalFilePath());;
                 }
                 if (at(row)->isMoreThanOneHardLink()) {
                     return m_resources[row]->internal_id() +
-                        tr("\nWarning: This resource is hard linked elsewhere. Editing it will also change the original");
+                        tr("\nWarning: This resource is hard linked elsewhere. Editing it will also change the original.");
                 }
             }
             return m_resources[row]->internal_id();
-- 
cgit