From 38e20eb1486928e10f4d3c128f3e9a6c697d872a Mon Sep 17 00:00:00 2001
From: flow <flowlnlnln@gmail.com>
Date: Tue, 20 Dec 2022 16:27:15 -0300
Subject: fix(RD): pass copy of IndexedPack to callbacks instead of ref.

This prevents a crash in which the pack list gets updated in a search
request meanwhile a versions / extra info request is being processed.
Previously, this situation would cause the reference in the latter
callbacks to be invalidated by an internal relocation of the pack list.

Signed-off-by: flow <flowlnlnln@gmail.com>
---
 launcher/modplatform/ResourceAPI.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'launcher/modplatform')

diff --git a/launcher/modplatform/ResourceAPI.h b/launcher/modplatform/ResourceAPI.h
index a2078b94..5f4e1832 100644
--- a/launcher/modplatform/ResourceAPI.h
+++ b/launcher/modplatform/ResourceAPI.h
@@ -81,7 +81,7 @@ class ResourceAPI {
     };
 
     struct VersionSearchArgs {
-        ModPlatform::IndexedPack& pack;
+        ModPlatform::IndexedPack pack;
 
         std::optional<std::list<Version> > mcVersions;
         std::optional<ModLoaderTypes> loaders;
@@ -94,16 +94,16 @@ class ResourceAPI {
         }
     };
     struct VersionSearchCallbacks {
-        std::function<void(QJsonDocument&, ModPlatform::IndexedPack&)> on_succeed;
+        std::function<void(QJsonDocument&, ModPlatform::IndexedPack)> on_succeed;
     };
 
     struct ProjectInfoArgs {
-        ModPlatform::IndexedPack& pack;
+        ModPlatform::IndexedPack pack;
 
         void operator=(ProjectInfoArgs other) { pack = other.pack; }
     };
     struct ProjectInfoCallbacks {
-        std::function<void(QJsonDocument&, ModPlatform::IndexedPack&)> on_succeed;
+        std::function<void(QJsonDocument&, ModPlatform::IndexedPack)> on_succeed;
     };
 
    public:
-- 
cgit