From 96e36f060443cbfa6d58df2adca3c8605851b4a3 Mon Sep 17 00:00:00 2001
From: flow <thiagodonato300@gmail.com>
Date: Wed, 20 Apr 2022 18:45:39 -0300
Subject: refactor: make mod metadata presence (or lack of) easier to find out

---
 launcher/modplatform/ModIndex.cpp        | 2 ++
 launcher/modplatform/packwiz/Packwiz.cpp | 9 ++-------
 2 files changed, 4 insertions(+), 7 deletions(-)

(limited to 'launcher/modplatform')

diff --git a/launcher/modplatform/ModIndex.cpp b/launcher/modplatform/ModIndex.cpp
index eb8be992..b3c057fb 100644
--- a/launcher/modplatform/ModIndex.cpp
+++ b/launcher/modplatform/ModIndex.cpp
@@ -10,6 +10,7 @@ auto ProviderCapabilities::name(Provider p) -> const char*
     case Provider::FLAME:
         return "curseforge";
     }
+    return {};
 }
 auto ProviderCapabilities::hashType(Provider p) -> QString
 {
@@ -19,6 +20,7 @@ auto ProviderCapabilities::hashType(Provider p) -> QString
     case Provider::FLAME:
         return "murmur2";
     }
+    return {};
 }
 
 } // namespace ModPlatform
diff --git a/launcher/modplatform/packwiz/Packwiz.cpp b/launcher/modplatform/packwiz/Packwiz.cpp
index 872da9b1..50f87c24 100644
--- a/launcher/modplatform/packwiz/Packwiz.cpp
+++ b/launcher/modplatform/packwiz/Packwiz.cpp
@@ -48,14 +48,9 @@ auto V1::createModFormat(QDir& index_dir, ::Mod& internal_mod) -> Mod
     if(mod.isValid())
         return mod;
 
-    // Manually construct packwiz mod
-    mod.name = internal_mod.name();
-    mod.filename = internal_mod.fileinfo().fileName();
+    qWarning() << QString("Tried to create mod metadata with a Mod without metadata!");
 
-    // TODO: Have a mechanism for telling the UI subsystem that we want to gather user information
-    // (i.e. which mod provider we want to use). Maybe an object parameter with a signal for that?
-
-    return mod;
+    return {};
 }
 
 void V1::updateModIndex(QDir& index_dir, Mod& mod)
-- 
cgit