From 69213b1206e97f7d4db4270a4b3b0af41dc9e6fc Mon Sep 17 00:00:00 2001 From: Petr Mrázek Date: Sun, 21 Nov 2021 23:21:12 +0100 Subject: NOISSUE continue refactoring things to make tests pass --- launcher/screenshots/ImgurUpload.h | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) (limited to 'launcher/screenshots/ImgurUpload.h') diff --git a/launcher/screenshots/ImgurUpload.h b/launcher/screenshots/ImgurUpload.h index 0507d499..ac57d1ba 100644 --- a/launcher/screenshots/ImgurUpload.h +++ b/launcher/screenshots/ImgurUpload.h @@ -1,15 +1,15 @@ #pragma once +#include "QObjectPtr.h" #include "net/NetAction.h" #include "Screenshot.h" -typedef std::shared_ptr ImgurUploadPtr; -class ImgurUpload : public NetAction -{ +class ImgurUpload : public NetAction { public: - explicit ImgurUpload(ScreenshotPtr shot); - static ImgurUploadPtr make(ScreenshotPtr shot) - { - return ImgurUploadPtr(new ImgurUpload(shot)); + using Ptr = shared_qobject_ptr; + + explicit ImgurUpload(ScreenShot::Ptr shot); + static Ptr make(ScreenShot::Ptr shot) { + return Ptr(new ImgurUpload(shot)); } protected @@ -17,15 +17,13 @@ slots: virtual void downloadProgress(qint64 bytesReceived, qint64 bytesTotal); virtual void downloadError(QNetworkReply::NetworkError error); virtual void downloadFinished(); - virtual void downloadReadyRead() - { - } + virtual void downloadReadyRead() {} public slots: - virtual void start(); + void startImpl() override; private: - ScreenshotPtr m_shot; + ScreenShot::Ptr m_shot; bool finished = true; }; -- cgit