From d394235ee0040b061504ae50daaea10d3c80500c Mon Sep 17 00:00:00 2001
From: flow <thiagodonato300@gmail.com>
Date: Fri, 11 Mar 2022 18:03:21 -0300
Subject: refactor: Create a more clear hierarchy for some instance pages

Previously, the Shaders, Texture packs and Resource packs tabs had as
parent the ModFolderPage, making it so that making changes only to the
Mods page would require checking the id of the page for the correct one.
This was hackish and error-prone.

Now, those pages all inherit from a single class, ExternalResourcesPage,
that handles the basic behaviour of all of them, while allowing for
individual modification in code.

This is still not a clear separation, since internally, all those
resources are derived from Mods, so for now there's still some awkward
common code :/
---
 launcher/ui/pages/instance/ExternalResourcesPage.h | 73 ++++++++++++++++++++++
 1 file changed, 73 insertions(+)
 create mode 100644 launcher/ui/pages/instance/ExternalResourcesPage.h

(limited to 'launcher/ui/pages/instance/ExternalResourcesPage.h')

diff --git a/launcher/ui/pages/instance/ExternalResourcesPage.h b/launcher/ui/pages/instance/ExternalResourcesPage.h
new file mode 100644
index 00000000..41237139
--- /dev/null
+++ b/launcher/ui/pages/instance/ExternalResourcesPage.h
@@ -0,0 +1,73 @@
+#pragma once
+
+#include <QMainWindow>
+#include <QSortFilterProxyModel>
+
+#include "Application.h"
+#include "minecraft/MinecraftInstance.h"
+#include "ui/pages/BasePage.h"
+
+class ModFolderModel;
+
+namespace Ui {
+class ExternalResourcesPage;
+}
+
+/* This page is used as a base for pages in which the user can manage external resources
+ * related to the game, such as mods, shaders or resource packs. */
+class ExternalResourcesPage : public QMainWindow, public BasePage {
+    Q_OBJECT
+
+   public:
+    // FIXME: Switch to different model (or change the name of this one)
+    explicit ExternalResourcesPage(BaseInstance* instance, std::shared_ptr<ModFolderModel> model, QWidget* parent = nullptr);
+    virtual ~ExternalResourcesPage();
+
+    virtual QString displayName() const override = 0;
+    virtual QIcon icon() const override = 0;
+    virtual QString id() const override = 0;
+    virtual QString helpPage() const override = 0;
+
+    virtual bool shouldDisplay() const override = 0;
+
+    void openedImpl() override;
+    void closedImpl() override;
+
+    void retranslate() override;
+
+   protected:
+    bool eventFilter(QObject* obj, QEvent* ev) override;
+    bool listFilter(QKeyEvent* ev);
+    QMenu* createPopupMenu() override;
+
+   public slots:
+    void current(const QModelIndex& current, const QModelIndex& previous);
+
+   protected slots:
+    void itemActivated(const QModelIndex& index);
+    void filterTextChanged(const QString& newContents);
+    void runningStateChanged(bool running);
+
+    virtual void addItem();
+    virtual void removeItem();
+
+    virtual void enableItem();
+    virtual void disableItem();
+
+    virtual void viewFolder();
+    virtual void viewConfigs();
+
+    void ShowContextMenu(const QPoint& pos);
+
+   protected:
+    BaseInstance* m_instance = nullptr;
+
+    Ui::ExternalResourcesPage* ui = nullptr;
+    std::shared_ptr<ModFolderModel> m_model;
+    QSortFilterProxyModel* m_filterModel = nullptr;
+
+    QString m_fileSelectionFilter;
+    QString m_viewFilter;
+
+    bool m_controlsEnabled = true;
+};
-- 
cgit