From 24db645167b42adba5d9c221215be83bef39e2a1 Mon Sep 17 00:00:00 2001 From: Petr Mrázek Date: Wed, 3 Jun 2015 21:57:22 +0200 Subject: NOISSUE sanitize Json Removes magical parameter madness. All require* can throw All ensure* need a default value and never throw --- logic/Json.cpp | 55 +++++++++++++++++++++++++------------------------------ 1 file changed, 25 insertions(+), 30 deletions(-) (limited to 'logic/Json.cpp') diff --git a/logic/Json.cpp b/logic/Json.cpp index 97bab474..f2cbc8a3 100644 --- a/logic/Json.cpp +++ b/logic/Json.cpp @@ -44,7 +44,7 @@ static bool isBinaryJson(const QByteArray &data) decltype(QJsonDocument::BinaryFormatTag) tag = QJsonDocument::BinaryFormatTag; return memcmp(data.constData(), &tag, sizeof(QJsonDocument::BinaryFormatTag)) == 0; } -QJsonDocument ensureDocument(const QByteArray &data, const QString &what) +QJsonDocument requireDocument(const QByteArray &data, const QString &what) { if (isBinaryJson(data)) { @@ -66,11 +66,11 @@ QJsonDocument ensureDocument(const QByteArray &data, const QString &what) return doc; } } -QJsonDocument ensureDocument(const QString &filename, const QString &what) +QJsonDocument requireDocument(const QString &filename, const QString &what) { - return ensureDocument(FS::read(filename), what); + return requireDocument(FS::read(filename), what); } -QJsonObject ensureObject(const QJsonDocument &doc, const QString &what) +QJsonObject requireObject(const QJsonDocument &doc, const QString &what) { if (!doc.isObject()) { @@ -78,7 +78,7 @@ QJsonObject ensureObject(const QJsonDocument &doc, const QString &what) } return doc.object(); } -QJsonArray ensureArray(const QJsonDocument &doc, const QString &what) +QJsonArray requireArray(const QJsonDocument &doc, const QString &what) { if (!doc.isArray()) { @@ -140,10 +140,9 @@ QJsonValue toJson(const QVariant &variant) } -template<> QByteArray ensureIsType(const QJsonValue &value, const Requirement, - const QString &what) +template<> QByteArray requireIsType(const QJsonValue &value, const QString &what) { - const QString string = ensureIsType(value, Required, what); + const QString string = ensureIsType(value, what); // ensure that the string can be safely cast to Latin1 if (string != QString::fromLatin1(string.toLatin1())) { @@ -152,7 +151,7 @@ template<> QByteArray ensureIsType(const QJsonValue &value, const Re return QByteArray::fromHex(string.toLatin1()); } -template<> QJsonArray ensureIsType(const QJsonValue &value, const Requirement, const QString &what) +template<> QJsonArray requireIsType(const QJsonValue &value, const QString &what) { if (!value.isArray()) { @@ -162,7 +161,7 @@ template<> QJsonArray ensureIsType(const QJsonValue &value, const Re } -template<> QString ensureIsType(const QJsonValue &value, const Requirement, const QString &what) +template<> QString requireIsType(const QJsonValue &value, const QString &what) { if (!value.isString()) { @@ -171,8 +170,7 @@ template<> QString ensureIsType(const QJsonValue &value, const Requirem return value.toString(); } -template<> bool ensureIsType(const QJsonValue &value, const Requirement, - const QString &what) +template<> bool requireIsType(const QJsonValue &value, const QString &what) { if (!value.isBool()) { @@ -181,8 +179,7 @@ template<> bool ensureIsType(const QJsonValue &value, const Requirement, return value.toBool(); } -template<> double ensureIsType(const QJsonValue &value, const Requirement, - const QString &what) +template<> double requireIsType(const QJsonValue &value, const QString &what) { if (!value.isDouble()) { @@ -191,10 +188,9 @@ template<> double ensureIsType(const QJsonValue &value, const Requiremen return value.toDouble(); } -template<> int ensureIsType(const QJsonValue &value, const Requirement, - const QString &what) +template<> int requireIsType(const QJsonValue &value, const QString &what) { - const double doubl = ensureIsType(value, Required, what); + const double doubl = requireIsType(value, what); if (fmod(doubl, 1) != 0) { throw JsonException(what + " is not an integer"); @@ -202,10 +198,9 @@ template<> int ensureIsType(const QJsonValue &value, const Requirement, return int(doubl); } -template<> QDateTime ensureIsType(const QJsonValue &value, const Requirement, - const QString &what) +template<> QDateTime requireIsType(const QJsonValue &value, const QString &what) { - const QString string = ensureIsType(value, Required, what); + const QString string = requireIsType(value, what); const QDateTime datetime = QDateTime::fromString(string, Qt::ISODate); if (!datetime.isValid()) { @@ -214,10 +209,9 @@ template<> QDateTime ensureIsType(const QJsonValue &value, const Requ return datetime; } -template<> QUrl ensureIsType(const QJsonValue &value, const Requirement, - const QString &what) +template<> QUrl requireIsType(const QJsonValue &value, const QString &what) { - const QString string = ensureIsType(value, Required, what); + const QString string = ensureIsType(value, what); if (string.isEmpty()) { return QUrl(); @@ -230,15 +224,16 @@ template<> QUrl ensureIsType(const QJsonValue &value, const Requirement, return url; } -template<> QDir ensureIsType(const QJsonValue &value, const Requirement, const QString &what) +template<> QDir requireIsType(const QJsonValue &value, const QString &what) { - const QString string = ensureIsType(value, Required, what); + const QString string = requireIsType(value, what); + // FIXME: does not handle invalid characters! return QDir::current().absoluteFilePath(string); } -template<> QUuid ensureIsType(const QJsonValue &value, const Requirement, const QString &what) +template<> QUuid requireIsType(const QJsonValue &value, const QString &what) { - const QString string = ensureIsType(value, Required, what); + const QString string = requireIsType(value, what); const QUuid uuid = QUuid(string); if (uuid.toString() != string) // converts back => valid { @@ -247,7 +242,7 @@ template<> QUuid ensureIsType(const QJsonValue &value, const Requirement, return uuid; } -template<> QJsonObject ensureIsType(const QJsonValue &value, const Requirement, const QString &what) +template<> QJsonObject requireIsType(const QJsonValue &value, const QString &what) { if (!value.isObject()) { @@ -256,7 +251,7 @@ template<> QJsonObject ensureIsType(const QJsonValue &value, const return value.toObject(); } -template<> QVariant ensureIsType(const QJsonValue &value, const Requirement, const QString &what) +template<> QVariant requireIsType(const QJsonValue &value, const QString &what) { if (value.isNull() || value.isUndefined()) { @@ -265,7 +260,7 @@ template<> QVariant ensureIsType(const QJsonValue &value, const Requir return value.toVariant(); } -template<> QJsonValue ensureIsType(const QJsonValue &value, const Requirement, const QString &what) +template<> QJsonValue requireIsType(const QJsonValue &value, const QString &what) { if (value.isNull() || value.isUndefined()) { -- cgit