From ce30cda73e5d9ac74ae4cd1fd22c1dbf6d6488e0 Mon Sep 17 00:00:00 2001 From: swirl Date: Mon, 13 Dec 2021 13:01:29 -0500 Subject: Fix README and some references to MultiMC. --- notsecrets/CMakeLists.txt | 4 ++-- notsecrets/README.md | 18 +++--------------- notsecrets/Secrets.cpp | 2 -- 3 files changed, 5 insertions(+), 19 deletions(-) (limited to 'notsecrets') diff --git a/notsecrets/CMakeLists.txt b/notsecrets/CMakeLists.txt index b5dd3cf8..00b132a3 100644 --- a/notsecrets/CMakeLists.txt +++ b/notsecrets/CMakeLists.txt @@ -3,14 +3,14 @@ target_link_libraries(secrets Qt5::Core) target_compile_definitions(secrets PUBLIC -DEMBED_SECRETS) target_include_directories(secrets PUBLIC .) -set(Launcher_CommonName "DevLauncher") +set(Launcher_CommonName "PolyMC") set(Launcher_Copyright "MultiMC Contributors" PARENT_SCOPE) set(Launcher_Domain "multimc.org" PARENT_SCOPE) set(Launcher_Name "${Launcher_CommonName}" PARENT_SCOPE) set(Launcher_DisplayName "${Launcher_CommonName} 5" PARENT_SCOPE) set(Launcher_UserAgent "${Launcher_CommonName}/5.0" PARENT_SCOPE) -set(Launcher_ConfigFile "devlauncher.cfg" PARENT_SCOPE) +set(Launcher_ConfigFile "polymc.cfg" PARENT_SCOPE) set(Launcher_Git "https://github.com/MultiMC/Launcher" PARENT_SCOPE) set(Launcher_Branding_ICNS "notsecrets/Launcher.icns" PARENT_SCOPE) diff --git a/notsecrets/README.md b/notsecrets/README.md index 4664fa89..dcc67699 100644 --- a/notsecrets/README.md +++ b/notsecrets/README.md @@ -1,6 +1,6 @@ -# DevLauncher (Not) Secrets +# PolyMC (Not) Secrets -This is a dummy implementation of MultiMC's _Secrets_ library, used to store private information needed for: +This is a dummy implementation of PolyMC's _Secrets_ library, used to store private information needed for: - Application name and logo (and branding in general) - Various URLs and API endpoints - Your Microsoft Identity Platform client ID. **This is required to use Microsoft accounts to play!** @@ -8,18 +8,6 @@ This is a dummy implementation of MultiMC's _Secrets_ library, used to store pri ## MultiMC development -In its current state, the `notsecrets` library is suitable for MultiMC code contributions (the code builds as `DevLauncher`). +In its current state, the `notsecrets` library is suitable for PolyMC code contributions. All you have to do is add the Microsoft client ID. See `Secrets.cpp` for details. - -## Forking - -Forks of this project that intend to distribute binaries to users should use their own implementation of this library that does not impersonate MultiMC in any way (see the Apache 2.0 license, common sense and trademark law). - -A fork is a serious business, especially if you intend to distribute binaries to users. This is because you need to agree to the Microsoft identity platform Terms of Use: - -https://docs.microsoft.com/en-us/legal/microsoft-identity-platform/terms-of-use - -If you truly want to accept such an agreement, a starting point is to copy `notsecrets` to `secrets`, enable the `Launcher_EMBED_SECRETS` CMake option and customize the files. - -We do not want confused users asking for help with your fork in MultiMC Discord or similar locations. diff --git a/notsecrets/Secrets.cpp b/notsecrets/Secrets.cpp index 88995635..6d2444a2 100644 --- a/notsecrets/Secrets.cpp +++ b/notsecrets/Secrets.cpp @@ -23,8 +23,6 @@ namespace { * By putting one in here, you accept the terms and conditions for using the MS Identity Plaform and assume all responsibilities associated with it. * See: https://docs.microsoft.com/en-us/legal/microsoft-identity-platform/terms-of-use * - * Above all else, do not impersonate other applications! This includes the Mojang Launcher and MultiMC - your builds are *NOT* MultiMC. - * * If you intend to base your own launcher on this code, take care and customize this to obfuscate the client ID, so it cannot be trivially found by casual attackers. */ -- cgit