<feed xmlns='http://www.w3.org/2005/Atom'>
<title>github/Remap.git/src/test/java, branch master</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<link rel='alternate' type='text/html' href='https://git.nea.moe/github/Remap.git/'/>
<entry>
<title>Separate B from A test files</title>
<updated>2021-11-12T14:23:25+00:00</updated>
<author>
<name>Jonas Herzig</name>
<email>jonas@spark-squared.com</email>
</author>
<published>2021-11-12T10:58:05+00:00</published>
<link rel='alternate' type='text/html' href='https://git.nea.moe/github/Remap.git/commit/?id=b30404f156adb6e01bfe4edc50b4de4245ba4509'/>
<id>b30404f156adb6e01bfe4edc50b4de4245ba4509</id>
<content type='text'>
So we are closer to a realistic setup and can tell when we accidentally look up
a class in the wrong project.
Also allows us to have changes in a class but not to the class or its
package (i.e. same file).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
So we are closer to a realistic setup and can tell when we accidentally look up
a class in the wrong project.
Also allows us to have changes in a class but not to the class or its
package (i.e. same file).
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix synthetic property becoming shadowed by field of same name</title>
<updated>2021-11-12T14:23:25+00:00</updated>
<author>
<name>Jonas Herzig</name>
<email>jonas@spark-squared.com</email>
</author>
<published>2021-11-12T09:58:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.nea.moe/github/Remap.git/commit/?id=5723e6481d2f4e07b6820201e74924643b5687bc'/>
<id>5723e6481d2f4e07b6820201e74924643b5687bc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add tests for Kotlin synthetic properties</title>
<updated>2021-11-12T14:23:25+00:00</updated>
<author>
<name>Jonas Herzig</name>
<email>jonas@spark-squared.com</email>
</author>
<published>2021-11-11T21:25:12+00:00</published>
<link rel='alternate' type='text/html' href='https://git.nea.moe/github/Remap.git/commit/?id=8b1a5a77e75d868cd13ad7dc4d109125711898ce'/>
<id>8b1a5a77e75d868cd13ad7dc4d109125711898ce</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix loss of changes when multiple target the same start point</title>
<updated>2021-11-12T14:23:25+00:00</updated>
<author>
<name>Jonas Herzig</name>
<email>jonas@spark-squared.com</email>
</author>
<published>2021-11-11T19:59:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.nea.moe/github/Remap.git/commit/?id=f1224518f86b0160149544dc8d56505a37a186e2'/>
<id>f1224518f86b0160149544dc8d56505a37a186e2</id>
<content type='text'>
While one might at first think that multiple changes should conflict if they
target that same start point, that is not necessarily true as long as no more
than one of them includes deletions: There may be an arbitrary number of
insertions at the same position (regular remapping never just inserts but
patterns can).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
While one might at first think that multiple changes should conflict if they
target that same start point, that is not necessarily true as long as no more
than one of them includes deletions: There may be an arbitrary number of
insertions at the same position (regular remapping never just inserts but
patterns can).
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix methods in mixin being remapped when they should not be</title>
<updated>2021-11-12T14:23:25+00:00</updated>
<author>
<name>Jonas Herzig</name>
<email>jonas@spark-squared.com</email>
</author>
<published>2021-11-11T19:37:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.nea.moe/github/Remap.git/commit/?id=1aa8b425982a6d30a177bc25a70a325652209ee0'/>
<id>1aa8b425982a6d30a177bc25a70a325652209ee0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix remapping of qualified inner class reference in Kotlin code</title>
<updated>2021-11-11T20:38:47+00:00</updated>
<author>
<name>Jonas Herzig</name>
<email>jonas@spark-squared.com</email>
</author>
<published>2021-11-11T15:52:27+00:00</published>
<link rel='alternate' type='text/html' href='https://git.nea.moe/github/Remap.git/commit/?id=982982c63027e416bd78ca40708c7238e7eed26b'/>
<id>982982c63027e416bd78ca40708c7238e7eed26b</id>
<content type='text'>
When we used to remap `a.pkg.A.Inner` we would apply both mappings (the one for
the inner class and the one for the outer class) at the same time, resulting in
`b.pkg.B.Inner.Inner`.
The direct cause being that we only checked conflicts for the range of the
respective expression (which is just `A` and `Inner` for Kotlin, and therefore
not conflicting) instead of the parent as we should have.

With that fixed, it now also becomes apparent that we need to apply mappings for
dot qualified expressions back to front (otherwise the outer class takes
priority), so that is the second thing this commit change.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When we used to remap `a.pkg.A.Inner` we would apply both mappings (the one for
the inner class and the one for the outer class) at the same time, resulting in
`b.pkg.B.Inner.Inner`.
The direct cause being that we only checked conflicts for the range of the
respective expression (which is just `A` and `Inner` for Kotlin, and therefore
not conflicting) instead of the parent as we should have.

With that fixed, it now also becomes apparent that we need to apply mappings for
dot qualified expressions back to front (otherwise the outer class takes
priority), so that is the second thing this commit change.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix mixin @At target not considering mappings from parent classes</title>
<updated>2021-11-11T14:06:54+00:00</updated>
<author>
<name>Jonas Herzig</name>
<email>jonas@spark-squared.com</email>
</author>
<published>2021-11-11T14:06:54+00:00</published>
<link rel='alternate' type='text/html' href='https://git.nea.moe/github/Remap.git/commit/?id=b4462eb6030f8e5a072ad4b6508d7a93d574522f'/>
<id>b4462eb6030f8e5a072ad4b6508d7a93d574522f</id>
<content type='text'>
When remapping the @At `target` argument, we used to only look at the mappings
for the target class but we also need to consider mappings for its super classes
and interfaces.
This commit now searches for the target Psi method and then uses the regular
remap method for PsiMethod to get its properly mapped name.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When remapping the @At `target` argument, we used to only look at the mappings
for the target class but we also need to consider mappings for its super classes
and interfaces.
This commit now searches for the target Psi method and then uses the regular
remap method for PsiMethod to get its properly mapped name.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add test for anonymous inner class mixin target</title>
<updated>2021-11-10T19:33:45+00:00</updated>
<author>
<name>Jonas Herzig</name>
<email>jonas@spark-squared.com</email>
</author>
<published>2021-11-10T19:33:45+00:00</published>
<link rel='alternate' type='text/html' href='https://git.nea.moe/github/Remap.git/commit/?id=62e3c5a678f10fc810605053289700014a16acd5'/>
<id>62e3c5a678f10fc810605053289700014a16acd5</id>
<content type='text'>
To ensure the mixin target is being remapped, even though the corresponding
PsiClass cannot be found.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
To ensure the mixin target is being remapped, even though the corresponding
PsiClass cannot be found.
</pre>
</div>
</content>
</entry>
<entry>
<title>Remap mixin injector target arguments even when method is not mapped</title>
<updated>2021-11-10T19:32:40+00:00</updated>
<author>
<name>Jonas Herzig</name>
<email>jonas@spark-squared.com</email>
</author>
<published>2021-11-10T18:29:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.nea.moe/github/Remap.git/commit/?id=971ee3e3186f1515e382985ab23a8d32899c5a07'/>
<id>971ee3e3186f1515e382985ab23a8d32899c5a07</id>
<content type='text'>
E.g. there are no mapping entries for constructors cause their name is always
`&lt;init&gt;` but we nevertheless want to remap their argument types.
We cannot determine whether the name is ambiguous in the mapped
environment (because that check is based on the mappings), so we always keep the
arguments when it previously had ones.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
E.g. there are no mapping entries for constructors cause their name is always
`&lt;init&gt;` but we nevertheless want to remap their argument types.
We cannot determine whether the name is ambiguous in the mapped
environment (because that check is based on the mappings), so we always keep the
arguments when it previously had ones.
</pre>
</div>
</content>
</entry>
<entry>
<title>Start adding tests</title>
<updated>2021-11-10T17:11:16+00:00</updated>
<author>
<name>Jonas Herzig</name>
<email>jonas@spark-squared.com</email>
</author>
<published>2021-11-10T08:34:39+00:00</published>
<link rel='alternate' type='text/html' href='https://git.nea.moe/github/Remap.git/commit/?id=7d62cd890cb44945e772e18cdb457b1173f4f853'/>
<id>7d62cd890cb44945e772e18cdb457b1173f4f853</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
