aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorshedaniel <daniel@shedaniel.me>2022-04-13 20:29:14 +0800
committershedaniel <daniel@shedaniel.me>2022-04-13 23:26:42 +0800
commit6fa629621934d32efd6e782d0644a6d95a6498b4 (patch)
treed74711b7b9cd40829920b3a381b1572e874c9bc8
parentedf0e9e19e4779bc5bccf97884953387fd2f4038 (diff)
downloadRoughlyEnoughItems-6fa629621934d32efd6e782d0644a6d95a6498b4.tar.gz
RoughlyEnoughItems-6fa629621934d32efd6e782d0644a6d95a6498b4.tar.bz2
RoughlyEnoughItems-6fa629621934d32efd6e782d0644a6d95a6498b4.zip
Fix empty checks for argument types, Fix #673
-rw-r--r--runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/ModArgumentType.java2
-rw-r--r--runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TextArgumentType.java2
-rw-r--r--runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TooltipArgumentType.java2
3 files changed, 3 insertions, 3 deletions
diff --git a/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/ModArgumentType.java b/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/ModArgumentType.java
index 06e8d35fc..510aab2ac 100644
--- a/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/ModArgumentType.java
+++ b/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/ModArgumentType.java
@@ -75,7 +75,7 @@ public final class ModArgumentType extends ArgumentType<Unit, ModArgumentType.@N
if (pair.modName == null) {
pair.modName = ClientHelper.getInstance().getModFromModId(pair.modId).toLowerCase(Locale.ROOT);
}
- return pair.modName.isEmpty() || pair.modName.contains(searchText);
+ return pair.modName.contains(searchText);
}
@Override
diff --git a/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TextArgumentType.java b/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TextArgumentType.java
index a3ee560f4..1342a2b0c 100644
--- a/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TextArgumentType.java
+++ b/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TextArgumentType.java
@@ -61,7 +61,7 @@ public final class TextArgumentType extends ArgumentType<Unit, String> {
@Override
public boolean matches(String value, EntryStack<?> stack, String searchText, Unit filterData) {
- return !value.isEmpty() && value.contains(searchText);
+ return value.contains(searchText);
}
@Override
diff --git a/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TooltipArgumentType.java b/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TooltipArgumentType.java
index 372214b8a..99e967456 100644
--- a/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TooltipArgumentType.java
+++ b/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TooltipArgumentType.java
@@ -79,7 +79,7 @@ public final class TooltipArgumentType extends ArgumentType<Unit, String> {
public boolean matches(String tooltip, EntryStack<?> stack, String searchText, Unit filterData) {
//noinspection StringEquality
if (tooltip == INVALID) return false;
- return tooltip.isEmpty() || tooltip.contains(searchText);
+ return tooltip.contains(searchText);
}
@Nullable