diff options
| author | shedaniel <daniel@shedaniel.me> | 2020-07-01 00:45:28 +0800 |
|---|---|---|
| committer | shedaniel <daniel@shedaniel.me> | 2020-07-01 00:45:28 +0800 |
| commit | d1c37f282ea82af014f162b7fbfd8001ca66cab0 (patch) | |
| tree | cb12c663de9cc27c314b6715aca8f9226bcd52b9 | |
| parent | d551d8bc8f01a66fd330f3ff6941965011803714 (diff) | |
| download | RoughlyEnoughItems-d1c37f282ea82af014f162b7fbfd8001ca66cab0.tar.gz RoughlyEnoughItems-d1c37f282ea82af014f162b7fbfd8001ca66cab0.tar.bz2 RoughlyEnoughItems-d1c37f282ea82af014f162b7fbfd8001ca66cab0.zip | |
Try fixing up entry tooltip duplications.
Signed-off-by: shedaniel <daniel@shedaniel.me>
| -rw-r--r-- | gradle.properties | 2 | ||||
| -rw-r--r-- | src/main/java/me/shedaniel/rei/impl/FluidEntryStack.java | 5 | ||||
| -rw-r--r-- | src/main/java/me/shedaniel/rei/impl/ItemEntryStack.java | 9 |
3 files changed, 7 insertions, 9 deletions
diff --git a/gradle.properties b/gradle.properties index 7269dd5ab..1c8d13b3c 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1,5 +1,5 @@ org.gradle.jvmargs=-Xmx3G -mod_version=4.5.5 +mod_version=4.5.6 supported_version=1.16.x minecraft_version=1.16.1 yarn_version=1.16.1+build.4+legacy.20w09a+build.8 diff --git a/src/main/java/me/shedaniel/rei/impl/FluidEntryStack.java b/src/main/java/me/shedaniel/rei/impl/FluidEntryStack.java index b038fe07b..0b32405a9 100644 --- a/src/main/java/me/shedaniel/rei/impl/FluidEntryStack.java +++ b/src/main/java/me/shedaniel/rei/impl/FluidEntryStack.java @@ -197,16 +197,15 @@ public class FluidEntryStack extends AbstractEntryStack { toolTip.addAll(get(Settings.TOOLTIP_APPEND_EXTRA).apply(this)); if (get(Settings.TOOLTIP_APPEND_MOD).get() && ConfigObject.getInstance().shouldAppendModNames()) { Identifier id = Registry.FLUID.getId(fluid); - final Text modString = ClientHelper.getInstance().getFormattedModFromIdentifier(id); final String modId = ClientHelper.getInstance().getModFromIdentifier(id); boolean alreadyHasMod = false; for (Text s : toolTip) - if (s.asString().equalsIgnoreCase(modId)) { + if (s.getString().equalsIgnoreCase(modId)) { alreadyHasMod = true; break; } if (!alreadyHasMod) - toolTip.add(modString); + toolTip.add(ClientHelper.getInstance().getFormattedModFromIdentifier(id)); } return Tooltip.create(toolTip); } diff --git a/src/main/java/me/shedaniel/rei/impl/ItemEntryStack.java b/src/main/java/me/shedaniel/rei/impl/ItemEntryStack.java index 1f881c174..96c2cfd4a 100644 --- a/src/main/java/me/shedaniel/rei/impl/ItemEntryStack.java +++ b/src/main/java/me/shedaniel/rei/impl/ItemEntryStack.java @@ -277,19 +277,18 @@ public class ItemEntryStack extends AbstractEntryStack implements OptimalEntrySt public Tooltip getTooltip(Point point) { if (isEmpty() || !get(Settings.TOOLTIP_ENABLED).get()) return null; - List<Text> toolTip = Lists.newArrayList(tryGetItemStackToolTip(true)); + List<Text> toolTip = tryGetItemStackToolTip(true); toolTip.addAll(get(Settings.TOOLTIP_APPEND_EXTRA).apply(this)); if (get(Settings.TOOLTIP_APPEND_MOD).get() && ConfigObject.getInstance().shouldAppendModNames()) { - final Text modString = ClientHelper.getInstance().getFormattedModFromItem(getItem()); final String modId = ClientHelper.getInstance().getModFromItem(getItem()); boolean alreadyHasMod = false; for (Text s : toolTip) - if (s.asString().equalsIgnoreCase(modId)) { + if (s.getString().equalsIgnoreCase(modId)) { alreadyHasMod = true; break; } if (!alreadyHasMod) - toolTip.add(modString); + toolTip.add(ClientHelper.getInstance().getFormattedModFromItem(getItem())); } return Tooltip.create(toolTip); } @@ -377,6 +376,6 @@ public class ItemEntryStack extends AbstractEntryStack implements OptimalEntrySt e.printStackTrace(); SEARCH_BLACKLISTED.add(getItem()); } - return Collections.singletonList(asFormattedText()); + return Lists.newArrayList(asFormattedText()); } } |
