From 30ba1f5975f4a20ea91fad8bf4bf0b740b0ad6fb Mon Sep 17 00:00:00 2001
From: shedaniel <daniel@shedaniel.me>
Date: Wed, 13 Apr 2022 20:29:14 +0800
Subject: Fix empty checks for argument types, Fix #673

---
 .../shedaniel/rei/impl/client/search/argument/type/ModArgumentType.java | 2 +-
 .../rei/impl/client/search/argument/type/TextArgumentType.java          | 2 +-
 .../rei/impl/client/search/argument/type/TooltipArgumentType.java       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

(limited to 'runtime/src/main/java/me')

diff --git a/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/ModArgumentType.java b/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/ModArgumentType.java
index 06e8d35fc..510aab2ac 100644
--- a/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/ModArgumentType.java
+++ b/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/ModArgumentType.java
@@ -75,7 +75,7 @@ public final class ModArgumentType extends ArgumentType<Unit, ModArgumentType.@N
         if (pair.modName == null) {
             pair.modName = ClientHelper.getInstance().getModFromModId(pair.modId).toLowerCase(Locale.ROOT);
         }
-        return pair.modName.isEmpty() || pair.modName.contains(searchText);
+        return pair.modName.contains(searchText);
     }
     
     @Override
diff --git a/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TextArgumentType.java b/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TextArgumentType.java
index a3ee560f4..1342a2b0c 100644
--- a/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TextArgumentType.java
+++ b/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TextArgumentType.java
@@ -61,7 +61,7 @@ public final class TextArgumentType extends ArgumentType<Unit, String> {
     
     @Override
     public boolean matches(String value, EntryStack<?> stack, String searchText, Unit filterData) {
-        return !value.isEmpty() && value.contains(searchText);
+        return value.contains(searchText);
     }
     
     @Override
diff --git a/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TooltipArgumentType.java b/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TooltipArgumentType.java
index 372214b8a..99e967456 100644
--- a/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TooltipArgumentType.java
+++ b/runtime/src/main/java/me/shedaniel/rei/impl/client/search/argument/type/TooltipArgumentType.java
@@ -79,7 +79,7 @@ public final class TooltipArgumentType extends ArgumentType<Unit, String> {
     public boolean matches(String tooltip, EntryStack<?> stack, String searchText, Unit filterData) {
         //noinspection StringEquality
         if (tooltip == INVALID) return false;
-        return tooltip.isEmpty() || tooltip.contains(searchText);
+        return tooltip.contains(searchText);
     }
     
     @Nullable
-- 
cgit