From 270d436a176904ab39fc0ce97da2027dd6ac1114 Mon Sep 17 00:00:00 2001 From: Jesse Plamondon-Willard Date: Tue, 18 Dec 2018 20:15:39 -0500 Subject: remove shell code in Windows installer to reduce antivirus false positives --- docs/release-notes.md | 4 ++++ src/SMAPI.Installer/InteractiveInstaller.cs | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/docs/release-notes.md b/docs/release-notes.md index 813f40a7..41a6cd83 100644 --- a/docs/release-notes.md +++ b/docs/release-notes.md @@ -1,4 +1,8 @@ # Release notes +## Upcoming release +* For players: + * Tweaked installer to reduce antivirus false positives. + ## 2.9.3 * For players: * Fixed errors hovering items in some cases with SMAPI 2.9.2. diff --git a/src/SMAPI.Installer/InteractiveInstaller.cs b/src/SMAPI.Installer/InteractiveInstaller.cs index d5866c74..95aed4ca 100644 --- a/src/SMAPI.Installer/InteractiveInstaller.cs +++ b/src/SMAPI.Installer/InteractiveInstaller.cs @@ -1,6 +1,5 @@ using System; using System.Collections.Generic; -using System.Diagnostics; using System.Globalization; using System.IO; using System.Linq; @@ -13,6 +12,9 @@ using StardewModdingAPI.Internal.ConsoleWriting; using StardewModdingAPI.Toolkit; using StardewModdingAPI.Toolkit.Framework.ModScanning; using StardewModdingAPI.Toolkit.Utilities; +#if !SMAPI_FOR_WINDOWS +using System.Diagnostics; +#endif namespace StardewModdingApi.Installer { @@ -461,6 +463,8 @@ namespace StardewModdingApi.Installer // mark file executable // (MSBuild doesn't keep permission flags for files zipped in a build task.) + // (Note: exclude from Windows build because antivirus apps can flag the process start code as suspicious.) +#if !SMAPI_FOR_WINDOWS new Process { StartInfo = new ProcessStartInfo @@ -470,6 +474,7 @@ namespace StardewModdingApi.Installer CreateNoWindow = true } }.Start(); +#endif } // create mods directory (if needed) -- cgit