From 730d9783959cc35945841ab721c930fad8ff9ca0 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sat, 23 Nov 2019 22:39:57 -0500
Subject: drop mod build package change which sets the x86 platform

Visual Studio changes platform inconsistently when set through a NuGet package, which can cause confusing behavior. It's better to set it directly in the project file instead.
---
 docs/technical/mod-package.md                | 11 +++--------
 src/SMAPI.ModBuildConfig/build/smapi.targets |  4 ----
 src/SMAPI.ModBuildConfig/package.nuspec      |  6 ++----
 3 files changed, 5 insertions(+), 16 deletions(-)

diff --git a/docs/technical/mod-package.md b/docs/technical/mod-package.md
index 43682bfb..a33480ad 100644
--- a/docs/technical/mod-package.md
+++ b/docs/technical/mod-package.md
@@ -130,11 +130,8 @@ To disable game debugging (only needed for some non-mod projects):
 ```
 
 ### Preconfigure common settings
-The package automatically enables PDB files, so error logs show line numbers for simpler debugging.
-
-For projects using the simplified `.csproj` format, it also enables the GAC (to support XNA
-Framework) and sets the build to x86 mode (to avoid 'mismatch between the processor architecture' warnings due to
-  the game being x86).
+The package also automatically enables PDB files (so error logs show line numbers for simpler
+debugging), and enables support for the simplified `.csproj` format.
 
 ### Add code warnings
 The package runs code analysis on your mod and raises warnings for some common errors or pitfalls.
@@ -294,9 +291,7 @@ which can be uploaded to NuGet or referenced directly.
 * Updated for SMAPI 3.0 and Stardew Valley 1.4.
 * Added automatic support for `assets` folders.
 * Added `$(GameExecutableName)` MSBuild variable.
-* Added support for projects using the simplified `.csproj` format:
-  * platform target is now set to x86 automatically to avoid mismatching platform target warnings;
-  * added GAC to assembly search paths to fix references to XNA Framework.
+* Added support for projects using the simplified `.csproj` format.
 * Added option to disable game debugging config.
 * Added `.pdb` files to builds by default (to enable line numbers in error stack traces).
 * Added optional Harmony reference.
diff --git a/src/SMAPI.ModBuildConfig/build/smapi.targets b/src/SMAPI.ModBuildConfig/build/smapi.targets
index 78d3a3d4..5ca9f032 100644
--- a/src/SMAPI.ModBuildConfig/build/smapi.targets
+++ b/src/SMAPI.ModBuildConfig/build/smapi.targets
@@ -8,10 +8,6 @@
   ** Set build options
   **********************************************-->
   <PropertyGroup>
-    <!-- set build to x86 to avoid mismatched platform warnings (only affects mods using new csproj format) -->
-    <Platforms>x86</Platforms>
-    <PlatformTarget>x86</PlatformTarget>
-
     <!-- include PDB file by default to enable line numbers in stack traces -->
     <DebugType>pdbonly</DebugType>
     <DebugSymbols>true</DebugSymbols>
diff --git a/src/SMAPI.ModBuildConfig/package.nuspec b/src/SMAPI.ModBuildConfig/package.nuspec
index 76818c9f..812e5bcb 100644
--- a/src/SMAPI.ModBuildConfig/package.nuspec
+++ b/src/SMAPI.ModBuildConfig/package.nuspec
@@ -2,7 +2,7 @@
 <package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
   <metadata>
     <id>Pathoschild.Stardew.ModBuildConfig</id>
-    <version>3.0.0-beta.6</version>
+    <version>3.0.0</version>
     <title>Build package for SMAPI mods</title>
     <authors>Pathoschild</authors>
     <owners>Pathoschild</owners>
@@ -17,9 +17,7 @@
       - Updated for SMAPI 3.0 and Stardew Valley 1.4.
       - Added automatic support for 'assets' folders.
       - Added $(GameExecutableName) MSBuild variable.
-      - Added support for projects using the simplified .csproj format:
-        - platform target is now set to x86 automatically to avoid mismatching platform target warnings;
-        - added GAC to assembly search paths to fix references to XNA Framework.
+      - Added support for projects using the simplified .csproj format.
       - Added option to disable game debugging config.
       - Added .pdb files to builds by default (to enable line numbers in error stack traces).
       - Added optional Harmony reference.
-- 
cgit