From ec84ba07cc80c74ed0c997550a401def6ea24916 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Fri, 30 Oct 2020 20:46:46 -0400
Subject: apply fish pond rules for roe spawning

---
 .../Framework/ItemRepository.cs                    | 88 +++++++++++++++-------
 1 file changed, 59 insertions(+), 29 deletions(-)

(limited to 'src/SMAPI.Mods.ConsoleCommands')

diff --git a/src/SMAPI.Mods.ConsoleCommands/Framework/ItemRepository.cs b/src/SMAPI.Mods.ConsoleCommands/Framework/ItemRepository.cs
index c5e2b89d..d1dd758b 100644
--- a/src/SMAPI.Mods.ConsoleCommands/Framework/ItemRepository.cs
+++ b/src/SMAPI.Mods.ConsoleCommands/Framework/ItemRepository.cs
@@ -6,6 +6,7 @@ using Microsoft.Xna.Framework;
 using Microsoft.Xna.Framework.Content;
 using StardewModdingAPI.Mods.ConsoleCommands.Framework.ItemData;
 using StardewValley;
+using StardewValley.GameData.FishPond;
 using StardewValley.Menus;
 using StardewValley.Objects;
 using StardewValley.Tools;
@@ -216,39 +217,48 @@ namespace StardewModdingAPI.Mods.ConsoleCommands.Framework
 
                             // roe and aged roe (derived from FishPond.GetFishProduce)
                             case SObject.sellAtFishShopCategory when item.ParentSheetIndex == 812:
-                                foreach (var pair in Game1.objectInformation)
                                 {
-                                    // get input
-                                    SObject input = this.TryCreate(ItemType.Object, pair.Key, p => new SObject(p.ID, 1))?.Item as SObject;
-                                    if (input == null || input.Category != SObject.FishCategory)
-                                        continue;
-                                    Color color = this.GetRoeColor(input);
-
-                                    // yield roe
-                                    SObject roe = null;
-                                    yield return this.TryCreate(ItemType.Object, this.CustomIDOffset * 7 + item.ParentSheetIndex, _ =>
-                                    {
-                                        roe = new ColoredObject(812, 1, color)
-                                        {
-                                            name = $"{input.Name} Roe",
-                                            preserve = { Value = SObject.PreserveType.Roe },
-                                            preservedParentSheetIndex = { Value = input.ParentSheetIndex }
-                                        };
-                                        roe.Price += input.Price / 2;
-                                        return roe;
-                                    });
-
-                                    // aged roe
-                                    if (roe != null && pair.Key != 698) // aged sturgeon roe is caviar, which is a separate item
+                                    this.GetRoeContextTagLookups(out HashSet<string> simpleTags, out List<List<string>> complexTags);
+
+                                    foreach (var pair in Game1.objectInformation)
                                     {
-                                        yield return this.TryCreate(ItemType.Object, this.CustomIDOffset * 7 + item.ParentSheetIndex, _ => new ColoredObject(447, 1, color)
+                                        // get input
+                                        SObject input = this.TryCreate(ItemType.Object, pair.Key, p => new SObject(p.ID, 1))?.Item as SObject;
+                                        var inputTags = input?.GetContextTags();
+                                        if (inputTags?.Any() != true)
+                                            continue;
+
+                                        // check if roe-producing fish
+                                        if (!inputTags.Any(tag => simpleTags.Contains(tag)) && !complexTags.Any(set => set.All(tag => input.HasContextTag(tag))))
+                                            continue;
+
+                                        // yield roe
+                                        SObject roe = null;
+                                        Color color = this.GetRoeColor(input);
+                                        yield return this.TryCreate(ItemType.Object, this.CustomIDOffset * 7 + item.ParentSheetIndex, _ =>
                                         {
-                                            name = $"Aged {input.Name} Roe",
-                                            Category = -27,
-                                            preserve = { Value = SObject.PreserveType.AgedRoe },
-                                            preservedParentSheetIndex = { Value = input.ParentSheetIndex },
-                                            Price = roe.Price * 2
+                                            roe = new ColoredObject(812, 1, color)
+                                            {
+                                                name = $"{input.Name} Roe",
+                                                preserve = { Value = SObject.PreserveType.Roe },
+                                                preservedParentSheetIndex = { Value = input.ParentSheetIndex }
+                                            };
+                                            roe.Price += input.Price / 2;
+                                            return roe;
                                         });
+
+                                        // aged roe
+                                        if (roe != null && pair.Key != 698) // aged sturgeon roe is caviar, which is a separate item
+                                        {
+                                            yield return this.TryCreate(ItemType.Object, this.CustomIDOffset * 7 + item.ParentSheetIndex, _ => new ColoredObject(447, 1, color)
+                                            {
+                                                name = $"Aged {input.Name} Roe",
+                                                Category = -27,
+                                                preserve = { Value = SObject.PreserveType.AgedRoe },
+                                                preservedParentSheetIndex = { Value = input.ParentSheetIndex },
+                                                Price = roe.Price * 2
+                                            });
+                                        }
                                     }
                                 }
                                 break;
@@ -264,6 +274,26 @@ namespace StardewModdingAPI.Mods.ConsoleCommands.Framework
         /*********
         ** Private methods
         *********/
+        /// <summary>Get optimized lookups to match items which produce roe in a fish pond.</summary>
+        /// <param name="simpleTags">A lookup of simple singular tags which match a roe-producing fish.</param>
+        /// <param name="complexTags">A list of tag sets which match roe-producing fish.</param>
+        private void GetRoeContextTagLookups(out HashSet<string> simpleTags, out List<List<string>> complexTags)
+        {
+            simpleTags = new HashSet<string>();
+            complexTags = new List<List<string>>();
+
+            foreach (FishPondData data in Game1.content.Load<List<FishPondData>>("Data\\FishPondData"))
+            {
+                if (data.ProducedItems.All(p => p.ItemID != 812))
+                    continue; // doesn't produce roe
+
+                if (data.RequiredTags.Count == 1 && !data.RequiredTags[0].StartsWith("!"))
+                    simpleTags.Add(data.RequiredTags[0]);
+                else
+                    complexTags.Add(data.RequiredTags);
+            }
+        }
+
         /// <summary>Try to load a data file, and return empty data if it's invalid.</summary>
         /// <typeparam name="TKey">The asset key type.</typeparam>
         /// <typeparam name="TValue">The asset value type.</typeparam>
-- 
cgit