From 4d9fd63d9e890a10029508c7d7e31dcc0b579db7 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Wed, 6 Jul 2022 19:24:49 -0400
Subject: update code annotations

---
 src/SMAPI.Toolkit/Framework/Clients/Wiki/WikiClient.cs    | 10 +++++-----
 src/SMAPI.Toolkit/Framework/LowLevelEnvironmentUtility.cs |  7 +++++--
 2 files changed, 10 insertions(+), 7 deletions(-)

(limited to 'src/SMAPI.Toolkit/Framework')

diff --git a/src/SMAPI.Toolkit/Framework/Clients/Wiki/WikiClient.cs b/src/SMAPI.Toolkit/Framework/Clients/Wiki/WikiClient.cs
index 7f06d170..3bdd145a 100644
--- a/src/SMAPI.Toolkit/Framework/Clients/Wiki/WikiClient.cs
+++ b/src/SMAPI.Toolkit/Framework/Clients/Wiki/WikiClient.cs
@@ -283,8 +283,8 @@ namespace StardewModdingAPI.Toolkit.Framework.Clients.Wiki
         }
 
         /// <summary>The response model for the MediaWiki parse API.</summary>
-        [SuppressMessage("ReSharper", "ClassNeverInstantiated.Local")]
-        [SuppressMessage("ReSharper", "UnusedAutoPropertyAccessor.Local")]
+        [SuppressMessage("ReSharper", "ClassNeverInstantiated.Local", Justification = "Used via JSON deserialization.")]
+        [SuppressMessage("ReSharper", "UnusedAutoPropertyAccessor.Local", Justification = "Used via JSON deserialization.")]
         private class ResponseModel
         {
             /*********
@@ -306,9 +306,9 @@ namespace StardewModdingAPI.Toolkit.Framework.Clients.Wiki
         }
 
         /// <summary>The inner response model for the MediaWiki parse API.</summary>
-        [SuppressMessage("ReSharper", "ClassNeverInstantiated.Local")]
-        [SuppressMessage("ReSharper", "CollectionNeverUpdated.Local")]
-        [SuppressMessage("ReSharper", "UnusedAutoPropertyAccessor.Local")]
+        [SuppressMessage("ReSharper", "ClassNeverInstantiated.Local", Justification = "Used via JSON deserialization.")]
+        [SuppressMessage("ReSharper", "CollectionNeverUpdated.Local", Justification = "Used via JSON deserialization.")]
+        [SuppressMessage("ReSharper", "UnusedAutoPropertyAccessor.Local", Justification = "Used via JSON deserialization.")]
         private class ResponseParseModel
         {
             /*********
diff --git a/src/SMAPI.Toolkit/Framework/LowLevelEnvironmentUtility.cs b/src/SMAPI.Toolkit/Framework/LowLevelEnvironmentUtility.cs
index 6978567e..118b71b2 100644
--- a/src/SMAPI.Toolkit/Framework/LowLevelEnvironmentUtility.cs
+++ b/src/SMAPI.Toolkit/Framework/LowLevelEnvironmentUtility.cs
@@ -21,6 +21,7 @@ namespace StardewModdingAPI.Toolkit.Framework
         /// <summary>Get the OS name from the system uname command.</summary>
         /// <param name="buffer">The buffer to fill with the resulting string.</param>
         [DllImport("libc")]
+        [SuppressMessage("ReSharper", "IdentifierTypo", Justification = "This is the actual external command name.")]
         static extern int uname(IntPtr buffer);
 
 
@@ -51,7 +52,6 @@ namespace StardewModdingAPI.Toolkit.Framework
 
         /// <summary>Get the human-readable OS name and version.</summary>
         /// <param name="platform">The current platform.</param>
-        [SuppressMessage("ReSharper", "EmptyGeneralCatchClause", Justification = "Error suppressed deliberately to fallback to default behaviour.")]
         public static string GetFriendlyPlatformName(string platform)
         {
 #if SMAPI_FOR_WINDOWS
@@ -65,7 +65,10 @@ namespace StardewModdingAPI.Toolkit.Framework
 
                 return result ?? "Windows";
             }
-            catch { }
+            catch
+            {
+                // fallback to default behavior
+            }
 #endif
 
             string name = Environment.OSVersion.ToString();
-- 
cgit