From 0b48c1748b354458059c7607415288de072b01e9 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Tue, 12 Apr 2022 19:15:39 -0400
Subject: enable nullable annotations in the web project & related code (#837)

---
 .../Clients/CurseForge/CurseForgeClient.cs         | 14 +++++-----
 .../CurseForge/ResponseModels/ModFileModel.cs      | 22 +++++++++++++---
 .../Clients/CurseForge/ResponseModels/ModModel.cs  | 30 +++++++++++++++++-----
 3 files changed, 48 insertions(+), 18 deletions(-)

(limited to 'src/SMAPI.Web/Framework/Clients/CurseForge')

diff --git a/src/SMAPI.Web/Framework/Clients/CurseForge/CurseForgeClient.cs b/src/SMAPI.Web/Framework/Clients/CurseForge/CurseForgeClient.cs
index 5ef369d5..d351b42d 100644
--- a/src/SMAPI.Web/Framework/Clients/CurseForge/CurseForgeClient.cs
+++ b/src/SMAPI.Web/Framework/Clients/CurseForge/CurseForgeClient.cs
@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Collections.Generic;
 using System.Text.RegularExpressions;
 using System.Threading.Tasks;
@@ -42,7 +40,7 @@ namespace StardewModdingAPI.Web.Framework.Clients.CurseForge
 
         /// <summary>Get update check info about a mod.</summary>
         /// <param name="id">The mod ID.</param>
-        public async Task<IModPage> GetModData(string id)
+        public async Task<IModPage?> GetModData(string id)
         {
             IModPage page = new GenericModPage(this.SiteKey, id);
 
@@ -51,9 +49,9 @@ namespace StardewModdingAPI.Web.Framework.Clients.CurseForge
                 return page.SetError(RemoteModStatus.DoesNotExist, $"The value '{id}' isn't a valid CurseForge mod ID, must be an integer ID.");
 
             // get raw data
-            ModModel mod = await this.Client
+            ModModel? mod = await this.Client
                 .GetAsync($"addon/{parsedId}")
-                .As<ModModel>();
+                .As<ModModel?>();
             if (mod == null)
                 return page.SetError(RemoteModStatus.DoesNotExist, "Found no CurseForge mod with this ID.");
 
@@ -73,7 +71,7 @@ namespace StardewModdingAPI.Web.Framework.Clients.CurseForge
         /// <summary>Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources.</summary>
         public void Dispose()
         {
-            this.Client?.Dispose();
+            this.Client.Dispose();
         }
 
 
@@ -82,9 +80,9 @@ namespace StardewModdingAPI.Web.Framework.Clients.CurseForge
         *********/
         /// <summary>Get a raw version string for a mod file, if available.</summary>
         /// <param name="file">The file whose version to get.</param>
-        private string GetRawVersion(ModFileModel file)
+        private string? GetRawVersion(ModFileModel file)
         {
-            Match match = this.VersionInNamePattern.Match(file.DisplayName);
+            Match match = this.VersionInNamePattern.Match(file.DisplayName ?? "");
             if (!match.Success)
                 match = this.VersionInNamePattern.Match(file.FileName);
 
diff --git a/src/SMAPI.Web/Framework/Clients/CurseForge/ResponseModels/ModFileModel.cs b/src/SMAPI.Web/Framework/Clients/CurseForge/ResponseModels/ModFileModel.cs
index eabef9f0..e9adcf20 100644
--- a/src/SMAPI.Web/Framework/Clients/CurseForge/ResponseModels/ModFileModel.cs
+++ b/src/SMAPI.Web/Framework/Clients/CurseForge/ResponseModels/ModFileModel.cs
@@ -1,14 +1,28 @@
-#nullable disable
-
 namespace StardewModdingAPI.Web.Framework.Clients.CurseForge.ResponseModels
 {
     /// <summary>Metadata from the CurseForge API about a mod file.</summary>
     public class ModFileModel
     {
+        /*********
+        ** Accessors
+        *********/
         /// <summary>The file name as downloaded.</summary>
-        public string FileName { get; set; }
+        public string FileName { get; }
 
         /// <summary>The file display name.</summary>
-        public string DisplayName { get; set; }
+        public string? DisplayName { get; }
+
+
+        /*********
+        ** Public methods
+        *********/
+        /// <summary>Construct an instance.</summary>
+        /// <param name="fileName">The file name as downloaded.</param>
+        /// <param name="displayName">The file display name.</param>
+        public ModFileModel(string fileName, string? displayName)
+        {
+            this.FileName = fileName;
+            this.DisplayName = displayName;
+        }
     }
 }
diff --git a/src/SMAPI.Web/Framework/Clients/CurseForge/ResponseModels/ModModel.cs b/src/SMAPI.Web/Framework/Clients/CurseForge/ResponseModels/ModModel.cs
index a95df7f1..fd7796f2 100644
--- a/src/SMAPI.Web/Framework/Clients/CurseForge/ResponseModels/ModModel.cs
+++ b/src/SMAPI.Web/Framework/Clients/CurseForge/ResponseModels/ModModel.cs
@@ -1,20 +1,38 @@
-#nullable disable
-
 namespace StardewModdingAPI.Web.Framework.Clients.CurseForge.ResponseModels
 {
     /// <summary>An mod from the CurseForge API.</summary>
     public class ModModel
     {
+        /*********
+        ** Accessors
+        *********/
         /// <summary>The mod's unique ID on CurseForge.</summary>
-        public int ID { get; set; }
+        public int ID { get; }
 
         /// <summary>The mod name.</summary>
-        public string Name { get; set; }
+        public string Name { get; }
 
         /// <summary>The web URL for the mod page.</summary>
-        public string WebsiteUrl { get; set; }
+        public string WebsiteUrl { get; }
 
         /// <summary>The available file downloads.</summary>
-        public ModFileModel[] LatestFiles { get; set; }
+        public ModFileModel[] LatestFiles { get; }
+
+
+        /*********
+        ** Public methods
+        *********/
+        /// <summary>Construct an instance.</summary>
+        /// <param name="id">The mod's unique ID on CurseForge.</param>
+        /// <param name="name">The mod name.</param>
+        /// <param name="websiteUrl">The web URL for the mod page.</param>
+        /// <param name="latestFiles">The available file downloads.</param>
+        public ModModel(int id, string name, string websiteUrl, ModFileModel[] latestFiles)
+        {
+            this.ID = id;
+            this.Name = name;
+            this.WebsiteUrl = websiteUrl;
+            this.LatestFiles = latestFiles;
+        }
     }
 }
-- 
cgit