From b395e92faae0a197a2d1c2e10e835e38fcc6502c Mon Sep 17 00:00:00 2001
From: Chase W <spacechase0@users.noreply.github.com>
Date: Mon, 15 Jun 2020 15:28:03 -0400
Subject: Implemented event priority attribute

---
 src/SMAPI/Events/EventPriority.cs          | 29 +++++++++++++++++++++++++++++
 src/SMAPI/Events/EventPriorityAttribute.cs | 29 +++++++++++++++++++++++++++++
 2 files changed, 58 insertions(+)
 create mode 100644 src/SMAPI/Events/EventPriority.cs
 create mode 100644 src/SMAPI/Events/EventPriorityAttribute.cs

(limited to 'src/SMAPI/Events')

diff --git a/src/SMAPI/Events/EventPriority.cs b/src/SMAPI/Events/EventPriority.cs
new file mode 100644
index 00000000..17f5fbb7
--- /dev/null
+++ b/src/SMAPI/Events/EventPriority.cs
@@ -0,0 +1,29 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace StardewModdingAPI.Events
+{
+    /// <summary>
+    /// Event priority for method handlers.
+    /// </summary>
+    public enum EventPriority
+    {
+        /// <summary>
+        /// Low priority.
+        /// </summary>
+        Low = 3,
+
+        /// <summary>
+        /// Normal priority. This is the default.
+        /// </summary>
+        Normal = 2,
+
+        /// <summary>
+        /// High priority.
+        /// </summary>
+        High = 1,
+    }
+}
diff --git a/src/SMAPI/Events/EventPriorityAttribute.cs b/src/SMAPI/Events/EventPriorityAttribute.cs
new file mode 100644
index 00000000..c5683931
--- /dev/null
+++ b/src/SMAPI/Events/EventPriorityAttribute.cs
@@ -0,0 +1,29 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace StardewModdingAPI.Events
+{
+    /// <summary>
+    /// An attribute for controlling event priority of an event handler.
+    /// </summary>
+    [AttributeUsage(AttributeTargets.Method)]
+    public class EventPriorityAttribute : System.Attribute
+    {
+        /// <summary>
+        /// The priority for the method marked by this attribute.
+        /// </summary>
+        public EventPriority Priority { get; }
+
+        /// <summary>
+        /// Constructor.
+        /// </summary>
+        /// <param name="priority">The priority for method marked by this attribute.</param>
+        public EventPriorityAttribute( EventPriority priority )
+        {
+            this.Priority = priority;
+        }
+    }
+}
-- 
cgit 


From fc29fe918a89623544b011c76217aa1ea1975d00 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Mon, 15 Jun 2020 18:58:05 -0400
Subject: refactor & optimize event code a bit, drop old support for unknown
 event handlers

---
 src/SMAPI/Events/EventPriority.cs          | 24 +++++------------------
 src/SMAPI/Events/EventPriorityAttribute.cs | 31 ++++++++++++++----------------
 2 files changed, 19 insertions(+), 36 deletions(-)

(limited to 'src/SMAPI/Events')

diff --git a/src/SMAPI/Events/EventPriority.cs b/src/SMAPI/Events/EventPriority.cs
index 17f5fbb7..e1fb00ac 100644
--- a/src/SMAPI/Events/EventPriority.cs
+++ b/src/SMAPI/Events/EventPriority.cs
@@ -1,29 +1,15 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
 namespace StardewModdingAPI.Events
 {
-    /// <summary>
-    /// Event priority for method handlers.
-    /// </summary>
+    /// <summary>The event priorities for method handlers.</summary>
     public enum EventPriority
     {
-        /// <summary>
-        /// Low priority.
-        /// </summary>
+        /// <summary>Low priority.</summary>
         Low = 3,
 
-        /// <summary>
-        /// Normal priority. This is the default.
-        /// </summary>
+        /// <summary>The default priority.</summary>
         Normal = 2,
 
-        /// <summary>
-        /// High priority.
-        /// </summary>
-        High = 1,
+        /// <summary>High priority.</summary>
+        High = 1
     }
 }
diff --git a/src/SMAPI/Events/EventPriorityAttribute.cs b/src/SMAPI/Events/EventPriorityAttribute.cs
index c5683931..207e7862 100644
--- a/src/SMAPI/Events/EventPriorityAttribute.cs
+++ b/src/SMAPI/Events/EventPriorityAttribute.cs
@@ -1,27 +1,24 @@
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace StardewModdingAPI.Events
 {
-    /// <summary>
-    /// An attribute for controlling event priority of an event handler.
-    /// </summary>
+    /// <summary>An attribute which specifies the priority for an event handler.</summary>
     [AttributeUsage(AttributeTargets.Method)]
-    public class EventPriorityAttribute : System.Attribute
+    public class EventPriorityAttribute : Attribute
     {
-        /// <summary>
-        /// The priority for the method marked by this attribute.
-        /// </summary>
-        public EventPriority Priority { get; }
+        /*********
+        ** Accessors
+        *********/
+        /// <summary>The event handler priority, relative to other handlers across all mods registered for this event.</summary>
+        internal EventPriority Priority { get; }
 
-        /// <summary>
-        /// Constructor.
-        /// </summary>
-        /// <param name="priority">The priority for method marked by this attribute.</param>
-        public EventPriorityAttribute( EventPriority priority )
+
+        /*********
+        ** Public methods
+        *********/
+        /// <summary>Construct an instance.</summary>
+        /// <param name="priority">The event handler priority, relative to other handlers across all mods registered for this event. Higher-priority handlers are notified before lower-priority handlers.</param>
+        public EventPriorityAttribute(EventPriority priority)
         {
             this.Priority = priority;
         }
-- 
cgit 


From da95a906bf8e812ddcd99a90a4d49942f02f5623 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Mon, 15 Jun 2020 18:59:05 -0400
Subject: increase event priority range

This can be used in cases where more granular priority is needed.
---
 src/SMAPI/Events/EventPriority.cs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'src/SMAPI/Events')

diff --git a/src/SMAPI/Events/EventPriority.cs b/src/SMAPI/Events/EventPriority.cs
index e1fb00ac..1efb4e2a 100644
--- a/src/SMAPI/Events/EventPriority.cs
+++ b/src/SMAPI/Events/EventPriority.cs
@@ -4,12 +4,12 @@ namespace StardewModdingAPI.Events
     public enum EventPriority
     {
         /// <summary>Low priority.</summary>
-        Low = 3,
+        Low = -1000,
 
         /// <summary>The default priority.</summary>
-        Normal = 2,
+        Normal = 0,
 
         /// <summary>High priority.</summary>
-        High = 1
+        High = 1000
     }
 }
-- 
cgit