From c4a82418ac8b09a6965052f5c9173928457fba52 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Thu, 27 Dec 2018 12:39:10 -0500
Subject: tweak comment header convention

---
 src/SMAPI/Framework/ModLoading/AssemblyDefinitionResolver.cs            | 2 +-
 src/SMAPI/Framework/ModLoading/AssemblyLoader.cs                        | 2 +-
 src/SMAPI/Framework/ModLoading/Finders/EventFinder.cs                   | 2 +-
 src/SMAPI/Framework/ModLoading/Finders/FieldFinder.cs                   | 2 +-
 src/SMAPI/Framework/ModLoading/Finders/MethodFinder.cs                  | 2 +-
 src/SMAPI/Framework/ModLoading/Finders/PropertyFinder.cs                | 2 +-
 .../ModLoading/Finders/ReferenceToMemberWithUnexpectedTypeFinder.cs     | 2 +-
 .../Framework/ModLoading/Finders/ReferenceToMissingMemberFinder.cs      | 2 +-
 src/SMAPI/Framework/ModLoading/RewriteHelper.cs                         | 2 +-
 src/SMAPI/Framework/ModLoading/Rewriters/FieldReplaceRewriter.cs        | 2 +-
 src/SMAPI/Framework/ModLoading/Rewriters/FieldToPropertyRewriter.cs     | 2 +-
 src/SMAPI/Framework/ModLoading/Rewriters/MethodParentRewriter.cs        | 2 +-
 .../Framework/ModLoading/Rewriters/StaticFieldToConstantRewriter.cs     | 2 +-
 src/SMAPI/Framework/ModLoading/Rewriters/TypeReferenceRewriter.cs       | 2 +-
 14 files changed, 14 insertions(+), 14 deletions(-)

(limited to 'src/SMAPI/Framework/ModLoading')

diff --git a/src/SMAPI/Framework/ModLoading/AssemblyDefinitionResolver.cs b/src/SMAPI/Framework/ModLoading/AssemblyDefinitionResolver.cs
index 91c9e192..aefb0126 100644
--- a/src/SMAPI/Framework/ModLoading/AssemblyDefinitionResolver.cs
+++ b/src/SMAPI/Framework/ModLoading/AssemblyDefinitionResolver.cs
@@ -7,7 +7,7 @@ namespace StardewModdingAPI.Framework.ModLoading
     internal class AssemblyDefinitionResolver : DefaultAssemblyResolver
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The known assemblies.</summary>
         private readonly IDictionary<string, AssemblyDefinition> Lookup = new Dictionary<string, AssemblyDefinition>();
diff --git a/src/SMAPI/Framework/ModLoading/AssemblyLoader.cs b/src/SMAPI/Framework/ModLoading/AssemblyLoader.cs
index 7292cf3f..5e0571a0 100644
--- a/src/SMAPI/Framework/ModLoading/AssemblyLoader.cs
+++ b/src/SMAPI/Framework/ModLoading/AssemblyLoader.cs
@@ -15,7 +15,7 @@ namespace StardewModdingAPI.Framework.ModLoading
     internal class AssemblyLoader : IDisposable
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>Encapsulates monitoring and logging.</summary>
         private readonly IMonitor Monitor;
diff --git a/src/SMAPI/Framework/ModLoading/Finders/EventFinder.cs b/src/SMAPI/Framework/ModLoading/Finders/EventFinder.cs
index e4beb7a9..898bafb4 100644
--- a/src/SMAPI/Framework/ModLoading/Finders/EventFinder.cs
+++ b/src/SMAPI/Framework/ModLoading/Finders/EventFinder.cs
@@ -7,7 +7,7 @@ namespace StardewModdingAPI.Framework.ModLoading.Finders
     internal class EventFinder : IInstructionHandler
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The full type name for which to find references.</summary>
         private readonly string FullTypeName;
diff --git a/src/SMAPI/Framework/ModLoading/Finders/FieldFinder.cs b/src/SMAPI/Framework/ModLoading/Finders/FieldFinder.cs
index 00805815..606ca8b7 100644
--- a/src/SMAPI/Framework/ModLoading/Finders/FieldFinder.cs
+++ b/src/SMAPI/Framework/ModLoading/Finders/FieldFinder.cs
@@ -7,7 +7,7 @@ namespace StardewModdingAPI.Framework.ModLoading.Finders
     internal class FieldFinder : IInstructionHandler
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The full type name for which to find references.</summary>
         private readonly string FullTypeName;
diff --git a/src/SMAPI/Framework/ModLoading/Finders/MethodFinder.cs b/src/SMAPI/Framework/ModLoading/Finders/MethodFinder.cs
index 5358f181..9ca246ff 100644
--- a/src/SMAPI/Framework/ModLoading/Finders/MethodFinder.cs
+++ b/src/SMAPI/Framework/ModLoading/Finders/MethodFinder.cs
@@ -7,7 +7,7 @@ namespace StardewModdingAPI.Framework.ModLoading.Finders
     internal class MethodFinder : IInstructionHandler
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The full type name for which to find references.</summary>
         private readonly string FullTypeName;
diff --git a/src/SMAPI/Framework/ModLoading/Finders/PropertyFinder.cs b/src/SMAPI/Framework/ModLoading/Finders/PropertyFinder.cs
index e54c86cf..0677aa88 100644
--- a/src/SMAPI/Framework/ModLoading/Finders/PropertyFinder.cs
+++ b/src/SMAPI/Framework/ModLoading/Finders/PropertyFinder.cs
@@ -7,7 +7,7 @@ namespace StardewModdingAPI.Framework.ModLoading.Finders
     internal class PropertyFinder : IInstructionHandler
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The full type name for which to find references.</summary>
         private readonly string FullTypeName;
diff --git a/src/SMAPI/Framework/ModLoading/Finders/ReferenceToMemberWithUnexpectedTypeFinder.cs b/src/SMAPI/Framework/ModLoading/Finders/ReferenceToMemberWithUnexpectedTypeFinder.cs
index 3a26660f..82c4920a 100644
--- a/src/SMAPI/Framework/ModLoading/Finders/ReferenceToMemberWithUnexpectedTypeFinder.cs
+++ b/src/SMAPI/Framework/ModLoading/Finders/ReferenceToMemberWithUnexpectedTypeFinder.cs
@@ -10,7 +10,7 @@ namespace StardewModdingAPI.Framework.ModLoading.Finders
     internal class ReferenceToMemberWithUnexpectedTypeFinder : IInstructionHandler
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The assembly names to which to heuristically detect broken references.</summary>
         private readonly HashSet<string> ValidateReferencesToAssemblies;
diff --git a/src/SMAPI/Framework/ModLoading/Finders/ReferenceToMissingMemberFinder.cs b/src/SMAPI/Framework/ModLoading/Finders/ReferenceToMissingMemberFinder.cs
index b95dd79c..44b531a5 100644
--- a/src/SMAPI/Framework/ModLoading/Finders/ReferenceToMissingMemberFinder.cs
+++ b/src/SMAPI/Framework/ModLoading/Finders/ReferenceToMissingMemberFinder.cs
@@ -10,7 +10,7 @@ namespace StardewModdingAPI.Framework.ModLoading.Finders
     internal class ReferenceToMissingMemberFinder : IInstructionHandler
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The assembly names to which to heuristically detect broken references.</summary>
         private readonly HashSet<string> ValidateReferencesToAssemblies;
diff --git a/src/SMAPI/Framework/ModLoading/RewriteHelper.cs b/src/SMAPI/Framework/ModLoading/RewriteHelper.cs
index 9ff43d45..f8f10dc4 100644
--- a/src/SMAPI/Framework/ModLoading/RewriteHelper.cs
+++ b/src/SMAPI/Framework/ModLoading/RewriteHelper.cs
@@ -10,7 +10,7 @@ namespace StardewModdingAPI.Framework.ModLoading
     internal static class RewriteHelper
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The comparer which heuristically compares type definitions.</summary>
         private static readonly TypeReferenceComparer TypeDefinitionComparer = new TypeReferenceComparer();
diff --git a/src/SMAPI/Framework/ModLoading/Rewriters/FieldReplaceRewriter.cs b/src/SMAPI/Framework/ModLoading/Rewriters/FieldReplaceRewriter.cs
index 806a074f..ff86c6e2 100644
--- a/src/SMAPI/Framework/ModLoading/Rewriters/FieldReplaceRewriter.cs
+++ b/src/SMAPI/Framework/ModLoading/Rewriters/FieldReplaceRewriter.cs
@@ -10,7 +10,7 @@ namespace StardewModdingAPI.Framework.ModLoading.Rewriters
     internal class FieldReplaceRewriter : FieldFinder
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The new field to reference.</summary>
         private readonly FieldInfo ToField;
diff --git a/src/SMAPI/Framework/ModLoading/Rewriters/FieldToPropertyRewriter.cs b/src/SMAPI/Framework/ModLoading/Rewriters/FieldToPropertyRewriter.cs
index e6ede9e3..a43c5e9a 100644
--- a/src/SMAPI/Framework/ModLoading/Rewriters/FieldToPropertyRewriter.cs
+++ b/src/SMAPI/Framework/ModLoading/Rewriters/FieldToPropertyRewriter.cs
@@ -9,7 +9,7 @@ namespace StardewModdingAPI.Framework.ModLoading.Rewriters
     internal class FieldToPropertyRewriter : FieldFinder
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The type whose field to which references should be rewritten.</summary>
         private readonly Type Type;
diff --git a/src/SMAPI/Framework/ModLoading/Rewriters/MethodParentRewriter.cs b/src/SMAPI/Framework/ModLoading/Rewriters/MethodParentRewriter.cs
index 99bd9125..6b8c2de1 100644
--- a/src/SMAPI/Framework/ModLoading/Rewriters/MethodParentRewriter.cs
+++ b/src/SMAPI/Framework/ModLoading/Rewriters/MethodParentRewriter.cs
@@ -8,7 +8,7 @@ namespace StardewModdingAPI.Framework.ModLoading.Rewriters
     internal class MethodParentRewriter : IInstructionHandler
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The type whose methods to remap.</summary>
         private readonly Type FromType;
diff --git a/src/SMAPI/Framework/ModLoading/Rewriters/StaticFieldToConstantRewriter.cs b/src/SMAPI/Framework/ModLoading/Rewriters/StaticFieldToConstantRewriter.cs
index 5e12b46a..7e7c0efa 100644
--- a/src/SMAPI/Framework/ModLoading/Rewriters/StaticFieldToConstantRewriter.cs
+++ b/src/SMAPI/Framework/ModLoading/Rewriters/StaticFieldToConstantRewriter.cs
@@ -10,7 +10,7 @@ namespace StardewModdingAPI.Framework.ModLoading.Rewriters
     internal class StaticFieldToConstantRewriter<TValue> : FieldFinder
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The constant value to replace with.</summary>
         private readonly TValue Value;
diff --git a/src/SMAPI/Framework/ModLoading/Rewriters/TypeReferenceRewriter.cs b/src/SMAPI/Framework/ModLoading/Rewriters/TypeReferenceRewriter.cs
index 62e15731..fade082b 100644
--- a/src/SMAPI/Framework/ModLoading/Rewriters/TypeReferenceRewriter.cs
+++ b/src/SMAPI/Framework/ModLoading/Rewriters/TypeReferenceRewriter.cs
@@ -9,7 +9,7 @@ namespace StardewModdingAPI.Framework.ModLoading.Rewriters
     internal class TypeReferenceRewriter : TypeFinder
     {
         /*********
-        ** Properties
+        ** Fields
         *********/
         /// <summary>The full type name to which to find references.</summary>
         private readonly string FromTypeName;
-- 
cgit 


From 2e63fff9ab2d7b9720f2ab5d2e338fb701a70661 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Thu, 27 Dec 2018 13:41:19 -0500
Subject: mark structs readonly

---
 src/SMAPI/Framework/ModLoading/ModResolver.cs | 2 +-
 src/SMAPI/Framework/Reflection/CacheEntry.cs  | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

(limited to 'src/SMAPI/Framework/ModLoading')

diff --git a/src/SMAPI/Framework/ModLoading/ModResolver.cs b/src/SMAPI/Framework/ModLoading/ModResolver.cs
index ace84054..835b0a54 100644
--- a/src/SMAPI/Framework/ModLoading/ModResolver.cs
+++ b/src/SMAPI/Framework/ModLoading/ModResolver.cs
@@ -400,7 +400,7 @@ namespace StardewModdingAPI.Framework.ModLoading
         ** Private models
         *********/
         /// <summary>Represents a dependency from one mod to another.</summary>
-        private struct ModDependency
+        private readonly struct ModDependency
         {
             /*********
             ** Accessors
diff --git a/src/SMAPI/Framework/Reflection/CacheEntry.cs b/src/SMAPI/Framework/Reflection/CacheEntry.cs
index 30faca37..912662e3 100644
--- a/src/SMAPI/Framework/Reflection/CacheEntry.cs
+++ b/src/SMAPI/Framework/Reflection/CacheEntry.cs
@@ -3,16 +3,16 @@ using System.Reflection;
 namespace StardewModdingAPI.Framework.Reflection
 {
     /// <summary>A cached member reflection result.</summary>
-    internal struct CacheEntry
+    internal readonly struct CacheEntry
     {
         /*********
         ** Accessors
         *********/
         /// <summary>Whether the lookup found a valid match.</summary>
-        public bool IsValid;
+        public bool IsValid { get; }
 
         /// <summary>The reflection data for this member (or <c>null</c> if invalid).</summary>
-        public MemberInfo MemberInfo;
+        public MemberInfo MemberInfo { get; }
 
 
         /*********
-- 
cgit