From 0a00c70397d85777499dcf7877cef08727a2dbae Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Fri, 20 Dec 2019 20:27:21 -0500
Subject: add console warning in paranoid mode

---
 src/SMAPI/Framework/ModLoading/AssemblyLoader.cs          | 5 +++++
 src/SMAPI/Framework/ModLoading/InstructionHandleResult.cs | 3 +++
 2 files changed, 8 insertions(+)

(limited to 'src/SMAPI/Framework/ModLoading')

diff --git a/src/SMAPI/Framework/ModLoading/AssemblyLoader.cs b/src/SMAPI/Framework/ModLoading/AssemblyLoader.cs
index 7670eb3a..b5533335 100644
--- a/src/SMAPI/Framework/ModLoading/AssemblyLoader.cs
+++ b/src/SMAPI/Framework/ModLoading/AssemblyLoader.cs
@@ -356,6 +356,11 @@ namespace StardewModdingAPI.Framework.ModLoading
                     mod.SetWarning(ModWarning.UsesDynamic);
                     break;
 
+                case InstructionHandleResult.DetectedConsoleAccess:
+                    this.Monitor.LogOnce(loggedMessages, $"{logPrefix}Detected direct console access ({handler.NounPhrase}) in assembly {filename}.");
+                    mod.SetWarning(ModWarning.AccessesConsole);
+                    break;
+
                 case InstructionHandleResult.DetectedFilesystemAccess:
                     this.Monitor.LogOnce(loggedMessages, $"{logPrefix}Detected filesystem access ({handler.NounPhrase}) in assembly {filename}.");
                     mod.SetWarning(ModWarning.AccessesFilesystem);
diff --git a/src/SMAPI/Framework/ModLoading/InstructionHandleResult.cs b/src/SMAPI/Framework/ModLoading/InstructionHandleResult.cs
index d93b603d..a948213b 100644
--- a/src/SMAPI/Framework/ModLoading/InstructionHandleResult.cs
+++ b/src/SMAPI/Framework/ModLoading/InstructionHandleResult.cs
@@ -26,6 +26,9 @@ namespace StardewModdingAPI.Framework.ModLoading
         /// <summary>The instruction is compatible, but references <see cref="ISpecializedEvents.UnvalidatedUpdateTicking"/> or <see cref="ISpecializedEvents.UnvalidatedUpdateTicked"/> which may impact stability.</summary>
         DetectedUnvalidatedUpdateTick,
 
+        /// <summary>The instruction accesses the SMAPI console directly.</summary>
+        DetectedConsoleAccess,
+
         /// <summary>The instruction accesses the filesystem directly.</summary>
         DetectedFilesystemAccess,
 
-- 
cgit 


From d932a11f51392cd42ab501185982af971f954c8d Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Tue, 24 Dec 2019 13:51:21 -0500
Subject: list broken dependencies first in 'skipped mods' list

---
 src/SMAPI/Framework/ModLoading/ModMetadata.cs | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

(limited to 'src/SMAPI/Framework/ModLoading')

diff --git a/src/SMAPI/Framework/ModLoading/ModMetadata.cs b/src/SMAPI/Framework/ModLoading/ModMetadata.cs
index 7f788d17..0e90362e 100644
--- a/src/SMAPI/Framework/ModLoading/ModMetadata.cs
+++ b/src/SMAPI/Framework/ModLoading/ModMetadata.cs
@@ -188,6 +188,27 @@ namespace StardewModdingAPI.Framework.ModLoading
             }
         }
 
+        /// <summary>Get the mod IDs that must be installed to load this mod.</summary>
+        /// <param name="includeOptional">Whether to include optional dependencies.</param>
+        public IEnumerable<string> GetRequiredModIds(bool includeOptional = false)
+        {
+            HashSet<string> required = new HashSet<string>(StringComparer.InvariantCultureIgnoreCase);
+
+            // yield dependencies
+            if (this.Manifest?.Dependencies != null)
+            {
+                foreach (var entry in this.Manifest?.Dependencies)
+                {
+                    if ((entry.IsRequired || includeOptional) && required.Add(entry.UniqueID))
+                        yield return entry.UniqueID;
+                }
+            }
+
+            // yield content pack parent
+            if (this.Manifest?.ContentPackFor?.UniqueID != null && required.Add(this.Manifest.ContentPackFor.UniqueID))
+                yield return this.Manifest.ContentPackFor.UniqueID;
+        }
+
         /// <summary>Whether the mod has at least one valid update key set.</summary>
         public bool HasValidUpdateKeys()
         {
-- 
cgit