From 51a2c3991f3c76197afb21a42a30f2a91a7f9908 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <github@jplamondonw.com>
Date: Wed, 18 Oct 2017 16:47:32 -0400
Subject: simplify SelectiveStringEnumConverter implementation

---
 src/SMAPI/Framework/Serialisation/JsonHelper.cs    |  7 +++---
 .../Serialisation/SelectiveStringEnumConverter.cs  | 25 +++++-----------------
 2 files changed, 9 insertions(+), 23 deletions(-)

(limited to 'src/SMAPI/Framework/Serialisation')

diff --git a/src/SMAPI/Framework/Serialisation/JsonHelper.cs b/src/SMAPI/Framework/Serialisation/JsonHelper.cs
index 3193aa3c..77b93b66 100644
--- a/src/SMAPI/Framework/Serialisation/JsonHelper.cs
+++ b/src/SMAPI/Framework/Serialisation/JsonHelper.cs
@@ -1,9 +1,8 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using Microsoft.Xna.Framework.Input;
 using Newtonsoft.Json;
-using StardewModdingAPI.Utilities;
 
 namespace StardewModdingAPI.Framework.Serialisation
 {
@@ -20,7 +19,9 @@ namespace StardewModdingAPI.Framework.Serialisation
             ObjectCreationHandling = ObjectCreationHandling.Replace, // avoid issue where default ICollection<T> values are duplicated each time the config is loaded
             Converters = new List<JsonConverter>
             {
-                new SelectiveStringEnumConverter(typeof(Buttons), typeof(Keys), typeof(SButton))
+                new SelectiveStringEnumConverter<Buttons>(),
+                new SelectiveStringEnumConverter<Keys>(),
+                new SelectiveStringEnumConverter<SButton>()
             }
         };
 
diff --git a/src/SMAPI/Framework/Serialisation/SelectiveStringEnumConverter.cs b/src/SMAPI/Framework/Serialisation/SelectiveStringEnumConverter.cs
index 37108556..e825c880 100644
--- a/src/SMAPI/Framework/Serialisation/SelectiveStringEnumConverter.cs
+++ b/src/SMAPI/Framework/Serialisation/SelectiveStringEnumConverter.cs
@@ -1,37 +1,22 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
+using System;
 using Newtonsoft.Json.Converters;
 
 namespace StardewModdingAPI.Framework.Serialisation
 {
-    /// <summary>A variant of <see cref="StringEnumConverter"/> which only converts certain enums.</summary>
-    internal class SelectiveStringEnumConverter : StringEnumConverter
+    /// <summary>A variant of <see cref="StringEnumConverter"/> which only converts a specified enum.</summary>
+    /// <typeparam name="T">The enum type.</typeparam>
+    internal class SelectiveStringEnumConverter<T> : StringEnumConverter
     {
-        /*********
-        ** Properties
-        *********/
-        /// <summary>The enum type names to convert.</summary>
-        private readonly HashSet<string> Types;
-
-
         /*********
         ** Public methods
         *********/
-        /// <summary>Construct an instance.</summary>
-        /// <param name="types">The enum types to convert.</param>
-        public SelectiveStringEnumConverter(params Type[] types)
-        {
-            this.Types = new HashSet<string>(types.Select(p => p.FullName));
-        }
-
         /// <summary>Get whether this instance can convert the specified object type.</summary>
         /// <param name="type">The object type.</param>
         public override bool CanConvert(Type type)
         {
             return
                 base.CanConvert(type)
-                && this.Types.Contains((Nullable.GetUnderlyingType(type) ?? type).FullName);
+                && (Nullable.GetUnderlyingType(type) ?? type) == typeof(T);
         }
     }
 }
-- 
cgit 


From a4fb2331fe57102aa8e8b30efb8095a1edb6b923 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <github@jplamondonw.com>
Date: Wed, 18 Oct 2017 16:58:42 -0400
Subject: simplify JSON converter name

---
 src/SMAPI/Framework/Serialisation/JsonHelper.cs    |  6 +++---
 .../Serialisation/SelectiveStringEnumConverter.cs  | 22 ----------------------
 .../Framework/Serialisation/StringEnumConverter.cs | 22 ++++++++++++++++++++++
 src/SMAPI/StardewModdingAPI.csproj                 |  2 +-
 4 files changed, 26 insertions(+), 26 deletions(-)
 delete mode 100644 src/SMAPI/Framework/Serialisation/SelectiveStringEnumConverter.cs
 create mode 100644 src/SMAPI/Framework/Serialisation/StringEnumConverter.cs

(limited to 'src/SMAPI/Framework/Serialisation')

diff --git a/src/SMAPI/Framework/Serialisation/JsonHelper.cs b/src/SMAPI/Framework/Serialisation/JsonHelper.cs
index 77b93b66..d923ec0c 100644
--- a/src/SMAPI/Framework/Serialisation/JsonHelper.cs
+++ b/src/SMAPI/Framework/Serialisation/JsonHelper.cs
@@ -19,9 +19,9 @@ namespace StardewModdingAPI.Framework.Serialisation
             ObjectCreationHandling = ObjectCreationHandling.Replace, // avoid issue where default ICollection<T> values are duplicated each time the config is loaded
             Converters = new List<JsonConverter>
             {
-                new SelectiveStringEnumConverter<Buttons>(),
-                new SelectiveStringEnumConverter<Keys>(),
-                new SelectiveStringEnumConverter<SButton>()
+                new StringEnumConverter<Buttons>(),
+                new StringEnumConverter<Keys>(),
+                new StringEnumConverter<SButton>()
             }
         };
 
diff --git a/src/SMAPI/Framework/Serialisation/SelectiveStringEnumConverter.cs b/src/SMAPI/Framework/Serialisation/SelectiveStringEnumConverter.cs
deleted file mode 100644
index e825c880..00000000
--- a/src/SMAPI/Framework/Serialisation/SelectiveStringEnumConverter.cs
+++ /dev/null
@@ -1,22 +0,0 @@
-using System;
-using Newtonsoft.Json.Converters;
-
-namespace StardewModdingAPI.Framework.Serialisation
-{
-    /// <summary>A variant of <see cref="StringEnumConverter"/> which only converts a specified enum.</summary>
-    /// <typeparam name="T">The enum type.</typeparam>
-    internal class SelectiveStringEnumConverter<T> : StringEnumConverter
-    {
-        /*********
-        ** Public methods
-        *********/
-        /// <summary>Get whether this instance can convert the specified object type.</summary>
-        /// <param name="type">The object type.</param>
-        public override bool CanConvert(Type type)
-        {
-            return
-                base.CanConvert(type)
-                && (Nullable.GetUnderlyingType(type) ?? type) == typeof(T);
-        }
-    }
-}
diff --git a/src/SMAPI/Framework/Serialisation/StringEnumConverter.cs b/src/SMAPI/Framework/Serialisation/StringEnumConverter.cs
new file mode 100644
index 00000000..7afe86cd
--- /dev/null
+++ b/src/SMAPI/Framework/Serialisation/StringEnumConverter.cs
@@ -0,0 +1,22 @@
+using System;
+using Newtonsoft.Json.Converters;
+
+namespace StardewModdingAPI.Framework.Serialisation
+{
+    /// <summary>A variant of <see cref="StringEnumConverter"/> which only converts a specified enum.</summary>
+    /// <typeparam name="T">The enum type.</typeparam>
+    internal class StringEnumConverter<T> : StringEnumConverter
+    {
+        /*********
+        ** Public methods
+        *********/
+        /// <summary>Get whether this instance can convert the specified object type.</summary>
+        /// <param name="type">The object type.</param>
+        public override bool CanConvert(Type type)
+        {
+            return
+                base.CanConvert(type)
+                && (Nullable.GetUnderlyingType(type) ?? type) == typeof(T);
+        }
+    }
+}
diff --git a/src/SMAPI/StardewModdingAPI.csproj b/src/SMAPI/StardewModdingAPI.csproj
index b8d5990e..6f7c2b3f 100644
--- a/src/SMAPI/StardewModdingAPI.csproj
+++ b/src/SMAPI/StardewModdingAPI.csproj
@@ -173,7 +173,7 @@
     <Compile Include="Framework\SContentManager.cs" />
     <Compile Include="Framework\Exceptions\SParseException.cs" />
     <Compile Include="Framework\Serialisation\JsonHelper.cs" />
-    <Compile Include="Framework\Serialisation\SelectiveStringEnumConverter.cs" />
+    <Compile Include="Framework\Serialisation\StringEnumConverter.cs" />
     <Compile Include="Framework\Serialisation\SFieldConverter.cs" />
     <Compile Include="IAssetEditor.cs" />
     <Compile Include="IAssetInfo.cs" />
-- 
cgit