From 2e7c233f6c9bf6430672b39f970a3324deba79dd Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Wed, 6 Apr 2022 21:48:55 -0400
Subject: enable nullable annotations by default (#837)

This adds `#nullable disable` to all existing code (except where null is impossible like enum files), so it can be migrated incrementally.
---
 src/SMAPI/Patches/Game1Patcher.cs     | 2 ++
 src/SMAPI/Patches/TitleMenuPatcher.cs | 2 ++
 2 files changed, 4 insertions(+)

(limited to 'src/SMAPI/Patches')

diff --git a/src/SMAPI/Patches/Game1Patcher.cs b/src/SMAPI/Patches/Game1Patcher.cs
index 173a2055..c5d98e9e 100644
--- a/src/SMAPI/Patches/Game1Patcher.cs
+++ b/src/SMAPI/Patches/Game1Patcher.cs
@@ -1,3 +1,5 @@
+#nullable disable
+
 using System;
 using System.Diagnostics.CodeAnalysis;
 using HarmonyLib;
diff --git a/src/SMAPI/Patches/TitleMenuPatcher.cs b/src/SMAPI/Patches/TitleMenuPatcher.cs
index b4320ce0..56e5597c 100644
--- a/src/SMAPI/Patches/TitleMenuPatcher.cs
+++ b/src/SMAPI/Patches/TitleMenuPatcher.cs
@@ -1,3 +1,5 @@
+#nullable disable
+
 using System;
 using System.Diagnostics.CodeAnalysis;
 using HarmonyLib;
-- 
cgit 


From f39da383a17b368e92fd243cf155b27ba42671f3 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Wed, 13 Apr 2022 20:24:14 -0400
Subject: enable nullable annotations in SMAPI where no logic changes are
 needed (#837)

---
 src/SMAPI/Patches/Game1Patcher.cs     | 6 ++----
 src/SMAPI/Patches/TitleMenuPatcher.cs | 4 +---
 2 files changed, 3 insertions(+), 7 deletions(-)

(limited to 'src/SMAPI/Patches')

diff --git a/src/SMAPI/Patches/Game1Patcher.cs b/src/SMAPI/Patches/Game1Patcher.cs
index c5d98e9e..8f806790 100644
--- a/src/SMAPI/Patches/Game1Patcher.cs
+++ b/src/SMAPI/Patches/Game1Patcher.cs
@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Diagnostics.CodeAnalysis;
 using HarmonyLib;
@@ -22,10 +20,10 @@ namespace StardewModdingAPI.Patches
         ** Fields
         *********/
         /// <summary>Simplifies access to private code.</summary>
-        private static Reflector Reflection;
+        private static Reflector Reflection = null!; // initialized in constructor
 
         /// <summary>A callback to invoke when the load stage changes.</summary>
-        private static Action<LoadStage> OnStageChanged;
+        private static Action<LoadStage> OnStageChanged = null!; // initialized in constructor
 
         /// <summary>Whether the game is running running the code in <see cref="Game1.loadForNewGame"/>.</summary>
         private static bool IsInLoadForNewGame;
diff --git a/src/SMAPI/Patches/TitleMenuPatcher.cs b/src/SMAPI/Patches/TitleMenuPatcher.cs
index 56e5597c..18f1a830 100644
--- a/src/SMAPI/Patches/TitleMenuPatcher.cs
+++ b/src/SMAPI/Patches/TitleMenuPatcher.cs
@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Diagnostics.CodeAnalysis;
 using HarmonyLib;
@@ -19,7 +17,7 @@ namespace StardewModdingAPI.Patches
         ** Fields
         *********/
         /// <summary>A callback to invoke when the load stage changes.</summary>
-        private static Action<LoadStage> OnStageChanged;
+        private static Action<LoadStage> OnStageChanged = null!; // initialized in constructor
 
 
         /*********
-- 
cgit