From 5f85d89974c3f1974f8e3d372f12b1cac743cd3a Mon Sep 17 00:00:00 2001 From: Jesse Plamondon-Willard Date: Sun, 24 Sep 2017 02:15:28 -0400 Subject: handle common 'v' version prefix on GitHub (#336) --- .../Framework/ModRepositories/GitHubRepository.cs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'src/StardewModdingAPI.Web/Framework/ModRepositories/GitHubRepository.cs') diff --git a/src/StardewModdingAPI.Web/Framework/ModRepositories/GitHubRepository.cs b/src/StardewModdingAPI.Web/Framework/ModRepositories/GitHubRepository.cs index b08e8b4d..f794c605 100644 --- a/src/StardewModdingAPI.Web/Framework/ModRepositories/GitHubRepository.cs +++ b/src/StardewModdingAPI.Web/Framework/ModRepositories/GitHubRepository.cs @@ -55,11 +55,19 @@ namespace StardewModdingAPI.Web.Framework.ModRepositories { try { + // fetch data GitRelease release = await this.Client .GetAsync(string.Format(this.ReleaseUrlFormat, id)) .As(); - return new ModInfoModel(id, release.Tag, $"https://github.com/{id}/releases"); + // extract fields + string name = id; + string version = release.Tag; + if (version.StartsWith("v")) // common format on GitHub + version = version.Substring(1); + string url = $"https://github.com/{id}/releases"; + + return new ModInfoModel(name, version, url); } catch (Exception ex) { -- cgit