From 9b247b67f64af903fd610481e74dbe7175580b84 Mon Sep 17 00:00:00 2001 From: Jesse Plamondon-Willard Date: Sun, 24 Sep 2017 13:19:02 -0400 Subject: improve version normalising (#336, #361) --- .../Framework/ModRepositories/NexusRepository.cs | 23 ++++++++-------------- 1 file changed, 8 insertions(+), 15 deletions(-) (limited to 'src/StardewModdingAPI.Web/Framework/ModRepositories/NexusRepository.cs') diff --git a/src/StardewModdingAPI.Web/Framework/ModRepositories/NexusRepository.cs b/src/StardewModdingAPI.Web/Framework/ModRepositories/NexusRepository.cs index 6cf5b04a..e679b977 100644 --- a/src/StardewModdingAPI.Web/Framework/ModRepositories/NexusRepository.cs +++ b/src/StardewModdingAPI.Web/Framework/ModRepositories/NexusRepository.cs @@ -7,25 +7,18 @@ using StardewModdingAPI.Models; namespace StardewModdingAPI.Web.Framework.ModRepositories { /// An HTTP client for fetching mod metadata from Nexus Mods. - internal class NexusRepository : IModRepository + internal class NexusRepository : RepositoryBase { /********* ** Properties *********/ + /// The URL for a Nexus Mods API query excluding the base URL, where {0} is the mod ID. + private readonly string ModUrlFormat; + /// The underlying HTTP client. private readonly IClient Client; - /********* - ** Accessors - *********/ - /// The unique key for this vendor. - public string VendorKey { get; } - - /// The URL for a Nexus Mods API query excluding the base URL, where {0} is the mod ID. - public string ModUrlFormat { get; } - - /********* ** Public methods *********/ @@ -35,15 +28,15 @@ namespace StardewModdingAPI.Web.Framework.ModRepositories /// The base URL for the Nexus Mods API. /// The URL for a Nexus Mods API query excluding the , where {0} is the mod ID. public NexusRepository(string vendorKey, string userAgent, string baseUrl, string modUrlFormat) + : base(vendorKey) { - this.VendorKey = vendorKey; this.ModUrlFormat = modUrlFormat; this.Client = new FluentClient(baseUrl).SetUserAgent(userAgent); } /// Get metadata about a mod in the repository. /// The mod ID in this repository. - public async Task GetModInfoAsync(string id) + public override async Task GetModInfoAsync(string id) { try { @@ -52,7 +45,7 @@ namespace StardewModdingAPI.Web.Framework.ModRepositories .As(); return response != null - ? new ModInfoModel(response.Name, response.Version, response.Url) + ? new ModInfoModel(response.Name, this.NormaliseVersion(response.Version), response.Url) : new ModInfoModel("Found no mod with this ID."); } catch (Exception ex) @@ -62,7 +55,7 @@ namespace StardewModdingAPI.Web.Framework.ModRepositories } /// Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources. - public void Dispose() + public override void Dispose() { this.Client.Dispose(); } -- cgit