From ec19c85d66a10bbd41c7fabfd9ea858fe659e747 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <github@jplamondonw.com>
Date: Sun, 21 May 2017 18:22:21 -0400
Subject: reimplement event deprecation warnings to fix "unknown mod" warnings

---
 .../Framework/InternalExtensions.cs                | 38 ----------------------
 src/StardewModdingAPI/Framework/ModRegistry.cs     | 10 ------
 2 files changed, 48 deletions(-)

(limited to 'src/StardewModdingAPI/Framework')

diff --git a/src/StardewModdingAPI/Framework/InternalExtensions.cs b/src/StardewModdingAPI/Framework/InternalExtensions.cs
index cadf6598..b99d3798 100644
--- a/src/StardewModdingAPI/Framework/InternalExtensions.cs
+++ b/src/StardewModdingAPI/Framework/InternalExtensions.cs
@@ -10,23 +10,6 @@ namespace StardewModdingAPI.Framework
     /// <summary>Provides extension methods for SMAPI's internal use.</summary>
     internal static class InternalExtensions
     {
-        /*********
-        ** Properties
-        *********/
-        /// <summary>Tracks the installed mods.</summary>
-        private static ModRegistry ModRegistry;
-
-
-        /*********
-        ** Public methods
-        *********/
-        /// <summary>Injects types required for backwards compatibility.</summary>
-        /// <param name="modRegistry">Tracks the installed mods.</param>
-        internal static void Shim(ModRegistry modRegistry)
-        {
-            InternalExtensions.ModRegistry = modRegistry;
-        }
-
         /****
         ** IMonitor
         ****/
@@ -110,27 +93,6 @@ namespace StardewModdingAPI.Framework
             }
         }
 
-        /****
-        ** Deprecation
-        ****/
-        /// <summary>Log a deprecation warning for mods using an event.</summary>
-        /// <param name="deprecationManager">The deprecation manager to extend.</param>
-        /// <param name="handlers">The event handlers.</param>
-        /// <param name="nounPhrase">A noun phrase describing what is deprecated.</param>
-        /// <param name="version">The SMAPI version which deprecated it.</param>
-        /// <param name="severity">How deprecated the code is.</param>
-        public static void WarnForEvent(this DeprecationManager deprecationManager, Delegate[] handlers, string nounPhrase, string version, DeprecationLevel severity)
-        {
-            if (handlers == null || !handlers.Any())
-                return;
-
-            foreach (Delegate handler in handlers)
-            {
-                string modName = InternalExtensions.ModRegistry.GetModFrom(handler) ?? "an unknown mod"; // suppress stack trace for unknown mods, not helpful here
-                deprecationManager.Warn(modName, nounPhrase, version, severity);
-            }
-        }
-
         /****
         ** Sprite batch
         ****/
diff --git a/src/StardewModdingAPI/Framework/ModRegistry.cs b/src/StardewModdingAPI/Framework/ModRegistry.cs
index 62063fbd..f9d3cfbf 100644
--- a/src/StardewModdingAPI/Framework/ModRegistry.cs
+++ b/src/StardewModdingAPI/Framework/ModRegistry.cs
@@ -63,16 +63,6 @@ namespace StardewModdingAPI.Framework
             return (from mod in this.Mods select mod);
         }
 
-        /// <summary>Get the friendly mod name which handles a delegate.</summary>
-        /// <param name="delegate">The delegate to follow.</param>
-        /// <returns>Returns the mod name, or <c>null</c> if the delegate isn't implemented by a known mod.</returns>
-        public string GetModFrom(Delegate @delegate)
-        {
-            return @delegate?.Target != null
-                ? this.GetModFrom(@delegate.Target.GetType())
-                : null;
-        }
-
         /// <summary>Get the friendly mod name which defines a type.</summary>
         /// <param name="type">The type to check.</param>
         /// <returns>Returns the mod name, or <c>null</c> if the type isn't part of a known mod.</returns>
-- 
cgit