From a89531972dbe1b686a50512d51ea87a7a020f8bc Mon Sep 17 00:00:00 2001 From: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com> Date: Sat, 12 Oct 2024 07:47:33 +1100 Subject: Fix: Verify Changelog not adding comment describing problem (Maybe) (#2723) --- .github/workflows/pr-check.yml | 2 +- buildSrc/src/main/kotlin/skyhannibuildsystem/ChangelogVerification.kt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index cabb09c1d..3702088f8 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -46,7 +46,7 @@ jobs: github-token: ${{ secrets.GITHUB_TOKEN }} script: | const fs = require('fs'); - const test = fs.readFileSync('build/changelog_errors.txt', 'utf8'); + const test = fs.readFileSync('versions/1.8.9/build/changelog_errors.txt', 'utf8'); const commentBody = `${test}` github.rest.issues.createComment({ diff --git a/buildSrc/src/main/kotlin/skyhannibuildsystem/ChangelogVerification.kt b/buildSrc/src/main/kotlin/skyhannibuildsystem/ChangelogVerification.kt index 422a62cb1..8ac54d6fc 100644 --- a/buildSrc/src/main/kotlin/skyhannibuildsystem/ChangelogVerification.kt +++ b/buildSrc/src/main/kotlin/skyhannibuildsystem/ChangelogVerification.kt @@ -45,6 +45,7 @@ abstract class ChangelogVerification : DefaultTask() { // Export errors so that they can be listed in the PR comment val errorFile = File(outputDirectory.get().asFile, "changelog_errors.txt") + println("saved error file to: ${errorFile.path}") errorFile.appendText("I have detected some issues with your pull request:\n\n") -- cgit