From 26e6a755c002a56db415d9b219ffafefbe384537 Mon Sep 17 00:00:00 2001
From: Trương Hoàng Long <longtruong2411@gmail.com>
Date: Mon, 20 Jun 2022 12:48:27 +0200
Subject: Fix race condition in update notifyer

---
 src/main/java/me/xmrvizzy/skyblocker/utils/UpdateChecker.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/java/me/xmrvizzy/skyblocker/utils/UpdateChecker.java b/src/main/java/me/xmrvizzy/skyblocker/utils/UpdateChecker.java
index 8909b5a9..ec028347 100644
--- a/src/main/java/me/xmrvizzy/skyblocker/utils/UpdateChecker.java
+++ b/src/main/java/me/xmrvizzy/skyblocker/utils/UpdateChecker.java
@@ -23,7 +23,8 @@ public class UpdateChecker {
     public static Matcher matcher;
     public static VersionNumber localVersion = null;
     public static VersionNumber latestVersion = null;
-    public static boolean shouldUpdate(){
+
+    public static void checkVersion(){
         if (SkyblockerConfig.get().general.enableUpdateNotification){
             new Thread(() -> {
                 try{
@@ -47,18 +48,17 @@ public class UpdateChecker {
                 }
             }).start();
         }
-        return shouldUpdate;
     }
 
     public static void init(){
+        checkVersion();
         SkyblockEvents.JOIN.register(() -> {
-            if (shouldUpdate()) {
+            if (shouldUpdate) {
                 TranslatableText linkMessage = new TranslatableText("skyblocker.update.update_message");
                 TranslatableText linkMessageEnding = new TranslatableText("skyblocker.update.update_message_end");
                 TranslatableText link = new TranslatableText("skyblocker.update.update_link");
                 TranslatableText hoverText = new TranslatableText("skyblocker.update.hover_text");
                 linkMessage.append(link.styled(style -> style.withClickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, "https://modrinth.com/mod/skyblocker-liap/versions")).withHoverEvent(new HoverEvent(HoverEvent.Action.SHOW_TEXT, hoverText)))).append(linkMessageEnding);
-
                 MinecraftClient.getInstance().player.sendMessage(linkMessage, false);
             }
         });
-- 
cgit