From 42ef60f1405a36bcf1b58043f4b69d8be4326e22 Mon Sep 17 00:00:00 2001 From: Kevinthegreat <92656833+kevinthegreat1@users.noreply.github.com> Date: Wed, 29 Mar 2023 14:17:09 -0400 Subject: Updated to 1.19.4 --- gradle.properties | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/gradle.properties b/gradle.properties index f1ea4278..2c92eebb 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1,25 +1,20 @@ org.gradle.jvmargs=-Xmx1G -Dfile.encoding=UTF-8 -Duser.language=en -Duser.country=US # Fabric Properties (https://fabricmc.net/versions.html) -## 1.19.3 -minecraft_version=1.19.3 -yarn_mappings=1.19.3+build.5 -## 1.19.2 -#minecraft_version=1.19.2 -#yarn_mappings=1.19.2+build.28 -loader_version=0.14.12 +## 1.19.4 +minecraft_version=1.19.4 +yarn_mappings=1.19.4+build.1 +loader_version=0.14.18 #Fabric api ## 1.19.3 -fabric_version=0.72.0+1.19.3 -## 1.19.2 -#fabric_version=0.72.0+1.19.2 +fabric_version=0.76.0+1.19.4 # Dependencies ## Cloth Api (https://www.curseforge.com/minecraft/mc-mods/cloth-config/files) clothconfig_version=9.0.94 ## Mod Menu (https://www.curseforge.com/minecraft/mc-mods/modmenu/files) -mod_menu_version=5.0.2 +mod_menu_version=6.1.0-rc.4 # Mod Properties mod_version = 1.8.3-beta -- cgit From 6d0352847755bc2b6950430623340bdf73dbfc3c Mon Sep 17 00:00:00 2001 From: Kevinthegreat <92656833+kevinthegreat1@users.noreply.github.com> Date: Wed, 29 Mar 2023 14:17:43 -0400 Subject: Merged supported_version into minecraft_version --- build.gradle | 4 ++-- gradle.properties | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/build.gradle b/build.gradle index 3e80b24a..d5a326c9 100644 --- a/build.gradle +++ b/build.gradle @@ -10,7 +10,7 @@ sourceCompatibility = JavaVersion.VERSION_17 targetCompatibility = JavaVersion.VERSION_17 archivesBaseName = project.archives_base_name -version = "${project.mod_version}+${project.suported_version}" +version = "${project.mod_version}+${project.minecraft_version}" group = project.maven_group repositories { @@ -103,7 +103,7 @@ modrinth { token = System.getenv('MODRINTH_TOKEN') projectId = project.modrinth_id versionNumber = "v${project.version}" - versionName = "Skyblocker ${project.mod_version} for ${project.suported_version}" + versionName = "Skyblocker ${project.mod_version} for ${project.minecraft_version}" uploadFile = remapJar gameVersions = ["1.19", "1.19.1", project.minecraft_version] loaders = ["fabric"] diff --git a/gradle.properties b/gradle.properties index 2c92eebb..a25f58e1 100644 --- a/gradle.properties +++ b/gradle.properties @@ -20,5 +20,4 @@ mod_menu_version=6.1.0-rc.4 mod_version = 1.8.3-beta maven_group = me.xmrvizzy archives_base_name = skyblocker -modrinth_id=y6DuFGwJ -suported_version=1.19.3 \ No newline at end of file +modrinth_id=y6DuFGwJ \ No newline at end of file -- cgit From ddb9e0b91bf50a93c4964e407c965f327b1d5307 Mon Sep 17 00:00:00 2001 From: Kevinthegreat <92656833+kevinthegreat1@users.noreply.github.com> Date: Wed, 29 Mar 2023 14:45:53 -0400 Subject: Support for 1.19.4 --- .../skyblocker/mixin/ItemRendererMixin.java | 22 ++++------ .../skyblocker/skyblock/BackpackPreview.java | 51 ++++++++++++++-------- .../skyblock/dwarven/DwarvenHudConfigScreen.java | 2 +- .../skyblock/itemlist/ResultButtonWidget.java | 4 +- .../skyblock/quicknav/QuickNavButton.java | 8 ++-- .../me/xmrvizzy/skyblocker/utils/RenderUtils.java | 2 - .../skyblocker/utils/RenderUtilsLiving.java | 28 +++++------- 7 files changed, 60 insertions(+), 57 deletions(-) diff --git a/src/main/java/me/xmrvizzy/skyblocker/mixin/ItemRendererMixin.java b/src/main/java/me/xmrvizzy/skyblocker/mixin/ItemRendererMixin.java index 395027bc..1de2617b 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/mixin/ItemRendererMixin.java +++ b/src/main/java/me/xmrvizzy/skyblocker/mixin/ItemRendererMixin.java @@ -5,15 +5,14 @@ import me.xmrvizzy.skyblocker.config.SkyblockerConfig; import me.xmrvizzy.skyblocker.utils.ItemUtils; import me.xmrvizzy.skyblocker.utils.Utils; import net.minecraft.client.font.TextRenderer; -import net.minecraft.client.render.BufferBuilder; -import net.minecraft.client.render.Tessellator; +import net.minecraft.client.gui.DrawableHelper; import net.minecraft.client.render.item.ItemRenderer; +import net.minecraft.client.util.math.MatrixStack; import net.minecraft.item.ItemStack; import net.minecraft.nbt.NbtCompound; import net.minecraft.util.math.MathHelper; import org.jetbrains.annotations.Nullable; import org.spongepowered.asm.mixin.Mixin; -import org.spongepowered.asm.mixin.Shadow; import org.spongepowered.asm.mixin.injection.At; import org.spongepowered.asm.mixin.injection.Inject; import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; @@ -22,11 +21,8 @@ import java.util.regex.Pattern; @Mixin(ItemRenderer.class) public abstract class ItemRendererMixin { - - @Shadow protected abstract void renderGuiQuad(BufferBuilder buffer, int x, int y, int width, int height, int red, int green, int blue, int alpha); - - @Inject(method = "renderGuiItemOverlay(Lnet/minecraft/client/font/TextRenderer;Lnet/minecraft/item/ItemStack;IILjava/lang/String;)V", at = @At("HEAD")) - public void renderItemBar(TextRenderer renderer, ItemStack stack, int x, int y, @Nullable String countLabel, CallbackInfo ci) { + @Inject(method = "renderGuiItemOverlay(Lnet/minecraft/client/util/math/MatrixStack;Lnet/minecraft/client/font/TextRenderer;Lnet/minecraft/item/ItemStack;IILjava/lang/String;)V", at = @At("HEAD")) + public void renderItemBar(MatrixStack matrices, TextRenderer renderer, ItemStack stack, int x, int y, @Nullable String countLabel, CallbackInfo ci) { if (Utils.isOnSkyblock && SkyblockerConfig.get().locations.dwarvenMines.enableDrillFuel) { if (!stack.isEmpty()) { @@ -47,19 +43,17 @@ public abstract class ItemRendererMixin { } RenderSystem.disableDepthTest(); - RenderSystem.disableTexture(); +// RenderSystem.disableTexture(); // RenderSystem.disableAlphaTest(); RenderSystem.disableBlend(); - Tessellator tessellator = Tessellator.getInstance(); - BufferBuilder buffer = tessellator.getBuffer(); float hue = Math.max(0.0F, 1.0F - (max - current) / max); int width = Math.round(current / max * 13.0F); int rgb = MathHelper.hsvToRgb(hue / 3.0F, 1.0F, 1.0F); - this.renderGuiQuad(buffer, x + 2, y + 13, 13, 2, 0,0,0,255); - this.renderGuiQuad(buffer, x + 2, y + 13, width, 1, rgb >> 16 & 255, rgb >> 8 & 255, rgb & 255, 255); + DrawableHelper.fill(matrices, x + 2, y + 13, x + 15, y + 15, 0xFF000000); + DrawableHelper.fill(matrices, x + 2, y + 13, x + 2 + width, y + 14, rgb); RenderSystem.enableBlend(); // RenderSystem.enableAlphaTest(); - RenderSystem.enableTexture(); +// RenderSystem.enableTexture(); RenderSystem.enableDepthTest(); } } diff --git a/src/main/java/me/xmrvizzy/skyblocker/skyblock/BackpackPreview.java b/src/main/java/me/xmrvizzy/skyblocker/skyblock/BackpackPreview.java index de4a25b6..29b8dd79 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/skyblock/BackpackPreview.java +++ b/src/main/java/me/xmrvizzy/skyblocker/skyblock/BackpackPreview.java @@ -68,7 +68,7 @@ public class BackpackPreview extends DrawableHelper { } public static void loadStorage() { - assert(save_dir != null); + assert (save_dir != null); for (int index = 0; index < STORAGE_SIZE; ++index) { storage[index] = null; dirty[index] = false; @@ -85,7 +85,7 @@ public class BackpackPreview extends DrawableHelper { } private static void saveStorage() { - assert(save_dir != null); + assert (save_dir != null); for (int index = 0; index < STORAGE_SIZE; ++index) { if (dirty[index]) { if (storage[index] != null) { @@ -121,7 +121,7 @@ public class BackpackPreview extends DrawableHelper { String title = screen.getTitle().getString(); int index = getStorageIndexFromTitle(title); if (index != -1) { - storage[index] = ((HandledScreen)screen).getScreenHandler().slots.get(0).inventory; + storage[index] = ((HandledScreen) screen).getScreenHandler().slots.get(0).inventory; dirty[index] = true; } } @@ -151,10 +151,11 @@ public class BackpackPreview extends DrawableHelper { for (int i = 9; i < storage[index].size(); ++i) { int itemX = x + (i - 9) % 9 * 18 + 8; int itemY = y + (i - 9) / 9 * 18 + 8; - itemRenderer.zOffset = 200.0F; - itemRenderer.renderInGui(storage[index].getStack(i), itemX, itemY); - itemRenderer.renderGuiItemOverlay(textRenderer, storage[index].getStack(i), itemX, itemY); - itemRenderer.zOffset = 0.0F; + matrices.push(); + matrices.translate(0, 0, 200); + itemRenderer.renderInGui(matrices, storage[index].getStack(i), itemX, itemY); + itemRenderer.renderGuiItemOverlay(matrices, textRenderer, storage[index].getStack(i), itemX, itemY); + matrices.pop(); } return true; @@ -189,34 +190,50 @@ class DummyInventory implements Inventory { stacks = new ArrayList<>(root.getInt("size") + 9); for (int i = 0; i < 9; ++i) stacks.add(ItemStack.EMPTY); root.getList("list", NbtCompound.COMPOUND_TYPE).forEach(item -> - stacks.add(ItemStack.fromNbt((NbtCompound)item)) + stacks.add(ItemStack.fromNbt((NbtCompound) item)) ); } @Override - public int size() { return stacks.size(); } + public int size() { + return stacks.size(); + } @Override - public boolean isEmpty() { return false; } + public boolean isEmpty() { + return false; + } @Override - public ItemStack getStack(int slot) { return stacks.get(slot); } + public ItemStack getStack(int slot) { + return stacks.get(slot); + } @Override - public ItemStack removeStack(int slot, int amount) { return null; } + public ItemStack removeStack(int slot, int amount) { + return null; + } @Override - public ItemStack removeStack(int slot) { return null; } + public ItemStack removeStack(int slot) { + return null; + } @Override - public void setStack(int slot, ItemStack stack) { stacks.set(slot, stack); } + public void setStack(int slot, ItemStack stack) { + stacks.set(slot, stack); + } @Override - public void markDirty() {} + public void markDirty() { + } @Override - public boolean canPlayerUse(PlayerEntity player) { return false; } + public boolean canPlayerUse(PlayerEntity player) { + return false; + } @Override - public void clear() {} + public void clear() { + } } diff --git a/src/main/java/me/xmrvizzy/skyblocker/skyblock/dwarven/DwarvenHudConfigScreen.java b/src/main/java/me/xmrvizzy/skyblocker/skyblock/dwarven/DwarvenHudConfigScreen.java index 7dcb2b3b..2d0ba892 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/skyblock/dwarven/DwarvenHudConfigScreen.java +++ b/src/main/java/me/xmrvizzy/skyblocker/skyblock/dwarven/DwarvenHudConfigScreen.java @@ -23,7 +23,7 @@ public class DwarvenHudConfigScreen extends Screen { super.render(matrices, mouseX, mouseY, delta); renderBackground(matrices); DwarvenHud.render(matrices, hudX, hudY, List.of(new DwarvenHud.Commission("Test Commission 1", "1%"), new DwarvenHud.Commission("Test Commission 2", "2%"))); - drawCenteredText(matrices, textRenderer, "Right Click To Reset Position", width / 2, height / 2, Color.GRAY.getRGB()); + drawCenteredTextWithShadow(matrices, textRenderer, "Right Click To Reset Position", width / 2, height / 2, Color.GRAY.getRGB()); } @Override diff --git a/src/main/java/me/xmrvizzy/skyblocker/skyblock/itemlist/ResultButtonWidget.java b/src/main/java/me/xmrvizzy/skyblocker/skyblock/itemlist/ResultButtonWidget.java index 6d0d89e1..3d6409ef 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/skyblock/itemlist/ResultButtonWidget.java +++ b/src/main/java/me/xmrvizzy/skyblocker/skyblock/itemlist/ResultButtonWidget.java @@ -42,9 +42,9 @@ public class ResultButtonWidget extends ClickableWidget { // this.drawTexture(matrices, this.x, this.y, 29, 206, this.width, this.height); this.drawTexture(matrices, this.getX(), this.getY(), 29, 206, this.getWidth(), this.getHeight()); // client.getItemRenderer().renderInGui(this.itemStack, this.x + 4, this.y + 4); - client.getItemRenderer().renderInGui(this.itemStack, this.getX() + 4, this.getY() + 4); + client.getItemRenderer().renderInGui(matrices, this.itemStack, this.getX() + 4, this.getY() + 4); // client.getItemRenderer().renderGuiItemOverlay(client.textRenderer, itemStack, this.x + 4, this.y + 4); - client.getItemRenderer().renderGuiItemOverlay(client.textRenderer, itemStack, this.getX() + 4, this.getY() + 4); + client.getItemRenderer().renderGuiItemOverlay(matrices, client.textRenderer, itemStack, this.getX() + 4, this.getY() + 4); } public void renderTooltip(MatrixStack matrices, int mouseX, int mouseY) { diff --git a/src/main/java/me/xmrvizzy/skyblocker/skyblock/quicknav/QuickNavButton.java b/src/main/java/me/xmrvizzy/skyblocker/skyblock/quicknav/QuickNavButton.java index f35e60b2..ef0f2d06 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/skyblock/quicknav/QuickNavButton.java +++ b/src/main/java/me/xmrvizzy/skyblocker/skyblock/quicknav/QuickNavButton.java @@ -87,17 +87,17 @@ public class QuickNavButton extends ClickableWidget { if (!this.toggled) { if (this.index >= 6) // CLIENT.getItemRenderer().renderInGui(this.icon,this.x + 6, this.y + 6); - CLIENT.getItemRenderer().renderInGui(this.icon,this.getX() + 5, this.getY() + 6); + CLIENT.getItemRenderer().renderInGui(matrices, this.icon,this.getX() + 5, this.getY() + 6); else // CLIENT.getItemRenderer().renderInGui(this.icon,this.x + 6, this.y + 9); - CLIENT.getItemRenderer().renderInGui(this.icon,this.getX() + 5, this.getY() + 7); + CLIENT.getItemRenderer().renderInGui(matrices, this.icon,this.getX() + 5, this.getY() + 7); } else { if (this.index >= 6) // CLIENT.getItemRenderer().renderInGui(this.icon,this.x + 6, this.y + 9); - CLIENT.getItemRenderer().renderInGui(this.icon,this.getX() + 5, this.getY() + 9); + CLIENT.getItemRenderer().renderInGui(matrices, this.icon,this.getX() + 5, this.getY() + 9); else // CLIENT.getItemRenderer().renderInGui(this.icon,this.x + 6, this.y + 6); - CLIENT.getItemRenderer().renderInGui(this.icon,this.getX() + 5, this.getY() + 6); + CLIENT.getItemRenderer().renderInGui(matrices, this.icon,this.getX() + 5, this.getY() + 6); } RenderSystem.enableDepthTest(); } diff --git a/src/main/java/me/xmrvizzy/skyblocker/utils/RenderUtils.java b/src/main/java/me/xmrvizzy/skyblocker/utils/RenderUtils.java index 0f2f3aef..1f8e2552 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/utils/RenderUtils.java +++ b/src/main/java/me/xmrvizzy/skyblocker/utils/RenderUtils.java @@ -89,11 +89,9 @@ public class RenderUtils { public static void setup() { RenderSystem.enableBlend(); RenderSystem.defaultBlendFunc(); - RenderSystem.disableTexture(); } public static void cleanup() { RenderSystem.disableBlend(); - RenderSystem.enableTexture(); } } \ No newline at end of file diff --git a/src/main/java/me/xmrvizzy/skyblocker/utils/RenderUtilsLiving.java b/src/main/java/me/xmrvizzy/skyblocker/utils/RenderUtilsLiving.java index 651ef2bd..79ec18e9 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/utils/RenderUtilsLiving.java +++ b/src/main/java/me/xmrvizzy/skyblocker/utils/RenderUtilsLiving.java @@ -19,26 +19,20 @@ package me.xmrvizzy.skyblocker.utils; */ -import java.lang.reflect.Field; - -import org.apache.commons.lang3.reflect.FieldUtils; - import com.mojang.blaze3d.systems.RenderSystem; - import net.minecraft.client.MinecraftClient; -import net.minecraft.client.render.Camera; -import net.minecraft.client.render.DiffuseLighting; -import net.minecraft.client.render.OverlayTexture; -import net.minecraft.client.render.Tessellator; -import net.minecraft.client.render.VertexConsumerProvider; -import net.minecraft.client.render.model.json.ModelTransformation; +import net.minecraft.client.font.TextRenderer; +import net.minecraft.client.render.*; +import net.minecraft.client.render.model.json.ModelTransformationMode; import net.minecraft.client.util.math.MatrixStack; import net.minecraft.item.ItemStack; import net.minecraft.text.Text; -//import net.minecraft.util.math.Vec3f; import net.minecraft.util.math.RotationAxis; +import org.apache.commons.lang3.reflect.FieldUtils; import org.joml.Vector3f; +import java.lang.reflect.Field; + public class RenderUtilsLiving { private static final MinecraftClient mc = MinecraftClient.getInstance(); @@ -71,17 +65,17 @@ public class RenderUtilsLiving { if (fill) { int opacity = (int) (MinecraftClient.getInstance().options.getTextBackgroundOpacity(0.25F) * 255.0F) << 24; - mc.textRenderer.draw(text, -halfWidth, 0f, 553648127, false, matrices.peek().getPositionMatrix(), immediate, true, opacity, 0xf000f0); + mc.textRenderer.draw(text, -halfWidth, 0f, 553648127, false, matrices.peek().getPositionMatrix(), immediate, TextRenderer.TextLayerType.NORMAL, opacity, 0xf000f0); immediate.draw(); } else { matrices.push(); matrices.translate(1, 1, 0); - mc.textRenderer.draw(text.copyContentOnly(), -halfWidth, 0f, 0x202020, false, matrices.peek().getPositionMatrix(), immediate, true, 0, 0xf000f0); + mc.textRenderer.draw(text.copyContentOnly(), -halfWidth, 0f, 0x202020, false, matrices.peek().getPositionMatrix(), immediate, TextRenderer.TextLayerType.NORMAL, 0, 0xf000f0); immediate.draw(); matrices.pop(); } - mc.textRenderer.draw(text, -halfWidth, 0f, -1, false, matrices.peek().getPositionMatrix(), immediate, true, 0, 0xf000f0); + mc.textRenderer.draw(text, -halfWidth, 0f, -1, false, matrices.peek().getPositionMatrix(), immediate, TextRenderer.TextLayerType.NORMAL, 0, 0xf000f0); immediate.draw(); RenderSystem.disableBlend(); @@ -118,8 +112,8 @@ public class RenderUtilsLiving { mc.getBufferBuilders().getEntityVertexConsumers().draw(); - mc.getItemRenderer().renderItem(item, ModelTransformation.Mode.GUI, 0xF000F0, - OverlayTexture.DEFAULT_UV, matrices, mc.getBufferBuilders().getEntityVertexConsumers(), 0); + mc.getItemRenderer().renderItem(item, ModelTransformationMode.GUI, 0xF000F0, + OverlayTexture.DEFAULT_UV, matrices, mc.getBufferBuilders().getEntityVertexConsumers(), mc.world, 0); mc.getBufferBuilders().getEntityVertexConsumers().draw(); -- cgit From 62641e3600cc13fccddcd952e4aeb90ae2ebf5a7 Mon Sep 17 00:00:00 2001 From: Kevinthegreat <92656833+kevinthegreat1@users.noreply.github.com> Date: Wed, 29 Mar 2023 14:51:57 -0400 Subject: Updated minecraft requirement --- src/main/resources/fabric.mod.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/resources/fabric.mod.json b/src/main/resources/fabric.mod.json index 95426c72..5f5a7de4 100644 --- a/src/main/resources/fabric.mod.json +++ b/src/main/resources/fabric.mod.json @@ -28,8 +28,8 @@ "depends": { "fabricloader": ">=0.14.6", "fabric": "*", - "cloth-config2": "*", - "minecraft": ["1.19.3"] + "cloth-config2": "*", + "minecraft": ["1.19.4"] }, "custom": { "modmenu": { -- cgit From 08f3f6a515efebcea13c649828925f4ccf3759d8 Mon Sep 17 00:00:00 2001 From: Kevinthegreat <92656833+kevinthegreat1@users.noreply.github.com> Date: Wed, 29 Mar 2023 14:58:34 -0400 Subject: Fixed InGameHudMixin --- src/main/java/me/xmrvizzy/skyblocker/mixin/InGameHudMixin.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/me/xmrvizzy/skyblocker/mixin/InGameHudMixin.java b/src/main/java/me/xmrvizzy/skyblocker/mixin/InGameHudMixin.java index 7f25b339..60f4af53 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/mixin/InGameHudMixin.java +++ b/src/main/java/me/xmrvizzy/skyblocker/mixin/InGameHudMixin.java @@ -69,7 +69,7 @@ public abstract class InGameHudMixin extends DrawableHelper { } @Inject(method = "renderHotbarItem", at = @At("HEAD")) - public void renderHotbarItem(int i, int j, float f, PlayerEntity player, ItemStack stack, int seed, CallbackInfo ci) { + public void renderHotbarItem(MatrixStack matrices, int i, int j, float f, PlayerEntity player, ItemStack stack, int seed, CallbackInfo ci) { if (Utils.isOnSkyblock) { if (HotbarSlotLock.isLocked(hotbarSlotIndex)) { RenderSystem.setShaderTexture(0,SLOT_LOCK); -- cgit From 7d491f0351ba8d12f03a79339cea4c2d0d80a45a Mon Sep 17 00:00:00 2001 From: Kevinthegreat <92656833+kevinthegreat1@users.noreply.github.com> Date: Wed, 29 Mar 2023 14:58:45 -0400 Subject: Updated Cloth Config version --- gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gradle.properties b/gradle.properties index a25f58e1..6e34d59d 100644 --- a/gradle.properties +++ b/gradle.properties @@ -12,7 +12,7 @@ fabric_version=0.76.0+1.19.4 # Dependencies ## Cloth Api (https://www.curseforge.com/minecraft/mc-mods/cloth-config/files) -clothconfig_version=9.0.94 +clothconfig_version=10.0.96 ## Mod Menu (https://www.curseforge.com/minecraft/mc-mods/modmenu/files) mod_menu_version=6.1.0-rc.4 -- cgit From 43edaf777e2f6ae8a9ee004930c6bbfc4bfa1b55 Mon Sep 17 00:00:00 2001 From: Kevinthegreat <92656833+kevinthegreat1@users.noreply.github.com> Date: Wed, 29 Mar 2023 15:26:27 -0400 Subject: Cleaned up code --- README.md | 8 +- .../xmrvizzy/skyblocker/SkyblockerInitializer.java | 3 +- .../skyblocker/chat/ChatPatternListener.java | 2 +- .../skyblocker/chat/filters/AutopetFilter.java | 1 - .../skyblocker/config/SkyblockerConfig.java | 198 ++++++++++----------- .../skyblocker/mixin/HandledScreenMixin.java | 18 +- .../xmrvizzy/skyblocker/mixin/InGameHudMixin.java | 4 +- .../skyblocker/mixin/InventoryScreenMixin.java | 2 +- .../skyblocker/mixin/ItemRendererMixin.java | 4 - .../skyblocker/skyblock/BackpackPreview.java | 12 +- .../skyblocker/skyblock/FancyStatusBars.java | 1 - .../skyblocker/skyblock/api/ApiKeyListener.java | 2 +- .../skyblocker/skyblock/api/StatsCommand.java | 28 ++- .../skyblock/api/records/mining/Mining.java | 5 - .../skyblocker/skyblock/dungeon/OldLever.java | 12 +- .../skyblocker/skyblock/dungeon/Reparty.java | 23 +-- .../skyblocker/skyblock/dwarven/DwarvenHud.java | 6 +- .../skyblocker/skyblock/dwarven/Fetchur.java | 2 +- .../skyblocker/skyblock/item/PriceInfoTooltip.java | 2 - .../skyblocker/skyblock/item/WikiLookup.java | 2 +- .../skyblock/itemlist/ItemFixerUpper.java | 1 - .../skyblock/itemlist/ItemListWidget.java | 7 +- .../skyblocker/skyblock/itemlist/ItemRegistry.java | 8 +- .../skyblock/itemlist/ItemStackBuilder.java | 3 +- .../skyblock/itemlist/ResultButtonWidget.java | 3 +- .../skyblock/itemlist/SearchResultsWidget.java | 26 +-- .../skyblocker/skyblock/quicknav/QuickNav.java | 5 - .../skyblock/quicknav/QuickNavButton.java | 12 +- .../me/xmrvizzy/skyblocker/utils/RenderUtils.java | 2 +- .../me/xmrvizzy/skyblocker/utils/ToastBuilder.java | 4 +- .../xmrvizzy/skyblocker/utils/UpdateChecker.java | 4 +- .../xmrvizzy/skyblocker/utils/color/LineColor.java | 2 +- .../xmrvizzy/skyblocker/utils/color/QuadColor.java | 20 +-- .../skyblocker/chat/filters/ChatFilterTest.java | 3 - 34 files changed, 203 insertions(+), 232 deletions(-) diff --git a/README.md b/README.md index 2e1b59a3..b1137f37 100644 --- a/README.md +++ b/README.md @@ -31,7 +31,7 @@ Installation guide is [here](https://github.com/SkyblockerMod/Skyblocker/wiki/in * Wiki Lookup: press f4 to open the wiki page about the held item * Discord Rich Presence: Allows user to show either their Piggy, Bits, or location. Along with a custom message * Quicknav: fast navigate between pets, armor, enderchest, skill, collection, crafting, enchant, envil, warp dungeon, warp hub -* Recipe book: in the vanilla recipe book all skyblock items are listed and you can see the recipe of the item +* Recipe book: in the vanilla recipe book all skyblock items are listed, and you can see the recipe of the item * Backpack preview: after you clicked your backpack or enderchest once you can hover over the backpack or enderchest and hold shift to preview * Update notification * Commission HUD: Dwarven Mines quests @@ -67,16 +67,16 @@ Everyone can contribute to Skyblocker, read [this](https://github.com/Skyblocker | [Kraineff](https://github.com/Kraineff) | [d3dx9](https://github.com/d3dx9) | [LifeIsAParadox](https://github.com/LifeIsAParadox) | [ExternalTime](https://github.com/ExternalTime) | |:-------------------------------------------------------------------------------------------------------------:|:---------------------------------------------------------------------------------------------------------------------:|:-----------------------------------------------------------------------------------------------------------------------:|:-----------------------------------------------------------------------------------------------------------------:| -| [Kraineff](https://github.com/Kraineff) | [d3dx9](https://github.com/d3dx9) | [LifeIsAParadox](https://github.com/LifeIsAParadox) | [ExternalTime](https://github.com/ExternalTime) | +| [Kraineff](https://github.com/Kraineff) | [d3dx9](https://github.com/d3dx9) | [LifeIsAParadox](https://github.com/LifeIsAParadox) | [ExternalTime](https://github.com/ExternalTime) | | [Zailer43](https://github.com/Zailer43) | [TacoMonkey11](https://github.com/TacoMonkey11) | [KonaeAkira](https://github.com/KonaeAkira) | [Fix3dll](https://github.com/Fix3dll) | |:-----------------------------------------------------------------------------------------------------:|:-----------------------------------------------------------------------------------------------------------------:|:---------------------------------------------------------------------------------------------------------------:|:--------------------------------------------------------------------------------------------------:| -| [Zailer43](https://github.com/Zailer43) | [TacoMonkey11](https://github.com/TacoMonkey11) | [KonaeAkira](https://github.com/KonaeAkira) | [Fix3dll](https://github.com/Fix3dll) | +| [Zailer43](https://github.com/Zailer43) | [TacoMonkey11](https://github.com/TacoMonkey11) | [KonaeAkira](https://github.com/KonaeAkira) | [Fix3dll](https://github.com/Fix3dll) | | [Zailer43](https://github.com/ADON15c) | |:---------------------------------------------------------------------------------------------------:| -| [ADON15c](https://github.com/ADON15c) | +| [ADON15c](https://github.com/ADON15c) | ### Translators German ([LifeIsAParadox](https://github.com/LifeIsAParadox)) \ Indonesian ([null2264](https://github.com/null2264)) \ diff --git a/src/main/java/me/xmrvizzy/skyblocker/SkyblockerInitializer.java b/src/main/java/me/xmrvizzy/skyblocker/SkyblockerInitializer.java index e9af52f6..3d713727 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/SkyblockerInitializer.java +++ b/src/main/java/me/xmrvizzy/skyblocker/SkyblockerInitializer.java @@ -2,6 +2,7 @@ package me.xmrvizzy.skyblocker; import me.xmrvizzy.skyblocker.chat.ChatMessageListener; import me.xmrvizzy.skyblocker.config.SkyblockerConfig; +import me.xmrvizzy.skyblocker.discord.DiscordRPCManager; import me.xmrvizzy.skyblocker.skyblock.HotbarSlotLock; import me.xmrvizzy.skyblocker.skyblock.api.StatsCommand; import me.xmrvizzy.skyblocker.skyblock.dwarven.DwarvenHud; @@ -23,6 +24,6 @@ public class SkyblockerInitializer implements ClientModInitializer { DwarvenHud.init(); ChatMessageListener.init(); UpdateChecker.init(); - SkyblockerMod.getInstance().discordRPCManager.init(); + DiscordRPCManager.init(); } } diff --git a/src/main/java/me/xmrvizzy/skyblocker/chat/ChatPatternListener.java b/src/main/java/me/xmrvizzy/skyblocker/chat/ChatPatternListener.java index 19237de4..8a32715e 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/chat/ChatPatternListener.java +++ b/src/main/java/me/xmrvizzy/skyblocker/chat/ChatPatternListener.java @@ -6,7 +6,7 @@ import java.util.regex.Matcher; import java.util.regex.Pattern; public abstract class ChatPatternListener implements ChatMessageListener { - protected static String NUMBER = "-?[0-9]{1,3}(?>,[0-9]{3})*(?:\\.[1-9])?"; + protected static final String NUMBER = "-?[0-9]{1,3}(?>,[0-9]{3})*(?:\\.[1-9])?"; public final Pattern pattern; public ChatPatternListener(String pattern) { diff --git a/src/main/java/me/xmrvizzy/skyblocker/chat/filters/AutopetFilter.java b/src/main/java/me/xmrvizzy/skyblocker/chat/filters/AutopetFilter.java index f8af49ce..f1545db4 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/chat/filters/AutopetFilter.java +++ b/src/main/java/me/xmrvizzy/skyblocker/chat/filters/AutopetFilter.java @@ -4,7 +4,6 @@ import me.xmrvizzy.skyblocker.chat.ChatFilterResult; import me.xmrvizzy.skyblocker.chat.ChatPatternListener; import me.xmrvizzy.skyblocker.config.SkyblockerConfig; import net.minecraft.client.MinecraftClient; -import net.minecraft.text.LiteralTextContent; import net.minecraft.text.Text; import java.util.Objects; diff --git a/src/main/java/me/xmrvizzy/skyblocker/config/SkyblockerConfig.java b/src/main/java/me/xmrvizzy/skyblocker/config/SkyblockerConfig.java index e487c209..21322c81 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/config/SkyblockerConfig.java +++ b/src/main/java/me/xmrvizzy/skyblocker/config/SkyblockerConfig.java @@ -15,74 +15,74 @@ public class SkyblockerConfig implements ConfigData { @ConfigEntry.Category("general") @ConfigEntry.Gui.TransitiveObject - public General general = new General(); + public final General general = new General(); @ConfigEntry.Category("locations") @ConfigEntry.Gui.TransitiveObject - public Locations locations = new Locations(); + public final Locations locations = new Locations(); @ConfigEntry.Category("messages") @ConfigEntry.Gui.TransitiveObject - public Messages messages = new Messages(); + public final Messages messages = new Messages(); @ConfigEntry.Category("richPresence") @ConfigEntry.Gui.TransitiveObject - public RichPresence richPresence = new RichPresence(); + public final RichPresence richPresence = new RichPresence(); @ConfigEntry.Category("quickNav") @ConfigEntry.Gui.TransitiveObject - public QuickNav quickNav = new QuickNav(); + public final QuickNav quickNav = new QuickNav(); public static class QuickNav { - public boolean enableQuickNav = true; + public final boolean enableQuickNav = true; @ConfigEntry.Category("button1") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public QuickNavItem button1 = new QuickNavItem(true, new ItemData("diamond_sword"), "Your Skills", "/skills"); + @ConfigEntry.Gui.CollapsibleObject() + public final QuickNavItem button1 = new QuickNavItem(true, new ItemData("diamond_sword"), "Your Skills", "/skills"); @ConfigEntry.Category("button2") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public QuickNavItem button2 = new QuickNavItem(true, new ItemData("painting"), "Collection", "/collection"); + @ConfigEntry.Gui.CollapsibleObject() + public final QuickNavItem button2 = new QuickNavItem(true, new ItemData("painting"), "Collection", "/collection"); @ConfigEntry.Category("button3") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public QuickNavItem button3 = new QuickNavItem(false, new ItemData("air"), "", ""); + @ConfigEntry.Gui.CollapsibleObject() + public final QuickNavItem button3 = new QuickNavItem(false, new ItemData("air"), "", ""); @ConfigEntry.Category("button4") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public QuickNavItem button4 = new QuickNavItem(true, new ItemData("bone"), "Pets", "/pets"); + @ConfigEntry.Gui.CollapsibleObject() + public final QuickNavItem button4 = new QuickNavItem(true, new ItemData("bone"), "Pets", "/pets"); @ConfigEntry.Category("button5") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public QuickNavItem button5 = new QuickNavItem(true, new ItemData("leather_chestplate", 1, "tag:{display:{color:8991416}}"), "Wardrobe", "/wardrobe"); + @ConfigEntry.Gui.CollapsibleObject() + public final QuickNavItem button5 = new QuickNavItem(true, new ItemData("leather_chestplate", 1, "tag:{display:{color:8991416}}"), "Wardrobe", "/wardrobe"); @ConfigEntry.Category("button6") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public QuickNavItem button6 = new QuickNavItem(true, new ItemData("ender_chest"), "Storage", "/storage"); + @ConfigEntry.Gui.CollapsibleObject() + public final QuickNavItem button6 = new QuickNavItem(true, new ItemData("ender_chest"), "Storage", "/storage"); @ConfigEntry.Category("button7") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public QuickNavItem button7 = new QuickNavItem(true, new ItemData("player_head", 1, "tag:{SkullOwner:{Id:[I;-300151517,-631415889,-1193921967,-1821784279],Properties:{textures:[{Value:\"e3RleHR1cmVzOntTS0lOOnt1cmw6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvZDdjYzY2ODc0MjNkMDU3MGQ1NTZhYzUzZTA2NzZjYjU2M2JiZGQ5NzE3Y2Q4MjY5YmRlYmVkNmY2ZDRlN2JmOCJ9fX0=\"}]}}}"), "none", "/hub"); + @ConfigEntry.Gui.CollapsibleObject() + public final QuickNavItem button7 = new QuickNavItem(true, new ItemData("player_head", 1, "tag:{SkullOwner:{Id:[I;-300151517,-631415889,-1193921967,-1821784279],Properties:{textures:[{Value:\"e3RleHR1cmVzOntTS0lOOnt1cmw6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvZDdjYzY2ODc0MjNkMDU3MGQ1NTZhYzUzZTA2NzZjYjU2M2JiZGQ5NzE3Y2Q4MjY5YmRlYmVkNmY2ZDRlN2JmOCJ9fX0=\"}]}}}"), "none", "/hub"); @ConfigEntry.Category("button8") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public QuickNavItem button8 = new QuickNavItem(true, new ItemData("player_head", 1, "tag:{SkullOwner:{Id:[I;1605800870,415127827,-1236127084,15358548],Properties:{textures:[{Value:\"e3RleHR1cmVzOntTS0lOOnt1cmw6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvNzg5MWQ1YjI3M2ZmMGJjNTBjOTYwYjJjZDg2ZWVmMWM0MGExYjk0MDMyYWU3MWU3NTQ3NWE1NjhhODI1NzQyMSJ9fX0=\"}]}}}"), "none", "/warp dungeon_hub"); + @ConfigEntry.Gui.CollapsibleObject() + public final QuickNavItem button8 = new QuickNavItem(true, new ItemData("player_head", 1, "tag:{SkullOwner:{Id:[I;1605800870,415127827,-1236127084,15358548],Properties:{textures:[{Value:\"e3RleHR1cmVzOntTS0lOOnt1cmw6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvNzg5MWQ1YjI3M2ZmMGJjNTBjOTYwYjJjZDg2ZWVmMWM0MGExYjk0MDMyYWU3MWU3NTQ3NWE1NjhhODI1NzQyMSJ9fX0=\"}]}}}"), "none", "/warp dungeon_hub"); @ConfigEntry.Category("button9") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public QuickNavItem button9 = new QuickNavItem(false, new ItemData("air"), "", ""); + @ConfigEntry.Gui.CollapsibleObject() + public final QuickNavItem button9 = new QuickNavItem(false, new ItemData("air"), "", ""); @ConfigEntry.Category("button10") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public QuickNavItem button10 = new QuickNavItem(true, new ItemData("enchanting_table"), "Enchant", "/etable"); + @ConfigEntry.Gui.CollapsibleObject() + public final QuickNavItem button10 = new QuickNavItem(true, new ItemData("enchanting_table"), "Enchant", "/etable"); @ConfigEntry.Category("button11") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public QuickNavItem button11 = new QuickNavItem(true, new ItemData("anvil"), "Anvil", "/anvil"); + @ConfigEntry.Gui.CollapsibleObject() + public final QuickNavItem button11 = new QuickNavItem(true, new ItemData("anvil"), "Anvil", "/anvil"); @ConfigEntry.Category("button12") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public QuickNavItem button12 = new QuickNavItem(true, new ItemData("crafting_table"), "Craft Item", "/craft"); + @ConfigEntry.Gui.CollapsibleObject() + public final QuickNavItem button12 = new QuickNavItem(true, new ItemData("crafting_table"), "Craft Item", "/craft"); } public static class QuickNavItem { @@ -93,14 +93,14 @@ public class SkyblockerConfig implements ConfigData { this.uiTitle = uiTitle; } - public Boolean render; + public final Boolean render; @ConfigEntry.Category("item") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public ItemData item; + @ConfigEntry.Gui.CollapsibleObject() + public final ItemData item; - public String uiTitle; - public String clickEvent; + public final String uiTitle; + public final String clickEvent; } public static class ItemData { @@ -116,55 +116,55 @@ public class SkyblockerConfig implements ConfigData { this.nbt = ""; } - public String itemName; - public int count; - public String nbt; + public final String itemName; + public final int count; + public final String nbt; } public static class General { - public boolean enableUpdateNotification = true; - public boolean backpackPreviewWithoutShift = false; + public final boolean enableUpdateNotification = true; + public final boolean backpackPreviewWithoutShift = false; @ConfigEntry.Gui.Excluded public String apiKey; @ConfigEntry.Category("bars") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public Bars bars = new Bars(); + @ConfigEntry.Gui.CollapsibleObject() + public final Bars bars = new Bars(); @ConfigEntry.Category("itemList") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public ItemList itemList = new ItemList(); + @ConfigEntry.Gui.CollapsibleObject() + public final ItemList itemList = new ItemList(); @ConfigEntry.Category("itemTooltip") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public ItemTooltip itemTooltip = new ItemTooltip(); + @ConfigEntry.Gui.CollapsibleObject() + public final ItemTooltip itemTooltip = new ItemTooltip(); @ConfigEntry.Category("hitbox") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public Hitbox hitbox = new Hitbox(); + @ConfigEntry.Gui.CollapsibleObject() + public final Hitbox hitbox = new Hitbox(); @ConfigEntry.Gui.Excluded - public List lockedSlots = new ArrayList<>(); + public final List lockedSlots = new ArrayList<>(); } public static class Bars { - public boolean enableBars = true; + public final boolean enableBars = true; @ConfigEntry.Category("barpositions") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public BarPositions barpositions = new BarPositions(); + @ConfigEntry.Gui.CollapsibleObject() + public final BarPositions barpositions = new BarPositions(); } public static class BarPositions { @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public BarPosition healthBarPosition = BarPosition.LAYER1; + public final BarPosition healthBarPosition = BarPosition.LAYER1; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public BarPosition manaBarPosition = BarPosition.LAYER1; + public final BarPosition manaBarPosition = BarPosition.LAYER1; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public BarPosition defenceBarPosition = BarPosition.LAYER1; + public final BarPosition defenceBarPosition = BarPosition.LAYER1; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public BarPosition experienceBarPosition = BarPosition.LAYER1; + public final BarPosition experienceBarPosition = BarPosition.LAYER1; } @@ -195,21 +195,21 @@ public class SkyblockerConfig implements ConfigData { } public static class Hitbox { - public boolean oldFarmlandHitbox = true; - public boolean oldLeverHitbox = false; + public final boolean oldFarmlandHitbox = true; + public final boolean oldLeverHitbox = false; } public static class RichPresence { - public boolean enableRichPresence = false; + public final boolean enableRichPresence = false; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) @ConfigEntry.Gui.Tooltip() - public Info info = Info.LOCATION; - public boolean cycleMode = false; + public final Info info = Info.LOCATION; + public final boolean cycleMode = false; public String customMessage; } public static class ItemList { - public boolean enableItemList = true; + public final boolean enableItemList = true; } public enum Average { @@ -228,79 +228,79 @@ public class SkyblockerConfig implements ConfigData { } public static class ItemTooltip { - public boolean enableNPCPrice = true; - public boolean enableAvgBIN = true; + public final boolean enableNPCPrice = true; + public final boolean enableAvgBIN = true; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) @ConfigEntry.Gui.Tooltip() - public Average avg = Average.THREE_DAY; - public boolean enableLowestBIN = true; - public boolean enableBazaarPrice = true; - public boolean enableMuseumDate = true; + public final Average avg = Average.THREE_DAY; + public final boolean enableLowestBIN = true; + public final boolean enableBazaarPrice = true; + public final boolean enableMuseumDate = true; } public static class Locations { @ConfigEntry.Category("dungeons") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public Dungeons dungeons = new Dungeons(); + @ConfigEntry.Gui.CollapsibleObject() + public final Dungeons dungeons = new Dungeons(); @ConfigEntry.Category("dwarvenmines") - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public DwarvenMines dwarvenMines = new DwarvenMines(); + @ConfigEntry.Gui.CollapsibleObject() + public final DwarvenMines dwarvenMines = new DwarvenMines(); } public static class Dungeons { @ConfigEntry.Gui.Tooltip() - public boolean croesusHelper = true; - public boolean enableMap = true; - public boolean solveThreeWeirdos = true; - public boolean blazesolver = true; - public boolean solveTrivia = true; - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public Terminals terminals = new Terminals(); + public final boolean croesusHelper = true; + public final boolean enableMap = true; + public final boolean solveThreeWeirdos = true; + public final boolean blazesolver = true; + public final boolean solveTrivia = true; + @ConfigEntry.Gui.CollapsibleObject() + public final Terminals terminals = new Terminals(); } public static class Terminals { - public boolean solveColor = true; - public boolean solveOrder = true; - public boolean solveStartsWith = true; + public final boolean solveColor = true; + public final boolean solveOrder = true; + public final boolean solveStartsWith = true; } public static class DwarvenMines { - public boolean enableDrillFuel = true; - public boolean solveFetchur = true; - public boolean solvePuzzler = true; - @ConfigEntry.Gui.CollapsibleObject(startExpanded = false) - public DwarvenHud dwarvenHud = new DwarvenHud(); + public final boolean enableDrillFuel = true; + public final boolean solveFetchur = true; + public final boolean solvePuzzler = true; + @ConfigEntry.Gui.CollapsibleObject() + public final DwarvenHud dwarvenHud = new DwarvenHud(); } public static class DwarvenHud { - public boolean enabled = true; - public boolean enableBackground = true; + public final boolean enabled = true; + public final boolean enableBackground = true; public int x = 10; public int y = 10; } public static class Messages { @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public ChatFilterResult hideAbility = ChatFilterResult.PASS; + public final ChatFilterResult hideAbility = ChatFilterResult.PASS; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public ChatFilterResult hideHeal = ChatFilterResult.PASS; + public final ChatFilterResult hideHeal = ChatFilterResult.PASS; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public ChatFilterResult hideAOTE = ChatFilterResult.PASS; + public final ChatFilterResult hideAOTE = ChatFilterResult.PASS; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public ChatFilterResult hideImplosion = ChatFilterResult.PASS; + public final ChatFilterResult hideImplosion = ChatFilterResult.PASS; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public ChatFilterResult hideMoltenWave = ChatFilterResult.PASS; + public final ChatFilterResult hideMoltenWave = ChatFilterResult.PASS; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public ChatFilterResult hideAds = ChatFilterResult.PASS; + public final ChatFilterResult hideAds = ChatFilterResult.PASS; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public ChatFilterResult hideTeleportPad = ChatFilterResult.PASS; + public final ChatFilterResult hideTeleportPad = ChatFilterResult.PASS; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public ChatFilterResult hideCombo = ChatFilterResult.PASS; + public final ChatFilterResult hideCombo = ChatFilterResult.PASS; @ConfigEntry.Gui.EnumHandler(option = ConfigEntry.Gui.EnumHandler.EnumDisplayOption.BUTTON) - public ChatFilterResult hideAutopet = ChatFilterResult.PASS; + public final ChatFilterResult hideAutopet = ChatFilterResult.PASS; @ConfigEntry.Gui.Tooltip() - public boolean hideMana = false; + public final boolean hideMana = false; } public enum Info { diff --git a/src/main/java/me/xmrvizzy/skyblocker/mixin/HandledScreenMixin.java b/src/main/java/me/xmrvizzy/skyblocker/mixin/HandledScreenMixin.java index 0cd82aad..e7b3515f 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/mixin/HandledScreenMixin.java +++ b/src/main/java/me/xmrvizzy/skyblocker/mixin/HandledScreenMixin.java @@ -6,7 +6,6 @@ import me.xmrvizzy.skyblocker.skyblock.item.WikiLookup; import me.xmrvizzy.skyblocker.skyblock.quicknav.QuickNav; import me.xmrvizzy.skyblocker.skyblock.quicknav.QuickNavButton; import me.xmrvizzy.skyblocker.utils.Utils; -import net.minecraft.client.MinecraftClient; import net.minecraft.client.gui.screen.Screen; import net.minecraft.client.gui.screen.ingame.HandledScreen; import net.minecraft.client.util.math.MatrixStack; @@ -24,14 +23,13 @@ import java.util.List; @Mixin(HandledScreen.class) public abstract class HandledScreenMixin extends Screen { - @Shadow protected int backgroundWidth; - @Shadow protected int backgroundHeight; - protected HandledScreenMixin(Text title) { super(title); } + @Shadow - @Nullable protected Slot focusedSlot; + @Nullable + protected Slot focusedSlot; @Inject(method = "init()V", at = @At("TAIL")) private void init(CallbackInfo ci) { @@ -42,13 +40,13 @@ public abstract class HandledScreenMixin extends Screen { for (QuickNavButton button : buttons) super.addDrawableChild(button); } // backpack preview - BackpackPreview.updateStorage((HandledScreen)(Object)this); + BackpackPreview.updateStorage((HandledScreen) (Object) this); } - @Inject(at = @At("HEAD"), method = "keyPressed", cancellable = true) + @Inject(at = @At("HEAD"), method = "keyPressed") public void keyPressed(int keyCode, int scanCode, int modifiers, CallbackInfoReturnable cir) { - if (this.focusedSlot != null){ - if (keyCode != 256 && !this.client.options.inventoryKey.matchesKey(keyCode, scanCode)){ + if (this.focusedSlot != null) { + if (keyCode != 256 && !this.client.options.inventoryKey.matchesKey(keyCode, scanCode)) { if (WikiLookup.wikiLookup.matchesKey(keyCode, scanCode)) WikiLookup.openWiki(this.focusedSlot); } } @@ -56,7 +54,7 @@ public abstract class HandledScreenMixin extends Screen { @Inject(at = @At("HEAD"), method = "drawMouseoverTooltip", cancellable = true) public void drawMouseOverTooltip(MatrixStack matrices, int x, int y, CallbackInfo ci) { - String title = ((HandledScreen)(Object)this).getTitle().getString(); + String title = this.getTitle().getString(); boolean shiftDown = SkyblockerConfig.get().general.backpackPreviewWithoutShift ^ Screen.hasShiftDown(); if (shiftDown && title.equals("Storage") && this.focusedSlot != null) { if (this.focusedSlot.inventory == this.client.player.getInventory()) return; diff --git a/src/main/java/me/xmrvizzy/skyblocker/mixin/InGameHudMixin.java b/src/main/java/me/xmrvizzy/skyblocker/mixin/InGameHudMixin.java index 60f4af53..d9001ba7 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/mixin/InGameHudMixin.java +++ b/src/main/java/me/xmrvizzy/skyblocker/mixin/InGameHudMixin.java @@ -53,7 +53,7 @@ public abstract class InGameHudMixin extends DrawableHelper { return; String msg = message.getString(); String res = statusBarTracker.update(msg, SkyblockerConfig.get().messages.hideMana); - if (msg != res) { + if (!msg.equals(res)) { if (res != null) setOverlayMessage(Text.of(res), tinted); ci.cancel(); @@ -73,7 +73,7 @@ public abstract class InGameHudMixin extends DrawableHelper { if (Utils.isOnSkyblock) { if (HotbarSlotLock.isLocked(hotbarSlotIndex)) { RenderSystem.setShaderTexture(0,SLOT_LOCK); - this.drawTexture(hotbarMatrices, i, j, 0, 0,16, 16); + DrawableHelper.drawTexture(hotbarMatrices, i, j, 0, 0,16, 16); } hotbarSlotIndex++; } diff --git a/src/main/java/me/xmrvizzy/skyblocker/mixin/InventoryScreenMixin.java b/src/main/java/me/xmrvizzy/skyblocker/mixin/InventoryScreenMixin.java index 4bff2779..0cba11c8 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/mixin/InventoryScreenMixin.java +++ b/src/main/java/me/xmrvizzy/skyblocker/mixin/InventoryScreenMixin.java @@ -12,7 +12,7 @@ import org.spongepowered.asm.mixin.injection.Redirect; @Mixin(InventoryScreen.class) public class InventoryScreenMixin { @Redirect( - method = "", + method = "", at = @At( value = "NEW", target = "net/minecraft/client/gui/screen/recipebook/RecipeBookWidget" diff --git a/src/main/java/me/xmrvizzy/skyblocker/mixin/ItemRendererMixin.java b/src/main/java/me/xmrvizzy/skyblocker/mixin/ItemRendererMixin.java index 1de2617b..aa0d8704 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/mixin/ItemRendererMixin.java +++ b/src/main/java/me/xmrvizzy/skyblocker/mixin/ItemRendererMixin.java @@ -43,8 +43,6 @@ public abstract class ItemRendererMixin { } RenderSystem.disableDepthTest(); -// RenderSystem.disableTexture(); -// RenderSystem.disableAlphaTest(); RenderSystem.disableBlend(); float hue = Math.max(0.0F, 1.0F - (max - current) / max); int width = Math.round(current / max * 13.0F); @@ -52,8 +50,6 @@ public abstract class ItemRendererMixin { DrawableHelper.fill(matrices, x + 2, y + 13, x + 15, y + 15, 0xFF000000); DrawableHelper.fill(matrices, x + 2, y + 13, x + 2 + width, y + 14, rgb); RenderSystem.enableBlend(); -// RenderSystem.enableAlphaTest(); -// RenderSystem.enableTexture(); RenderSystem.enableDepthTest(); } } diff --git a/src/main/java/me/xmrvizzy/skyblocker/skyblock/BackpackPreview.java b/src/main/java/me/xmrvizzy/skyblocker/skyblock/BackpackPreview.java index 29b8dd79..d8cca051 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/skyblock/BackpackPreview.java +++ b/src/main/java/me/xmrvizzy/skyblocker/skyblock/BackpackPreview.java @@ -48,7 +48,7 @@ public class BackpackPreview extends DrawableHelper { // update save dir based on uuid and sb profile String uuid = MinecraftClient.getInstance().getSession().getUuid().replaceAll("-", ""); String profile = getSkyblockProfile(); - if (uuid != null && profile != null) { + if (profile != null) { save_dir = FabricLoader.getInstance().getConfigDir().resolve("skyblocker/backpack-preview/" + uuid + "/" + profile); save_dir.toFile().mkdirs(); if (loaded.equals(uuid + "/" + profile)) { @@ -121,7 +121,7 @@ public class BackpackPreview extends DrawableHelper { String title = screen.getTitle().getString(); int index = getStorageIndexFromTitle(title); if (index != -1) { - storage[index] = ((HandledScreen) screen).getScreenHandler().slots.get(0).inventory; + storage[index] = screen.getScreenHandler().slots.get(0).inventory; dirty[index] = true; } } @@ -140,10 +140,10 @@ public class BackpackPreview extends DrawableHelper { RenderSystem.disableDepthTest(); RenderSystem.setShaderTexture(0, TEXTURE); - instance.drawTexture(matrices, x, y, 0, 0, 176, 7); + BackpackPreview.drawTexture(matrices, x, y, 0, 0, 176, 7); for (int i = 0; i < rows; ++i) - instance.drawTexture(matrices, x, y + i * 18 + 7, 0, 7, 176, 18); - instance.drawTexture(matrices, x, y + rows * 18 + 7, 0, 25, 176, 7); + BackpackPreview.drawTexture(matrices, x, y + i * 18 + 7, 0, 7, 176, 18); + BackpackPreview.drawTexture(matrices, x, y + rows * 18 + 7, 0, 25, 176, 7); RenderSystem.enableDepthTest(); ItemRenderer itemRenderer = MinecraftClient.getInstance().getItemRenderer(); @@ -184,7 +184,7 @@ public class BackpackPreview extends DrawableHelper { } class DummyInventory implements Inventory { - private List stacks; + private final List stacks; public DummyInventory(NbtCompound root) { stacks = new ArrayList<>(root.getInt("size") + 9); diff --git a/src/main/java/me/xmrvizzy/skyblocker/skyblock/FancyStatusBars.java b/src/main/java/me/xmrvizzy/skyblocker/skyblock/FancyStatusBars.java index 15a45e2e..05b57410 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/skyblock/FancyStatusBars.java +++ b/src/main/java/me/xmrvizzy/skyblocker/skyblock/FancyStatusBars.java @@ -6,7 +6,6 @@ import me.xmrvizzy.skyblocker.config.SkyblockerConfig; import net.minecraft.client.MinecraftClient; import net.minecraft.client.font.TextRenderer; import net.minecraft.client.gui.DrawableHelper; -import net.minecraft.client.network.ClientPlayerEntity; import net.minecraft.client.util.math.MatrixStack; import net.minecraft.util.Identifier; diff --git a/src/main/java/me/xmrvizzy/skyblocker/skyblock/api/ApiKeyListener.java b/src/main/java/me/xmrvizzy/skyblocker/skyblock/api/ApiKeyListener.java index 679901cd..dec2835b 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/skyblock/api/ApiKeyListener.java +++ b/src/main/java/me/xmrvizzy/skyblocker/skyblock/api/ApiKeyListener.java @@ -6,7 +6,7 @@ import me.xmrvizzy.skyblocker.chat.ChatPatternListener; import me.xmrvizzy.skyblocker.config.SkyblockerConfig; import net.minecraft.client.MinecraftClient; import net.minecraft.text.Text; -import net.minecraft.text.TranslatableTextContent; + import java.util.regex.Matcher; public class ApiKeyListener extends ChatPatternListener { diff --git a/src/main/java/me/xmrvizzy/skyblocker/skyblock/api/StatsCommand.java b/src/main/java/me/xmrvizzy/skyblocker/skyblock/api/StatsCommand.java index 4cf6c84d..3e848925 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/skyblock/api/StatsCommand.java +++ b/src/main/java/me/xmrvizzy/skyblocker/skyblock/api/StatsCommand.java @@ -11,21 +11,19 @@ import net.minecraft.text.Text; public class StatsCommand { public static void init(){ - ClientCommandRegistrationCallback.EVENT.register((dispatcher, registryAccess) -> { - dispatcher.register(ClientCommandManager.literal("skyblocker") - .then(ClientCommandManager.literal("debug") - .then(ClientCommandManager.literal("stats").then(ClientCommandManager.argument("username", StringArgumentType.string()) - .executes(context -> { - new Thread(() -> { - PlayerProfiles playerProfiles = ProfileUtils.getProfiles(StringArgumentType.getString(context, "username")); - for (String profileId : playerProfiles.profiles().keySet()){ - MinecraftClient.getInstance().player.sendMessage(Text.literal(playerProfiles.profiles().get(profileId).cuteName()) - .styled(style -> style.withClickEvent(new ClickEvent(ClickEvent.Action.COPY_TO_CLIPBOARD, new GsonBuilder().serializeNulls().setPrettyPrinting().create().toJson(playerProfiles.profiles().get(profileId))))), false); - } - }).start(); - return 1; - }))))); - }); + ClientCommandRegistrationCallback.EVENT.register((dispatcher, registryAccess) -> dispatcher.register(ClientCommandManager.literal("skyblocker") + .then(ClientCommandManager.literal("debug") + .then(ClientCommandManager.literal("stats").then(ClientCommandManager.argument("username", StringArgumentType.string()) + .executes(context -> { + new Thread(() -> { + PlayerProfiles playerProfiles = ProfileUtils.getProfiles(StringArgumentType.getString(context, "username")); + for (String profileId : playerProfiles.profiles().keySet()){ + MinecraftClient.getInstance().player.sendMessage(Text.literal(playerProfiles.profiles().get(profileId).cuteName()) + .styled(style -> style.withClickEvent(new ClickEvent(ClickEvent.Action.COPY_TO_CLIPBOARD, new GsonBuilder().serializeNulls().setPrettyPrinting().create().toJson(playerProfiles.profiles().get(profileId))))), false); + } + }).start(); + return 1; + })))))); } } diff --git a/src/main/java/me/xmrvizzy/skyblocker/skyblock/api/records/mining/Mining.java b/src/main/java/me/xmrvizzy/skyblocker/skyblock/api/records/mining/Mining.java index d974f5c6..d6f52fe4 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/skyblock/api/records/mining/Mining.java +++ b/src/main/java/me/xmrvizzy/skyblocker/skyblock/api/records/mining/Mining.java @@ -1,10 +1,5 @@ package me.xmrvizzy.skyblocker.skyblock.api.records.mining; -import com.google.gson.annotations.SerializedName; -import me.xmrvizzy.skyblocker.skyblock.api.records.PlayerProfiles; - -import java.util.HashMap; - public record Mining( Commissions commissions, Forge forge, diff --git a/src/main/java/me/xmrvizzy/skyblocker/skyblock/dungeon/OldLever.java b/src/main/java/me/xmrvizzy/skyblocker/skyblock/dungeon/OldLever.java index c836e4f3..37320c92 100644 --- a/src/main/java/me/xmrvizzy/skyblocker/skyblock/dungeon/OldLever.java +++ b/src/main/java/me/xmrvizzy/skyblocker/skyblock/dungeon/OldLever.java @@ -21,14 +21,18 @@ public class OldLever { retur