From 1f980eae2b1e63ad52dc5179930288a0572940fb Mon Sep 17 00:00:00 2001 From: Owen <64725743+Ownwn@users.noreply.github.com> Date: Wed, 18 Jun 2025 06:26:29 +1200 Subject: Make custom item rename more friendly (#1355) * add item rename command hint * Add simple string arg as fallback --- .../de/hysky/skyblocker/skyblock/item/custom/CustomItemNames.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/main/java') diff --git a/src/main/java/de/hysky/skyblocker/skyblock/item/custom/CustomItemNames.java b/src/main/java/de/hysky/skyblocker/skyblock/item/custom/CustomItemNames.java index 23ff68e5..2cb7ca91 100644 --- a/src/main/java/de/hysky/skyblocker/skyblock/item/custom/CustomItemNames.java +++ b/src/main/java/de/hysky/skyblocker/skyblock/item/custom/CustomItemNames.java @@ -2,6 +2,7 @@ package de.hysky.skyblocker.skyblock.item.custom; import com.mojang.brigadier.Command; import com.mojang.brigadier.CommandDispatcher; +import com.mojang.brigadier.arguments.StringArgumentType; import de.hysky.skyblocker.annotations.Init; import de.hysky.skyblocker.config.SkyblockerConfigManager; import de.hysky.skyblocker.utils.Constants; @@ -29,7 +30,10 @@ public class CustomItemNames { .then(ClientCommandManager.literal("renameItem") .executes(context -> renameItem(context.getSource(), null)) .then(ClientCommandManager.argument("textComponent", TextArgumentType.text(registryAccess)) - .executes(context -> renameItem(context.getSource(), context.getArgument("textComponent", Text.class))))))); + .executes(context -> renameItem(context.getSource(), context.getArgument("textComponent", Text.class)))) + // greedy string will only consume the arg if the text component parsing fails. + .then(ClientCommandManager.argument("basicText", StringArgumentType.greedyString()) + .executes(context -> renameItem(context.getSource(), Text.of(context.getArgument("basicText", String.class)))))))); } @SuppressWarnings("SameReturnValue") -- cgit