From f239c9e6661cbecda5e079dd2f365d0fae2ea8d2 Mon Sep 17 00:00:00 2001 From: Kevin <92656833+kevinthegreat1@users.noreply.github.com> Date: Thu, 9 Jan 2025 11:07:50 -0500 Subject: Random fixes (#1120) * Refactor bazaar and roman numerals * Revert name from api * Fix neu id * Fix roman numerals * Apply suggestions from code review * Fix level type * Fix import --------- Co-authored-by: Rime <81419447+Emirlol@users.noreply.github.com> --- .../de/hysky/skyblocker/utils/RomanNumeralsTest.java | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) (limited to 'src/test/java') diff --git a/src/test/java/de/hysky/skyblocker/utils/RomanNumeralsTest.java b/src/test/java/de/hysky/skyblocker/utils/RomanNumeralsTest.java index 35bd76ee..ac6861b9 100644 --- a/src/test/java/de/hysky/skyblocker/utils/RomanNumeralsTest.java +++ b/src/test/java/de/hysky/skyblocker/utils/RomanNumeralsTest.java @@ -5,11 +5,11 @@ import org.junit.jupiter.api.Test; class RomanNumeralsTest { @Test - void testToRoman() { + void testRomanToDecimal() { // Test the first 50 numbers String[] expected = new String[]{"I", "II", "III", "IV", "V", "VI", "VII", "VIII", "IX", "X", "XI", "XII", "XIII", "XIV", "XV", "XVI", "XVII", "XVIII", "XIX", "XX", "XXI", "XXII", "XXIII", "XXIV", "XXV", "XXVI", "XXVII", "XXVIII", "XXIX", "XXX", "XXXI", "XXXII", "XXXIII", "XXXIV", "XXXV", "XXXVI", "XXXVII", "XXXVIII", "XXXIX", "XL", "XLI", "XLII", "XLIII", "XLIV", "XLV", "XLVI", "XLVII", "XLVIII", "XLIX", "L"}; for (int i = 1; i <= 50; i++) { - Assertions.assertEquals(i, RomanNumerals.romanToDecimal(expected[i-1])); + Assertions.assertEquals(i, RomanNumerals.romanToDecimal(expected[i - 1])); } Assertions.assertEquals(100, RomanNumerals.romanToDecimal("C")); Assertions.assertEquals(400, RomanNumerals.romanToDecimal("CD")); @@ -32,4 +32,18 @@ class RomanNumeralsTest { Assertions.assertFalse(RomanNumerals.isValidRomanNumeral(null)); Assertions.assertFalse(RomanNumerals.isValidRomanNumeral("")); } + + @Test + void testDecimalToRoman() { + String[] expected = new String[]{"I", "II", "III", "IV", "V", "VI", "VII", "VIII", "IX", "X", "XI", "XII", "XIII", "XIV", "XV", "XVI", "XVII", "XVIII", "XIX", "XX", "XXI", "XXII", "XXIII", "XXIV", "XXV", "XXVI", "XXVII", "XXVIII", "XXIX", "XXX", "XXXI", "XXXII", "XXXIII", "XXXIV", "XXXV", "XXXVI", "XXXVII", "XXXVIII", "XXXIX", "XL", "XLI", "XLII", "XLIII", "XLIV", "XLV", "XLVI", "XLVII", "XLVIII", "XLIX", "L"}; + for (int i = 1; i <= 50; i++) { + Assertions.assertEquals(expected[i - 1], RomanNumerals.decimalToRoman(i)); + } + Assertions.assertEquals("C", RomanNumerals.decimalToRoman(100)); + Assertions.assertEquals("CD", RomanNumerals.decimalToRoman(400)); + Assertions.assertEquals("D", RomanNumerals.decimalToRoman(500)); + Assertions.assertEquals("CM", RomanNumerals.decimalToRoman(900)); + Assertions.assertEquals("M", RomanNumerals.decimalToRoman(1000)); + Assertions.assertEquals("MCMXCIX", RomanNumerals.decimalToRoman(1999)); + } } -- cgit