From 64a1aba1db539ea854fdc832b1a8e53ac7428263 Mon Sep 17 00:00:00 2001 From: Jonas Herzig Date: Thu, 6 Jan 2022 14:01:18 +0100 Subject: Fix missing SrgProvider when generateSrgTiny is false A fallback SrgProvider is instantiated and initialized here but never added to the provider list, resulting in a NPE right below in `getRawSrgFile`. --- .../loom/configuration/providers/mappings/MappingsProviderImpl.java | 1 + 1 file changed, 1 insertion(+) (limited to 'src/main/java') diff --git a/src/main/java/net/fabricmc/loom/configuration/providers/mappings/MappingsProviderImpl.java b/src/main/java/net/fabricmc/loom/configuration/providers/mappings/MappingsProviderImpl.java index 23bf71c8..0f4614ce 100644 --- a/src/main/java/net/fabricmc/loom/configuration/providers/mappings/MappingsProviderImpl.java +++ b/src/main/java/net/fabricmc/loom/configuration/providers/mappings/MappingsProviderImpl.java @@ -340,6 +340,7 @@ public class MappingsProviderImpl extends DependencyProvider implements Mappings getProject().getDependencies().add(provider.getTargetConfig(), "de.oceanlabs.mcp:mcp_config:" + getMinecraftProvider().minecraftVersion()); Configuration configuration = getProject().getConfigurations().getByName(provider.getTargetConfig()); provider.provide(DependencyInfo.create(getProject(), configuration.getDependencies().iterator().next(), configuration), postPopulationScheduler); + getExtension().getDependencyManager().addProvider(provider); } Path srgPath = getRawSrgFile(); -- cgit