Data class fix

4 files changed, 104 insertions, 13 deletions

diff --git a/plugins/base/src/main/kotlin/translators/descriptors/DefaultDescriptorToDocumentableTranslator.kt b/plugins/base/src/main/kotlin/translators/descriptors/DefaultDescriptorToDocumentableTranslator.kt
index 54bd793c..ffceaaa7 100644
--- a/plugins/base/src/main/kotlin/translators/descriptors/DefaultDescriptorToDocumentableTranslator.kt
+++ b/plugins/base/src/main/kotlin/translators/descriptors/DefaultDescriptorToDocumentableTranslator.kt
@@ -356,7 +356,7 @@ private class DokkaDescriptorVisitor(
             sources = actual,
             visibility = descriptor.visibility.toDokkaVisibility().toSourceSetDependent(),
             generics = descriptor.typeParameters.map { it.toTypeParameter() },
-            documentation = descriptor.resolveDescriptorData(),
+            documentation = descriptor.takeIf { it.kind != CallableMemberDescriptor.Kind.SYNTHESIZED }?.resolveDescriptorData() ?: emptyMap(),
             modifier = descriptor.modifier().toSourceSetDependent(),
             type = descriptor.returnType!!.toBound(),
             sourceSets = setOf(sourceSet),
diff --git a/plugins/base/src/test/kotlin/translators/DefaultDescriptorToDocumentableTranslatorTest.kt b/plugins/base/src/test/kotlin/translators/DefaultDescriptorToDocumentableTranslatorTest.kt
new file mode 100644
index 00000000..b0754429
--- /dev/null
+++ b/plugins/base/src/test/kotlin/translators/DefaultDescriptorToDocumentableTranslatorTest.kt
@@ -0,0 +1,87 @@
+package translators
+
+import org.jetbrains.dokka.testApi.testRunner.AbstractCoreTest
+import org.junit.jupiter.api.Assertions
+import org.junit.jupiter.api.Test
+
+class DefaultDescriptorToDocumentableTranslatorTest : AbstractCoreTest() {
+
+    @Test
+    fun `data class kdocs over generated methods`() {
+        val configuration = dokkaConfiguration {
+            sourceSets {
+                sourceSet {
+                    sourceRoots = listOf("src/main/kotlin")
+                }
+            }
+        }
+
+        testInline(
+            """
+            |/src/main/kotlin/sample/XD.kt
+            |package sample
+            |/**
+            | * But the fat Hobbit, he knows. Eyes always watching.
+            | */
+            |data class XD(val xd: String) {
+            |   /**
+            |    * But the fat Hobbit, he knows. Eyes always watching.
+            |    */
+            |   fun custom(): String = ""
+            |
+            |   /**
+            |    * Memory is not what the heart desires. That is only a mirror.
+            |    */
+            |   override fun equals(other: Any?): Boolean = true
+            |}
+            """.trimIndent(),
+            configuration
+        ) {
+            documentablesMergingStage = { module ->
+                assert(module.documentationOf("XD", "copy") == "")
+                assert(module.documentationOf("XD", "equals") == "Memory is not what the heart desires. That is only a mirror.")
+                assert(module.documentationOf("XD", "hashCode") == "")
+                assert(module.documentationOf("XD", "toString") == "")
+                assert(module.documentationOf("XD", "custom") == "But the fat Hobbit, he knows. Eyes always watching.")
+            }
+        }
+    }
+
+    @Test
+    fun `simple class kdocs`() {
+        val configuration = dokkaConfiguration {
+            sourceSets {
+                sourceSet {
+                    sourceRoots = listOf("src/main/kotlin")
+                }
+            }
+        }
+
+        testInline(
+            """
+            |/src/main/kotlin/sample/XD.kt
+            |package sample
+            |/**
+            | * But the fat Hobbit, he knows. Eyes always watching.
+            | */
+            |class XD(val xd: String) {
+            |   /**
+            |    * But the fat Hobbit, he knows. Eyes always watching.
+            |    */
+            |   fun custom(): String = ""
+            |
+            |   /**
+            |    * Memory is not what the heart desires. That is only a mirror.
+            |    */
+            |   override fun equals(other: Any?): Boolean = true
+            |}
+            """.trimIndent(),
+            configuration
+        ) {
+            documentablesMergingStage = { module ->
+                assert(module.documentationOf("XD", "custom") == "But the fat Hobbit, he knows. Eyes always watching.")
+                assert(module.documentationOf("XD", "equals") == "Memory is not what the heart desires. That is only a mirror.")
+            }
+        }
+    }
+}
\ No newline at end of file
diff --git a/plugins/base/src/test/kotlin/translators/DefaultPsiToDocumentableTranslatorTest.kt b/plugins/base/src/test/kotlin/translators/DefaultPsiToDocumentableTranslatorTest.kt
index 95fbb3c6..eb682b14 100644
--- a/plugins/base/src/test/kotlin/translators/DefaultPsiToDocumentableTranslatorTest.kt
+++ b/plugins/base/src/test/kotlin/translators/DefaultPsiToDocumentableTranslatorTest.kt
@@ -141,16 +141,4 @@ class DefaultPsiToDocumentableTranslatorTest : AbstractCoreTest() {
             }
         }
     }
-
-    private fun DModule.documentationOf(className: String, functionName: String): String {
-        return (packages.single()
-            .classlikes.single { it.name == className }
-            .functions.single { it.name == functionName }
-            .documentation.values.single()
-            .children.singleOrNull()
-            .run { this as? Description }
-            ?.root?.children?.single() as? Text)
-            ?.body.orEmpty()
-    }
-
 }
diff --git a/plugins/base/src/test/kotlin/translators/utils.kt b/plugins/base/src/test/kotlin/translators/utils.kt
new file mode 100644
index 00000000..96d3035a
--- /dev/null
+++ b/plugins/base/src/test/kotlin/translators/utils.kt
@@ -0,0 +1,16 @@
+package translators
+
+import org.jetbrains.dokka.model.DModule
+import org.jetbrains.dokka.model.doc.Description
+import org.jetbrains.dokka.model.doc.Text
+
+fun DModule.documentationOf(className: String, functionName: String): String {
+    return (packages.single()
+        .classlikes.single { it.name == className }
+        .functions.single { it.name == functionName }
+        .documentation.values.singleOrNull()
+        ?.children?.singleOrNull()
+        .run { this as? Description }
+        ?.root?.children?.single() as? Text)
+        ?.body.orEmpty()
+}
\ No newline at end of file