From ef753c8a1b9f02d9f6f026d555d628fbb207c574 Mon Sep 17 00:00:00 2001
From: Simon Ogorodnik <Simon.Ogorodnik@jetbrains.com>
Date: Mon, 27 Feb 2017 18:30:30 +0300
Subject: Package platforms detected based on it's members, refactored
 multiplatform tests layout

---
 core/src/main/kotlin/Formats/KotlinWebsiteFormatService.kt |  2 +-
 core/src/main/kotlin/Formats/StructuredFormatService.kt    | 11 ++++++++---
 2 files changed, 9 insertions(+), 4 deletions(-)

(limited to 'core/src/main')

diff --git a/core/src/main/kotlin/Formats/KotlinWebsiteFormatService.kt b/core/src/main/kotlin/Formats/KotlinWebsiteFormatService.kt
index 6366ff61..0444a25a 100644
--- a/core/src/main/kotlin/Formats/KotlinWebsiteFormatService.kt
+++ b/core/src/main/kotlin/Formats/KotlinWebsiteFormatService.kt
@@ -148,7 +148,7 @@ open class KotlinWebsiteOutputBuilder(to: StringBuilder,
 
     override fun appendIndexRow(platforms: Set<String>, block: () -> Unit) {
         if (platforms.isNotEmpty())
-            wrap("<tr data-platform=\"${platforms.joinToString(" ")}\">", "</tr>", block)
+            wrap("<tr data-platform=\"${platforms.joinToString()}\">", "</tr>", block)
         else
             appendTableRow(block)
     }
diff --git a/core/src/main/kotlin/Formats/StructuredFormatService.kt b/core/src/main/kotlin/Formats/StructuredFormatService.kt
index b5a35356..79ebabe0 100644
--- a/core/src/main/kotlin/Formats/StructuredFormatService.kt
+++ b/core/src/main/kotlin/Formats/StructuredFormatService.kt
@@ -408,7 +408,7 @@ abstract class StructuredOutputBuilder(val to: StringBuilder,
                 return
             }
 
-            appendSection("Packages", node.members(NodeKind.Package))
+            appendSection("Packages", node.members(NodeKind.Package), platformsBasedOnMembers = true)
             appendSection("Types", node.members.filter { it.kind in NodeKind.classLike && it.kind != NodeKind.TypeAlias && it.kind != NodeKind.AnnotationClass && it.kind != NodeKind.Exception })
             appendSection("Annotations", node.members(NodeKind.AnnotationClass))
             appendSection("Exceptions", node.members(NodeKind.Exception))
@@ -463,7 +463,8 @@ abstract class StructuredOutputBuilder(val to: StringBuilder,
 
         private fun appendSection(caption: String, members: List<DocumentationNode>,
                                   sortMembers: Boolean = true,
-                                  omitSamePlatforms: Boolean = false) {
+                                  omitSamePlatforms: Boolean = false,
+                                  platformsBasedOnMembers: Boolean = false) {
             if (members.isEmpty()) return
 
             appendHeader(3) { appendText(caption) }
@@ -476,7 +477,11 @@ abstract class StructuredOutputBuilder(val to: StringBuilder,
             appendTable("Name", "Summary") {
                 appendTableBody {
                     for ((memberLocation, members) in membersMap) {
-                        val platforms = platformsOfItems(members, omitSamePlatforms)
+                        val elementPlatforms = platformsOfItems(members, omitSamePlatforms)
+                        val platforms = if (platformsBasedOnMembers)
+                            members.flatMapTo(mutableSetOf()) { platformsOfItems(it.members) } + elementPlatforms
+                        else
+                            elementPlatforms
                         appendIndexRow(platforms) {
                             appendTableCell {
                                 appendLink(memberLocation)
-- 
cgit 


From bc71b31be28ed558e022babcf40ec1fd3bff923a Mon Sep 17 00:00:00 2001
From: Simon Ogorodnik <Simon.Ogorodnik@jetbrains.com>
Date: Mon, 27 Feb 2017 20:08:31 +0300
Subject: Platform and version requirements for packages. Fixed tests.

Post review.
---
 .../main/kotlin/Formats/StructuredFormatService.kt   | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

(limited to 'core/src/main')

diff --git a/core/src/main/kotlin/Formats/StructuredFormatService.kt b/core/src/main/kotlin/Formats/StructuredFormatService.kt
index 79ebabe0..a7b696eb 100644
--- a/core/src/main/kotlin/Formats/StructuredFormatService.kt
+++ b/core/src/main/kotlin/Formats/StructuredFormatService.kt
@@ -263,6 +263,7 @@ abstract class StructuredOutputBuilder(val to: StringBuilder,
                     val packageName = if (singleNode.name.isEmpty()) "<root>" else singleNode.name
                     appendHeader(2) { appendText("Package $packageName") }
                 }
+                singleNode.appendPlatforms()
                 appendContent(singleNode.content)
             } else {
                 val breakdownByName = nodes.groupBy { node -> node.name }
@@ -354,13 +355,25 @@ abstract class StructuredOutputBuilder(val to: StringBuilder,
         }
 
         private fun DocumentationNode.appendPlatforms() {
-            val platforms = platformsToShow.ifEmpty { return }
+            val platforms = if (isModuleOrPackage())
+                platformsToShow.toSet() + platformsOfItems(members)
+            else
+                platformsToShow
+
+            if(platforms.isEmpty()) return
+
             appendParagraph {
                 appendStrong { to.append("Platform and version requirements:") }
                 to.append(" " + platforms.joinToString())
             }
         }
 
+        protected fun platformsOfItems(items: List<DocumentationNode>): Set<String> =
+                items.foldRight(items.first().platformsToShow.toSet()) {
+                    node, platforms ->
+                    platforms.intersect(node.platformsToShow)
+                }
+
         val DocumentationNode.platformsToShow: List<String>
             get() = platforms.let { if (it.containsAll(impliedPlatforms)) it - impliedPlatforms else it }
 
@@ -501,10 +514,7 @@ abstract class StructuredOutputBuilder(val to: StringBuilder,
         }
 
         private fun platformsOfItems(items: List<DocumentationNode>, omitSamePlatforms: Boolean = true): Set<String> {
-            val platforms = items.foldRight(items.first().platformsToShow.toSet()) {
-                node, platforms ->
-                platforms.intersect(node.platformsToShow)
-            }
+            val platforms = platformsOfItems(items)
             if (platforms.isNotEmpty() && (platforms != node.platformsToShow.toSet() || !omitSamePlatforms)) {
                 return platforms
             }
-- 
cgit