From 6051ab5051be76d6c830a9996901bfbb9e1f901e Mon Sep 17 00:00:00 2001
From: Dmitry Jemerov <yole@jetbrains.com>
Date: Thu, 31 Mar 2016 15:38:07 +0200
Subject: Fix the implementation of containingClass() in javadoc adapters.
 Resolves #57

---
 core/src/main/kotlin/javadoc/docbase.kt     | 12 +++++++-----
 core/src/test/kotlin/javadoc/JavadocTest.kt | 14 ++++++++++----
 core/testdata/javadoc/exception.kt          |  5 +++++
 3 files changed, 22 insertions(+), 9 deletions(-)
 create mode 100644 core/testdata/javadoc/exception.kt

(limited to 'core')

diff --git a/core/src/main/kotlin/javadoc/docbase.kt b/core/src/main/kotlin/javadoc/docbase.kt
index db5f201e..4298316f 100644
--- a/core/src/main/kotlin/javadoc/docbase.kt
+++ b/core/src/main/kotlin/javadoc/docbase.kt
@@ -156,12 +156,10 @@ class ProgramElementAdapter(module: ModuleNodeAdapter, node: DocumentationNode)
 
         var owner = node.owner
         while (owner != null) {
-            when (owner.kind) {
-                NodeKind.Class,
-                NodeKind.Interface,
-                NodeKind.Enum -> return ClassDocumentationNodeAdapter(module, owner)
-                else -> owner = owner.owner
+            if (owner.kind in NodeKind.classLike) {
+                return ClassDocumentationNodeAdapter(module, owner)
             }
+            owner = owner.owner
         }
 
         return null
@@ -346,6 +344,10 @@ open class ExecutableMemberAdapter(module: ModuleNodeAdapter, node: Documentatio
 
 class ConstructorAdapter(module: ModuleNodeAdapter, node: DocumentationNode) : ExecutableMemberAdapter(module, node), ConstructorDoc {
     override fun name(): String = node.owner?.name ?: throw IllegalStateException("No owner for $node")
+
+    override fun containingClass(): ClassDoc? {
+        return super.containingClass()
+    }
 }
 
 class MethodAdapter(module: ModuleNodeAdapter, node: DocumentationNode) : DocumentationNodeAdapter(module, node), ExecutableMemberDoc by ExecutableMemberAdapter(module, node), MethodDoc {
diff --git a/core/src/test/kotlin/javadoc/JavadocTest.kt b/core/src/test/kotlin/javadoc/JavadocTest.kt
index 0fc4233a..b848aaa1 100644
--- a/core/src/test/kotlin/javadoc/JavadocTest.kt
+++ b/core/src/test/kotlin/javadoc/JavadocTest.kt
@@ -2,11 +2,8 @@ package org.jetbrains.dokka.javadoc
 
 import org.jetbrains.dokka.DokkaConsoleLogger
 import org.jetbrains.dokka.tests.verifyModel
+import org.junit.Assert.*
 import org.junit.Test
-import org.junit.Assert.assertEquals
-import org.junit.Assert.assertFalse
-import org.junit.Assert.assertNotNull
-import org.junit.Assert.assertTrue
 
 class JavadocTest {
     @Test fun testTypes() {
@@ -41,4 +38,13 @@ class JavadocTest {
         }
     }
 
+    @Test fun testException() {
+        verifyModel("testdata/javadoc/exception.kt", format = "javadoc", withKotlinRuntime = true) { model ->
+            val doc = ModuleNodeAdapter(model, StandardReporter(DokkaConsoleLogger), "")
+
+            val classDoc = doc.classNamed("foo.MyException")!!
+            val member = classDoc.methods().find { it.name() == "foo" }
+            assertEquals(classDoc, member!!.containingClass())
+        }
+    }
 }
diff --git a/core/testdata/javadoc/exception.kt b/core/testdata/javadoc/exception.kt
new file mode 100644
index 00000000..ec0a5bbb
--- /dev/null
+++ b/core/testdata/javadoc/exception.kt
@@ -0,0 +1,5 @@
+package foo
+
+class MyException : Exception {
+    fun foo() = ""
+}
-- 
cgit